[
https://issues.apache.org/jira/browse/LIBCLOUD-462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomaz Muraus updated LIBCLOUD-462:
----------------------------------
Description:
ex_allocate_public_ip and ex_release_public_ip method on the CloudStackNode
class appears to be broken.
Both of those methods call respective methods on the driver class with invalid
arguments. They pass node object to the driver method, but the driver method
doesn't take a node object.
See:
*
https://github.com/apache/libcloud/blob/trunk/libcloud/compute/drivers/cloudstack.py#L39
*
https://github.com/apache/libcloud/blob/trunk/libcloud/compute/drivers/cloudstack.py#L828
We have two options:
1. Fix those methods to actually do what the docstring says - allocate the IP
*and bind it to the node*
2. Remove those methods from the CloudStackNode class since in the current
form, they don't belong there.
We also need better test coverage to detect issues like this automatically in
the future.
was:
ex_allocate_public_ip and ex_release_public_ip method on the CloudStackNode
class appears to be broken.
Both of those methods call respective methods on the driver class with invalid
arguments. They pass node object to the driver method, but the driver method
doesn't take a node object.
See:
*
https://github.com/apache/libcloud/blob/trunk/libcloud/compute/drivers/cloudstack.py#L39
*
https://github.com/apache/libcloud/blob/trunk/libcloud/compute/drivers/cloudstack.py#L828
We have two options:
1. Fix those methods to actually do what the docstring says - allocate the IP
**and bind it to the node**
2. Remove those methods from the CloudStackNode class since in the current
form, they don't belong there.
We also need better test coverage to detect issues like this automatically in
the future.
> ex_allocate_public_ip and ex_release_public_ip method on the CloudStackNode
> class is broken
> -------------------------------------------------------------------------------------------
>
> Key: LIBCLOUD-462
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-462
> Project: Libcloud
> Issue Type: Bug
> Components: Compute
> Reporter: Tomaz Muraus
> Priority: Minor
>
> ex_allocate_public_ip and ex_release_public_ip method on the CloudStackNode
> class appears to be broken.
> Both of those methods call respective methods on the driver class with
> invalid arguments. They pass node object to the driver method, but the driver
> method doesn't take a node object.
> See:
> *
> https://github.com/apache/libcloud/blob/trunk/libcloud/compute/drivers/cloudstack.py#L39
> *
> https://github.com/apache/libcloud/blob/trunk/libcloud/compute/drivers/cloudstack.py#L828
> We have two options:
> 1. Fix those methods to actually do what the docstring says - allocate the IP
> *and bind it to the node*
> 2. Remove those methods from the CloudStackNode class since in the current
> form, they don't belong there.
> We also need better test coverage to detect issues like this automatically in
> the future.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
