[
https://issues.apache.org/jira/browse/LIBCLOUD-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899700#comment-13899700
]
Chris DeRamus commented on LIBCLOUD-518:
----------------------------------------
Sure, that's definitely true. I was trying to make the call as straight forward
as possible and to me passing the domain seemed the most logical approach. I
assume that you're talking about looking at the VpcId specifically within
instance arguments correct? If that's the case you could do it that way, but I
don't see a huge value add with the approach vs just passing in the domain. I'd
be curious to see your implementation :).
> EC2NodeDriver.ex_associate_address_with_node's domain parameter is redundante
> -----------------------------------------------------------------------------
>
> Key: LIBCLOUD-518
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-518
> Project: Libcloud
> Issue Type: Bug
> Components: Compute
> Reporter: Tom Prince
> Labels: ec2, vpc
>
> Whether an address and/or instance is in a VPC can be determined from
> attributes, so the value of the parameter must have can be determined from
> other arguments. (There can also be sanity checking, to ensure that a classic
> EIP isn't associated to a VPC instance, or vice-versa).
> ex_disassociate_address should also get this treatement.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
