Remove redundant casts.
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/ed65b408 Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/ed65b408 Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/ed65b408 Branch: refs/heads/LOG4J2-1161 Commit: ed65b408c4fab44850e8fd61191961c88149d4d5 Parents: 0b72e49 Author: Matt Sicker <boa...@gmail.com> Authored: Wed Oct 21 02:06:04 2015 -0500 Committer: Matt Sicker <boa...@gmail.com> Committed: Wed Oct 21 02:06:04 2015 -0500 ---------------------------------------------------------------------- .../log4j/core/appender/RollingRandomAccessFileAppender.java | 2 +- .../logging/log4j/core/appender/routing/RoutingAppender.java | 2 +- .../java/org/apache/logging/log4j/core/layout/PatternLayout.java | 2 +- .../java/org/apache/logging/log4j/core/layout/Rfc5424Layout.java | 2 +- .../log4j/core/pattern/ExtendedThrowablePatternConverter.java | 2 +- .../logging/log4j/core/pattern/RootThrowablePatternConverter.java | 2 +- .../log4j/core/appender/routing/JsonRoutingAppender2Test.java | 2 +- .../log4j/core/appender/routing/JsonRoutingAppenderTest.java | 2 +- .../log4j/core/async/AsyncLoggersWithAsyncAppenderTest.java | 2 +- .../log4j/core/async/AsyncLoggersWithAsyncLoggerConfigTest.java | 2 +- .../log4j/core/config/plugins/util/PluginManagerPackagesTest.java | 2 +- .../logging/log4j/perf/jmh/AsyncAppenderLogbackBenchmark.java | 2 +- 12 files changed, 12 insertions(+), 12 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/ed65b408/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/RollingRandomAccessFileAppender.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/RollingRandomAccessFileAppender.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/RollingRandomAccessFileAppender.java index 4efdaa8..cf47d46 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/RollingRandomAccessFileAppender.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/RollingRandomAccessFileAppender.java @@ -121,7 +121,7 @@ public final class RollingRandomAccessFileAppender extends AbstractOutputStreamA * @return the buffer size */ public int getBufferSize() { - return ((RollingRandomAccessFileManager) getManager()).getBufferSize(); + return getManager().getBufferSize(); } /** http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/ed65b408/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/routing/RoutingAppender.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/routing/RoutingAppender.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/routing/RoutingAppender.java index d9b2818..02be2c2 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/routing/RoutingAppender.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/routing/RoutingAppender.java @@ -151,7 +151,7 @@ public final class RoutingAppender extends AbstractAppender { final Node appNode = new Node(node); config.createConfiguration(appNode, event); if (appNode.getObject() instanceof Appender) { - final Appender app = (Appender) appNode.getObject(); + final Appender app = appNode.getObject(); app.start(); return app; } http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/ed65b408/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/PatternLayout.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/PatternLayout.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/PatternLayout.java index 6c57820..28d6329 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/PatternLayout.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/PatternLayout.java @@ -218,7 +218,7 @@ public final class PatternLayout extends AbstractStringLayout { if (parser == null) { parser = new PatternParser(config, KEY, LogEventPatternConverter.class); config.addComponent(KEY, parser); - parser = (PatternParser) config.getComponent(KEY); + parser = config.getComponent(KEY); } return parser; } http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/ed65b408/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/Rfc5424Layout.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/Rfc5424Layout.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/Rfc5424Layout.java index 2009161..64aaa6d 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/Rfc5424Layout.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/Rfc5424Layout.java @@ -234,7 +234,7 @@ public final class Rfc5424Layout extends AbstractStringLayout { if (parser == null) { parser = new PatternParser(config, PatternLayout.KEY, ThrowablePatternConverter.class); config.addComponent(COMPONENT_KEY, parser); - parser = (PatternParser) config.getComponent(COMPONENT_KEY); + parser = config.getComponent(COMPONENT_KEY); } return parser; } http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/ed65b408/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/ExtendedThrowablePatternConverter.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/ExtendedThrowablePatternConverter.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/ExtendedThrowablePatternConverter.java index 2357093..6ed8c22 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/ExtendedThrowablePatternConverter.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/ExtendedThrowablePatternConverter.java @@ -61,7 +61,7 @@ public final class ExtendedThrowablePatternConverter extends ThrowablePatternCon public void format(final LogEvent event, final StringBuilder toAppendTo) { ThrowableProxy proxy = null; if (event instanceof Log4jLogEvent) { - proxy = ((Log4jLogEvent) event).getThrownProxy(); + proxy = event.getThrownProxy(); } final Throwable throwable = event.getThrown(); if ((throwable != null || proxy != null) && options.anyLines()) { http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/ed65b408/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/RootThrowablePatternConverter.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/RootThrowablePatternConverter.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/RootThrowablePatternConverter.java index 36f845f..e3e7d33 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/RootThrowablePatternConverter.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/RootThrowablePatternConverter.java @@ -61,7 +61,7 @@ public final class RootThrowablePatternConverter extends ThrowablePatternConvert public void format(final LogEvent event, final StringBuilder toAppendTo) { ThrowableProxy proxy = null; if (event instanceof Log4jLogEvent) { - proxy = ((Log4jLogEvent) event).getThrownProxy(); + proxy = event.getThrownProxy(); } final Throwable throwable = event.getThrown(); if (throwable != null && options.anyLines()) { http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/ed65b408/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/routing/JsonRoutingAppender2Test.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/routing/JsonRoutingAppender2Test.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/routing/JsonRoutingAppender2Test.java index 03895ec..af7c078 100644 --- a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/routing/JsonRoutingAppender2Test.java +++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/routing/JsonRoutingAppender2Test.java @@ -46,7 +46,7 @@ public class JsonRoutingAppender2Test { System.setProperty(ConfigurationFactory.CONFIGURATION_FILE_PROPERTY, CONFIG); ctx = LoggerContext.getContext(false); config = ctx.getConfiguration(); - listAppender = (ListAppender) config.getAppender("List"); + listAppender = config.getAppender("List"); final File file = new File("target/rolling1/rollingtest-Unknown.log"); file.delete(); } http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/ed65b408/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/routing/JsonRoutingAppenderTest.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/routing/JsonRoutingAppenderTest.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/routing/JsonRoutingAppenderTest.java index ccb29f6..45e5412 100644 --- a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/routing/JsonRoutingAppenderTest.java +++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/routing/JsonRoutingAppenderTest.java @@ -46,7 +46,7 @@ public class JsonRoutingAppenderTest { System.setProperty(ConfigurationFactory.CONFIGURATION_FILE_PROPERTY, CONFIG); ctx = LoggerContext.getContext(false); config = ctx.getConfiguration(); - listAppender = (ListAppender) config.getAppender("List"); + listAppender = config.getAppender("List"); final File file = new File("target/rolling1/rollingtest-Unknown.log"); file.delete(); } http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/ed65b408/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggersWithAsyncAppenderTest.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggersWithAsyncAppenderTest.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggersWithAsyncAppenderTest.java index 0ae3895..ea52157 100644 --- a/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggersWithAsyncAppenderTest.java +++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggersWithAsyncAppenderTest.java @@ -44,7 +44,7 @@ public class AsyncLoggersWithAsyncAppenderTest { System.setProperty(Constants.LOG4J_CONTEXT_SELECTOR, AsyncLoggerContextSelector.class.getName()); ctx = LoggerContext.getContext(false); config = ctx.getConfiguration(); - listAppender = (ListAppender) config.getAppender("List"); + listAppender = config.getAppender("List"); } @AfterClass http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/ed65b408/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggersWithAsyncLoggerConfigTest.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggersWithAsyncLoggerConfigTest.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggersWithAsyncLoggerConfigTest.java index 816e393..5bd60d1 100644 --- a/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggersWithAsyncLoggerConfigTest.java +++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/async/AsyncLoggersWithAsyncLoggerConfigTest.java @@ -44,7 +44,7 @@ public class AsyncLoggersWithAsyncLoggerConfigTest { System.setProperty(Constants.LOG4J_CONTEXT_SELECTOR, AsyncLoggerContextSelector.class.getName()); ctx = LoggerContext.getContext(false); config = ctx.getConfiguration(); - listAppender = (ListAppender) config.getAppender("List"); + listAppender = config.getAppender("List"); } @AfterClass http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/ed65b408/log4j-core/src/test/java/org/apache/logging/log4j/core/config/plugins/util/PluginManagerPackagesTest.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/config/plugins/util/PluginManagerPackagesTest.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/config/plugins/util/PluginManagerPackagesTest.java index e1ccf74..2ebefe0 100644 --- a/log4j-core/src/test/java/org/apache/logging/log4j/core/config/plugins/util/PluginManagerPackagesTest.java +++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/config/plugins/util/PluginManagerPackagesTest.java @@ -79,7 +79,7 @@ public class PluginManagerPackagesTest { // with the packages element pointing to our custom plugin ctx = Configurator.initialize("Test1", "customplugin/log4j2-741.xml"); config = ctx.getConfiguration(); - listAppender = (ListAppender) config.getAppender("List"); + listAppender = config.getAppender("List"); final Logger logger = LogManager.getLogger(PluginManagerPackagesTest.class); logger.info("this message is ignored"); http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/ed65b408/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/AsyncAppenderLogbackBenchmark.java ---------------------------------------------------------------------- diff --git a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/AsyncAppenderLogbackBenchmark.java b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/AsyncAppenderLogbackBenchmark.java index ea4f2df..5c8c5cc 100644 --- a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/AsyncAppenderLogbackBenchmark.java +++ b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/AsyncAppenderLogbackBenchmark.java @@ -63,7 +63,7 @@ public class AsyncAppenderLogbackBenchmark { @Setup(Level.Trial) public void up() { System.setProperty("logback.configurationFile", "perf-logback-async.xml"); - logger = (Logger) LoggerFactory.getLogger(getClass()); + logger = LoggerFactory.getLogger(getClass()); } @TearDown(Level.Trial)
