Repository: logging-log4j2 Updated Branches: refs/heads/master 0ee59bc0e -> a4aa2b96f
Remove unused method. Reuse Strings.isEmpty(). Don't use unnecessary else clause. Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/a4aa2b96 Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/a4aa2b96 Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/a4aa2b96 Branch: refs/heads/master Commit: a4aa2b96f2340d16f1d2685993ee2409e3d6c80c Parents: 0ee59bc Author: ggregory <[email protected]> Authored: Thu Feb 11 21:22:25 2016 -0800 Committer: ggregory <[email protected]> Committed: Thu Feb 11 21:22:25 2016 -0800 ---------------------------------------------------------------------- .../java/org/apache/logging/log4j/spi/AbstractLogger.java | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/a4aa2b96/log4j-api/src/main/java/org/apache/logging/log4j/spi/AbstractLogger.java ---------------------------------------------------------------------- diff --git a/log4j-api/src/main/java/org/apache/logging/log4j/spi/AbstractLogger.java b/log4j-api/src/main/java/org/apache/logging/log4j/spi/AbstractLogger.java index 214644a..0de514b 100644 --- a/log4j-api/src/main/java/org/apache/logging/log4j/spi/AbstractLogger.java +++ b/log4j-api/src/main/java/org/apache/logging/log4j/spi/AbstractLogger.java @@ -29,6 +29,7 @@ import org.apache.logging.log4j.message.StringFormattedMessage; import org.apache.logging.log4j.status.StatusLogger; import org.apache.logging.log4j.util.LambdaUtil; import org.apache.logging.log4j.util.MessageSupplier; +import org.apache.logging.log4j.util.Strings; import org.apache.logging.log4j.util.Supplier; /** @@ -359,17 +360,12 @@ public abstract class AbstractLogger implements ExtendedLogger, Serializable { } } - protected Message entryMsg(final int count, final Object... params) { - return entryMsg(null, count, params); - } - protected Message entryMsg(final String format, final int count, final Object... params) { if (count == 0) { - if (format == null || format.length() == 0) { + if (Strings.isEmpty(format)) { return messageFactory.newMessage("entry"); - } else { - return messageFactory.newMessage("entry: " + format); } + return messageFactory.newMessage("entry: " + format); } final StringBuilder sb = new StringBuilder("entry"); if (format != null) {
