Alawys use a block. Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/2060b729 Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/2060b729 Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/2060b729
Branch: refs/heads/feature/LOG4J2-1430 Commit: 2060b729b7e95b4f1d09d632b45687383ba5e0fc Parents: ba07f0d Author: ggregory <ggreg...@apache.org> Authored: Fri Jun 17 10:28:47 2016 -0700 Committer: ggregory <ggreg...@apache.org> Committed: Fri Jun 17 10:28:47 2016 -0700 ---------------------------------------------------------------------- .../log4j/core/filter/AbstractFilterableTest.java | 12 +++++++++--- .../AbstractStringLayoutStringEncodingBenchmark.java | 4 +++- 2 files changed, 12 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/2060b729/log4j-core/src/test/java/org/apache/logging/log4j/core/filter/AbstractFilterableTest.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/filter/AbstractFilterableTest.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/filter/AbstractFilterableTest.java index 86cce8d..4e0830d 100644 --- a/log4j-core/src/test/java/org/apache/logging/log4j/core/filter/AbstractFilterableTest.java +++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/filter/AbstractFilterableTest.java @@ -263,12 +263,18 @@ public class AbstractFilterableTest { @Override public boolean equals(final Object o) { - if (this == o) return true; - if (!(o instanceof EqualFilter)) return false; + if (this == o) { + return true; + } + if (!(o instanceof EqualFilter)) { + return false; + } final EqualFilter that = (EqualFilter) o; - if (key != null ? !key.equals(that.key) : that.key != null) return false; + if (key != null ? !key.equals(that.key) : that.key != null) { + return false; + } return true; } http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/2060b729/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/AbstractStringLayoutStringEncodingBenchmark.java ---------------------------------------------------------------------- diff --git a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/AbstractStringLayoutStringEncodingBenchmark.java b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/AbstractStringLayoutStringEncodingBenchmark.java index 540c264..db01a17 100644 --- a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/AbstractStringLayoutStringEncodingBenchmark.java +++ b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/AbstractStringLayoutStringEncodingBenchmark.java @@ -188,7 +188,9 @@ public class AbstractStringLayoutStringEncodingBenchmark { private static long consume(final byte[] bytes) { long checksum = 0; - for (final byte b : bytes) checksum += b; + for (final byte b : bytes) { + checksum += b; + } return checksum; }