Repository: logging-log4j2 Updated Branches: refs/heads/LOG4J2-1553 13c3c2479 -> 5812bb56f
Use try-with-resources. Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/11930be7 Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/11930be7 Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/11930be7 Branch: refs/heads/LOG4J2-1553 Commit: 11930be7de1836227128254769ea93cba9fea75e Parents: f936a6d Author: Gary Gregory <ggreg...@apache.org> Authored: Sun Aug 28 13:31:13 2016 -0700 Committer: Gary Gregory <ggreg...@apache.org> Committed: Sun Aug 28 13:31:13 2016 -0700 ---------------------------------------------------------------------- .../db/jpa/JpaHyperSqlAppenderTest.java | 28 +++++++++----------- 1 file changed, 13 insertions(+), 15 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/11930be7/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/db/jpa/JpaHyperSqlAppenderTest.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/db/jpa/JpaHyperSqlAppenderTest.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/db/jpa/JpaHyperSqlAppenderTest.java index a5379c3..4748b59 100644 --- a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/db/jpa/JpaHyperSqlAppenderTest.java +++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/db/jpa/JpaHyperSqlAppenderTest.java @@ -39,21 +39,19 @@ public class JpaHyperSqlAppenderTest extends AbstractJpaAppenderTest { protected Connection setUpConnection() throws SQLException { final Connection connection = DriverManager.getConnection("jdbc:hsqldb:mem:Log4j", USER_ID, PASSWORD); - Statement statement = connection.createStatement(); - statement.executeUpdate("CREATE TABLE jpaBaseLogEntry ( " + - "id INTEGER IDENTITY, eventDate DATETIME, level VARCHAR(10), logger VARCHAR(255), " + - "message VARCHAR(1024), exception VARCHAR(1048576)" + - " )"); - statement.close(); - - statement = connection.createStatement(); - statement.executeUpdate("CREATE TABLE jpaBasicLogEntry ( " + - "id INTEGER IDENTITY, timemillis BIGINT, nanoTime BIGINT, level VARCHAR(10), loggerName VARCHAR(255), " + - "message VARCHAR(1024), thrown VARCHAR(1048576), contextMapJson VARCHAR(1048576)," + - "loggerFQCN VARCHAR(1024), contextStack VARCHAR(1048576), marker VARCHAR(255), source VARCHAR(2048)," + - "threadId BIGINT, threadName NVARCHAR(255), threadPriority INTEGER" + - " )"); - statement.close(); + try (Statement statement = connection.createStatement()) { + statement.executeUpdate("CREATE TABLE jpaBaseLogEntry ( " + + "id INTEGER IDENTITY, eventDate DATETIME, level VARCHAR(10), logger VARCHAR(255), " + + "message VARCHAR(1024), exception VARCHAR(1048576)" + " )"); + } + + try (Statement statement = connection.createStatement()) { + statement.executeUpdate("CREATE TABLE jpaBasicLogEntry ( " + + "id INTEGER IDENTITY, timemillis BIGINT, nanoTime BIGINT, level VARCHAR(10), loggerName VARCHAR(255), " + + "message VARCHAR(1024), thrown VARCHAR(1048576), contextMapJson VARCHAR(1048576)," + + "loggerFQCN VARCHAR(1024), contextStack VARCHAR(1048576), marker VARCHAR(255), source VARCHAR(2048)," + + "threadId BIGINT, threadName NVARCHAR(255), threadPriority INTEGER" + " )"); + } return connection; }
