Repository: logging-log4j2 Updated Branches: refs/heads/master b96c6c424 -> eef7c3a11
[LOG4J2-2457] RollingRandomAccessFileManager ignores new file patterns from programmatic reconfiguration. Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/eef7c3a1 Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/eef7c3a1 Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/eef7c3a1 Branch: refs/heads/master Commit: eef7c3a11cf8b35a619b900f6beedf8f7ad06804 Parents: b96c6c4 Author: Gary Gregory <[email protected]> Authored: Fri Oct 19 23:46:26 2018 -0600 Committer: Gary Gregory <[email protected]> Committed: Fri Oct 19 23:46:26 2018 -0600 ---------------------------------------------------------------------- .../rolling/RollingRandomAccessFileManager.java | 12 ++++++++---- src/changes/changes.xml | 6 ++++++ 2 files changed, 14 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/eef7c3a1/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/RollingRandomAccessFileManager.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/RollingRandomAccessFileManager.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/RollingRandomAccessFileManager.java index 8d3e52e..48a475a 100644 --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/RollingRandomAccessFileManager.java +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/RollingRandomAccessFileManager.java @@ -304,15 +304,18 @@ public class RollingRandomAccessFileManager extends RollingFileManager { this.fileGroup = fileGroup; } - public TriggeringPolicy getTriggeringPolicy() - { + public String getPattern() { + return pattern; + } + + public TriggeringPolicy getTriggeringPolicy() { return this.policy; } - public RolloverStrategy getRolloverStrategy() - { + public RolloverStrategy getRolloverStrategy() { return this.strategy; } + } @Override @@ -320,5 +323,6 @@ public class RollingRandomAccessFileManager extends RollingFileManager { final FactoryData factoryData = (FactoryData) data; setRolloverStrategy(factoryData.getRolloverStrategy()); setTriggeringPolicy(factoryData.getTriggeringPolicy()); + setPatternProcessor(new PatternProcessor(factoryData.getPattern(), getPatternProcessor())); } } http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/eef7c3a1/src/changes/changes.xml ---------------------------------------------------------------------- diff --git a/src/changes/changes.xml b/src/changes/changes.xml index 1efffe6..cac4f1d 100644 --- a/src/changes/changes.xml +++ b/src/changes/changes.xml @@ -287,6 +287,9 @@ <action issue="LOG4J2-2481" dev="ggregory" type="fix"> Avoid NullPointerExceptions in org.apache.logging.log4j.core.config.AbstractConfiguration for null arguments. </action> + <action issue="LOG4J2-2457" dev="ggregory" type="fix" due-to="Heiko Schwanke, Gary Gregory"> + RollingRandomAccessFileManager ignores new file patterns from programmatic reconfiguration. + </action> </release> <release version="2.11.2" date="2018-MM-DD" description="GA Release 2.11.2"> <action issue="LOG4J2-2391" dev="ckozak" type="update"> @@ -355,6 +358,9 @@ <action issue="LOG4J2-2481" dev="ggregory" type="fix"> Avoid NullPointerExceptions in org.apache.logging.log4j.core.config.AbstractConfiguration for null arguments. </action> + <action issue="LOG4J2-2457" dev="ggregory" type="fix" due-to="Heiko Schwanke, Gary Gregory"> + RollingRandomAccessFileManager ignores new file patterns from programmatic reconfiguration. + </action> </release> <release version="2.11.1" date="2018-07-22" description="GA Release 2.11.1"> <action issue="LOG4J2-2389" dev="rgoers" type="fix" due-to="Liu Wen">
