Repository: logging-log4j2
Updated Branches:
  refs/heads/release-2.x 1f4c79624 -> 4a4b60abb


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/de97a11d/log4j-core/src/test/java/org/apache/logging/log4j/core/pattern/MessagePatternConverterTest.java
----------------------------------------------------------------------
diff --git 
a/log4j-core/src/test/java/org/apache/logging/log4j/core/pattern/MessagePatternConverterTest.java
 
b/log4j-core/src/test/java/org/apache/logging/log4j/core/pattern/MessagePatternConverterTest.java
index cd85071..577d26a 100644
--- 
a/log4j-core/src/test/java/org/apache/logging/log4j/core/pattern/MessagePatternConverterTest.java
+++ 
b/log4j-core/src/test/java/org/apache/logging/log4j/core/pattern/MessagePatternConverterTest.java
@@ -149,13 +149,13 @@ public class MessagePatternConverterTest {
     @Test
     public void testMapMessageFormatJson() throws Exception {
         final MessagePatternConverter converter = 
MessagePatternConverter.newInstance(null, new String[]{"json"});
-        Message msg = new StringMapMessage()
+        final Message msg = new StringMapMessage()
                 .with("key", "val");
-        LogEvent event = Log4jLogEvent.newBuilder() //
+        final LogEvent event = Log4jLogEvent.newBuilder() //
                 .setLoggerName("MyLogger") //
                 .setLevel(Level.DEBUG) //
                 .setMessage(msg).build();
-        StringBuilder sb = new StringBuilder();
+        final StringBuilder sb = new StringBuilder();
         converter.format(event, sb);
         assertEquals("Unexpected result", "{\"key\":\"val\"}", sb.toString());
     }
@@ -163,13 +163,13 @@ public class MessagePatternConverterTest {
     @Test
     public void testMapMessageFormatXml() throws Exception {
         final MessagePatternConverter converter = 
MessagePatternConverter.newInstance(null, new String[]{"xml"});
-        Message msg = new StringMapMessage()
+        final Message msg = new StringMapMessage()
                 .with("key", "val");
-        LogEvent event = Log4jLogEvent.newBuilder() //
+        final LogEvent event = Log4jLogEvent.newBuilder() //
                 .setLoggerName("MyLogger") //
                 .setLevel(Level.DEBUG) //
                 .setMessage(msg).build();
-        StringBuilder sb = new StringBuilder();
+        final StringBuilder sb = new StringBuilder();
         converter.format(event, sb);
         assertEquals("Unexpected result", "<Map>\n  <Entry 
key=\"key\">val</Entry>\n</Map>", sb.toString());
     }
@@ -177,13 +177,13 @@ public class MessagePatternConverterTest {
     @Test
     public void testMapMessageFormatDefault() throws Exception {
         final MessagePatternConverter converter = 
MessagePatternConverter.newInstance(null, null);
-        Message msg = new StringMapMessage()
+        final Message msg = new StringMapMessage()
                 .with("key", "val");
-        LogEvent event = Log4jLogEvent.newBuilder() //
+        final LogEvent event = Log4jLogEvent.newBuilder() //
                 .setLoggerName("MyLogger") //
                 .setLevel(Level.DEBUG) //
                 .setMessage(msg).build();
-        StringBuilder sb = new StringBuilder();
+        final StringBuilder sb = new StringBuilder();
         converter.format(event, sb);
         assertEquals("Unexpected result", "key=\"val\"", sb.toString());
     }
@@ -191,13 +191,13 @@ public class MessagePatternConverterTest {
     @Test
     public void testStructuredDataFormatFull() throws Exception {
         final MessagePatternConverter converter = 
MessagePatternConverter.newInstance(null, new String[]{"FULL"});
-        Message msg = new StructuredDataMessage("id", "message", "type")
+        final Message msg = new StructuredDataMessage("id", "message", "type")
                 .with("key", "val");
-        LogEvent event = Log4jLogEvent.newBuilder() //
+        final LogEvent event = Log4jLogEvent.newBuilder() //
                 .setLoggerName("MyLogger") //
                 .setLevel(Level.DEBUG) //
                 .setMessage(msg).build();
-        StringBuilder sb = new StringBuilder();
+        final StringBuilder sb = new StringBuilder();
         converter.format(event, sb);
         assertEquals("Unexpected result", "type [id key=\"val\"] message", 
sb.toString());
     }

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/de97a11d/log4j-core/src/test/java/org/apache/logging/log4j/core/time/MutableInstantTest.java
----------------------------------------------------------------------
diff --git 
a/log4j-core/src/test/java/org/apache/logging/log4j/core/time/MutableInstantTest.java
 
b/log4j-core/src/test/java/org/apache/logging/log4j/core/time/MutableInstantTest.java
index 63d3138..6bebbd1 100644
--- 
a/log4j-core/src/test/java/org/apache/logging/log4j/core/time/MutableInstantTest.java
+++ 
b/log4j-core/src/test/java/org/apache/logging/log4j/core/time/MutableInstantTest.java
@@ -26,7 +26,7 @@ public class MutableInstantTest {
 
     @Test
     public void testGetEpochSecond() {
-        MutableInstant instant = new MutableInstant();
+        final MutableInstant instant = new MutableInstant();
         assertEquals("initial", 0, instant.getEpochSecond());
 
         instant.initFromEpochSecond(123, 456);
@@ -35,7 +35,7 @@ public class MutableInstantTest {
         instant.initFromEpochMilli(123456, 789012);
         assertEquals("returns converted value when initialized from milllis", 
123, instant.getEpochSecond());
 
-        MutableInstant other = new MutableInstant();
+        final MutableInstant other = new MutableInstant();
         other.initFromEpochSecond(788, 456);
         instant.initFrom(other);
 
@@ -44,7 +44,7 @@ public class MutableInstantTest {
 
     @Test
     public void testGetNanoOfSecond() {
-        MutableInstant instant = new MutableInstant();
+        final MutableInstant instant = new MutableInstant();
         assertEquals("initial", 0, instant.getNanoOfSecond());
 
         instant.initFromEpochSecond(123, 456);
@@ -53,7 +53,7 @@ public class MutableInstantTest {
         instant.initFromEpochMilli(123456, 789012);
         assertEquals("returns converted value when initialized from milllis", 
456789012, instant.getNanoOfSecond());
 
-        MutableInstant other = new MutableInstant();
+        final MutableInstant other = new MutableInstant();
         other.initFromEpochSecond(788, 456);
         instant.initFrom(other);
 
@@ -62,7 +62,7 @@ public class MutableInstantTest {
 
     @Test
     public void testGetEpochMillisecond() {
-        MutableInstant instant = new MutableInstant();
+        final MutableInstant instant = new MutableInstant();
         assertEquals("initial", 0, instant.getEpochMillisecond());
 
         instant.initFromEpochMilli(123, 456);
@@ -71,7 +71,7 @@ public class MutableInstantTest {
         instant.initFromEpochSecond(123, 456789012);
         assertEquals("returns converted value when initialized from seconds", 
123456, instant.getEpochMillisecond());
 
-        MutableInstant other = new MutableInstant();
+        final MutableInstant other = new MutableInstant();
         other.initFromEpochMilli(788, 456);
         instant.initFrom(other);
 
@@ -80,7 +80,7 @@ public class MutableInstantTest {
 
     @Test
     public void getGetNanoOfMillisecond() {
-        MutableInstant instant = new MutableInstant();
+        final MutableInstant instant = new MutableInstant();
         assertEquals("initial", 0, instant.getNanoOfMillisecond());
 
         instant.initFromEpochMilli(123, 456);
@@ -89,7 +89,7 @@ public class MutableInstantTest {
         instant.initFromEpochSecond(123, 456789012);
         assertEquals("returns converted value when initialized from milllis", 
789012, instant.getNanoOfMillisecond());
 
-        MutableInstant other = new MutableInstant();
+        final MutableInstant other = new MutableInstant();
         other.initFromEpochMilli(788, 456);
         instant.initFrom(other);
 
@@ -103,12 +103,12 @@ public class MutableInstantTest {
 
     @Test
     public void testInitFromInstantCopiesValues() {
-        MutableInstant other = new MutableInstant();
+        final MutableInstant other = new MutableInstant();
         other.initFromEpochSecond(788, 456);
         assertEquals("epochSec", 788, other.getEpochSecond());
         assertEquals("NanosOfSec", 456, other.getNanoOfSecond());
 
-        MutableInstant instant = new MutableInstant();
+        final MutableInstant instant = new MutableInstant();
         instant.initFrom(other);
 
         assertEquals("epochSec", 788, instant.getEpochSecond());
@@ -117,7 +117,7 @@ public class MutableInstantTest {
 
     @Test
     public void testInitFromEpochMillis() {
-        MutableInstant instant = new MutableInstant();
+        final MutableInstant instant = new MutableInstant();
         instant.initFromEpochMilli(123456, 789012);
         assertEquals("epochSec", 123, instant.getEpochSecond());
         assertEquals("NanoOfSec", 456789012, instant.getNanoOfSecond());
@@ -127,26 +127,26 @@ public class MutableInstantTest {
 
     @Test(expected = IllegalArgumentException.class)
     public void testInitFromEpochMillisRejectsNegativeNanoOfMilli() {
-        MutableInstant instant = new MutableInstant();
+        final MutableInstant instant = new MutableInstant();
         instant.initFromEpochMilli(123456, -1);
     }
 
     @Test(expected = IllegalArgumentException.class)
     public void testInitFromEpochMillisRejectsTooLargeNanoOfMilli() {
-        MutableInstant instant = new MutableInstant();
+        final MutableInstant instant = new MutableInstant();
         instant.initFromEpochMilli(123456, 1000_000);
     }
 
     @Test
     public void testInitFromEpochMillisAcceptsTooMaxNanoOfMilli() {
-        MutableInstant instant = new MutableInstant();
+        final MutableInstant instant = new MutableInstant();
         instant.initFromEpochMilli(123456, 999_999);
         assertEquals("NanoOfMilli", 999_999, instant.getNanoOfMillisecond());
     }
 
     @Test
     public void testInitFromEpochSecond() {
-        MutableInstant instant = new MutableInstant();
+        final MutableInstant instant = new MutableInstant();
         instant.initFromEpochSecond(123, 456789012);
         assertEquals("epochSec", 123, instant.getEpochSecond());
         assertEquals("NanoOfSec", 456789012, instant.getNanoOfSecond());
@@ -156,26 +156,26 @@ public class MutableInstantTest {
 
     @Test(expected = IllegalArgumentException.class)
     public void testInitFromEpochSecondRejectsNegativeNanoOfMilli() {
-        MutableInstant instant = new MutableInstant();
+        final MutableInstant instant = new MutableInstant();
         instant.initFromEpochSecond(123456, -1);
     }
 
     @Test(expected = IllegalArgumentException.class)
     public void testInitFromEpochSecondRejectsTooLargeNanoOfMilli() {
-        MutableInstant instant = new MutableInstant();
+        final MutableInstant instant = new MutableInstant();
         instant.initFromEpochSecond(123456, 1000_000_000);
     }
 
     @Test
     public void testInitFromEpochSecondAcceptsTooMaxNanoOfMilli() {
-        MutableInstant instant = new MutableInstant();
+        final MutableInstant instant = new MutableInstant();
         instant.initFromEpochSecond(123456, 999_999_999);
         assertEquals("NanoOfSec", 999_999_999, instant.getNanoOfSecond());
     }
 
     @Test
     public void testInstantToMillisAndNanos() {
-        long[] values = new long[2];
+        final long[] values = new long[2];
         MutableInstant.instantToMillisAndNanos(123456, 999_999_999, values);
         assertEquals(123456_999, values[0]);
         assertEquals(999_999, values[1]);
@@ -183,9 +183,9 @@ public class MutableInstantTest {
 
     @Test
     public void testInitFromClock() {
-        MutableInstant instant = new MutableInstant();
+        final MutableInstant instant = new MutableInstant();
 
-        PreciseClock clock = new FixedPreciseClock(123456, 789012);
+        final PreciseClock clock = new FixedPreciseClock(123456, 789012);
         instant.initFrom(clock);
 
         assertEquals(123456, instant.getEpochMillisecond());
@@ -196,10 +196,10 @@ public class MutableInstantTest {
 
     @Test
     public void testEquals() {
-        MutableInstant instant = new MutableInstant();
+        final MutableInstant instant = new MutableInstant();
         instant.initFromEpochSecond(123, 456789012);
 
-        MutableInstant instant2 = new MutableInstant();
+        final MutableInstant instant2 = new MutableInstant();
         instant2.initFromEpochMilli(123456, 789012);
 
         assertEquals(instant, instant2);
@@ -207,10 +207,10 @@ public class MutableInstantTest {
 
     @Test
     public void testHashCode() {
-        MutableInstant instant = new MutableInstant();
+        final MutableInstant instant = new MutableInstant();
         instant.initFromEpochSecond(123, 456789012);
 
-        MutableInstant instant2 = new MutableInstant();
+        final MutableInstant instant2 = new MutableInstant();
         instant2.initFromEpochMilli(123456, 789012);
 
         assertEquals(instant.hashCode(), instant2.hashCode());
@@ -222,7 +222,7 @@ public class MutableInstantTest {
 
     @Test
     public void testToString() {
-        MutableInstant instant = new MutableInstant();
+        final MutableInstant instant = new MutableInstant();
         instant.initFromEpochSecond(123, 456789012);
         assertEquals("MutableInstant[epochSecond=123, nano=456789012]", 
instant.toString());
 

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/de97a11d/log4j-core/src/test/java/org/apache/logging/log4j/message/MutableLogEventWithReusableParamMsgTest.java
----------------------------------------------------------------------
diff --git 
a/log4j-core/src/test/java/org/apache/logging/log4j/message/MutableLogEventWithReusableParamMsgTest.java
 
b/log4j-core/src/test/java/org/apache/logging/log4j/message/MutableLogEventWithReusableParamMsgTest.java
index 1371ed2..2d3688d 100644
--- 
a/log4j-core/src/test/java/org/apache/logging/log4j/message/MutableLogEventWithReusableParamMsgTest.java
+++ 
b/log4j-core/src/test/java/org/apache/logging/log4j/message/MutableLogEventWithReusableParamMsgTest.java
@@ -53,8 +53,8 @@ public class MutableLogEventWithReusableParamMsgTest {
         evt.setMessage(msg);
         evt.clear();
 
-        Message mementoMessage = evt.memento();
-        Message mementoMessageSecondInvocation = evt.memento();
+        final Message mementoMessage = evt.memento();
+        final Message mementoMessageSecondInvocation = evt.memento();
         // MutableLogEvent.memento should be cached
         assertThat(mementoMessage, 
sameInstance(mementoMessageSecondInvocation));
     }

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/de97a11d/log4j-flume-ng/src/main/java/org/apache/logging/log4j/flume/appender/FlumeAppender.java
----------------------------------------------------------------------
diff --git 
a/log4j-flume-ng/src/main/java/org/apache/logging/log4j/flume/appender/FlumeAppender.java
 
b/log4j-flume-ng/src/main/java/org/apache/logging/log4j/flume/appender/FlumeAppender.java
index d4c5219..79afa21 100644
--- 
a/log4j-flume-ng/src/main/java/org/apache/logging/log4j/flume/appender/FlumeAppender.java
+++ 
b/log4j-flume-ng/src/main/java/org/apache/logging/log4j/flume/appender/FlumeAppender.java
@@ -75,7 +75,7 @@ public final class FlumeAppender extends AbstractAppender 
implements FlumeEventF
     private FlumeAppender(final String name, final Filter filter, final 
Layout<? extends Serializable> layout,
             final boolean ignoreExceptions, final String includes, final 
String excludes, final String required,
             final String mdcPrefix, final String eventPrefix, final boolean 
compress, final FlumeEventFactory factory,
-            final AbstractFlumeManager manager, Property[] properties) {
+            final AbstractFlumeManager manager, final Property[] properties) {
         super(name, filter, layout, ignoreExceptions, properties);
         this.manager = manager;
         this.mdcIncludes = includes;

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/de97a11d/log4j-jdbc-dbcp2/src/main/java/org/apache/logging/log4j/core/appender/db/jdbc/PoolingDriverConnectionSource.java
----------------------------------------------------------------------
diff --git 
a/log4j-jdbc-dbcp2/src/main/java/org/apache/logging/log4j/core/appender/db/jdbc/PoolingDriverConnectionSource.java
 
b/log4j-jdbc-dbcp2/src/main/java/org/apache/logging/log4j/core/appender/db/jdbc/PoolingDriverConnectionSource.java
index f1ede24..3fbb0da 100644
--- 
a/log4j-jdbc-dbcp2/src/main/java/org/apache/logging/log4j/core/appender/db/jdbc/PoolingDriverConnectionSource.java
+++ 
b/log4j-jdbc-dbcp2/src/main/java/org/apache/logging/log4j/core/appender/db/jdbc/PoolingDriverConnectionSource.java
@@ -168,7 +168,7 @@ public final class PoolingDriverConnectionSource extends 
AbstractDriverManagerCo
     }
 
     @Override
-    public boolean stop(long timeout, TimeUnit timeUnit) {
+    public boolean stop(final long timeout, final TimeUnit timeUnit) {
         try {
             final PoolingDriver driver = getPoolingDriver();
             if (driver != null) {
@@ -176,7 +176,7 @@ public final class PoolingDriverConnectionSource extends 
AbstractDriverManagerCo
                 driver.closePool(poolName);
             }
             return true;
-        } catch (Exception e) {
+        } catch (final Exception e) {
             getLogger().error("Exception stopping connection source for '{}' 
→ '{}'", getConnectionString(),
                     getActualConnectionString(), e);
             return false;

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/de97a11d/log4j-jpa/src/main/java/org/apache/logging/log4j/core/appender/db/jpa/converter/InstantAttributeConverter.java
----------------------------------------------------------------------
diff --git 
a/log4j-jpa/src/main/java/org/apache/logging/log4j/core/appender/db/jpa/converter/InstantAttributeConverter.java
 
b/log4j-jpa/src/main/java/org/apache/logging/log4j/core/appender/db/jpa/converter/InstantAttributeConverter.java
index 9e0120e..fde75af 100644
--- 
a/log4j-jpa/src/main/java/org/apache/logging/log4j/core/appender/db/jpa/converter/InstantAttributeConverter.java
+++ 
b/log4j-jpa/src/main/java/org/apache/logging/log4j/core/appender/db/jpa/converter/InstantAttributeConverter.java
@@ -46,11 +46,11 @@ public class InstantAttributeConverter implements 
AttributeConverter<Instant, St
             return null;
         }
 
-        int pos = s.indexOf(",");
-        long epochSecond = Long.parseLong(s.substring(0, pos));
-        int nanos = Integer.parseInt(s.substring(pos + 1, s.length()));
+        final int pos = s.indexOf(",");
+        final long epochSecond = Long.parseLong(s.substring(0, pos));
+        final int nanos = Integer.parseInt(s.substring(pos + 1, s.length()));
 
-        MutableInstant result = new MutableInstant();
+        final MutableInstant result = new MutableInstant();
         result.initFromEpochSecond(epochSecond, nanos);
         return result;
     }

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/de97a11d/log4j-jpa/src/test/java/org/apache/logging/log4j/core/appender/db/jpa/AbstractJpaAppenderTest.java
----------------------------------------------------------------------
diff --git 
a/log4j-jpa/src/test/java/org/apache/logging/log4j/core/appender/db/jpa/AbstractJpaAppenderTest.java
 
b/log4j-jpa/src/test/java/org/apache/logging/log4j/core/appender/db/jpa/AbstractJpaAppenderTest.java
index 6ff3c14..6d90b3c 100644
--- 
a/log4j-jpa/src/test/java/org/apache/logging/log4j/core/appender/db/jpa/AbstractJpaAppenderTest.java
+++ 
b/log4j-jpa/src/test/java/org/apache/logging/log4j/core/appender/db/jpa/AbstractJpaAppenderTest.java
@@ -64,7 +64,7 @@ public abstract class AbstractJpaAppenderTest {
     public void tearDown() throws SQLException {
         final LoggerContext context = LoggerContext.getContext(false);
         try {
-            String appenderName = "databaseAppender";
+            final String appenderName = "databaseAppender";
             final Appender appender = 
context.getConfiguration().getAppender(appenderName);
             assertNotNull("The appender '" + appenderName + "' should not be 
null.", appender);
             assertTrue("The appender should be a JpaAppender.", appender 
instanceof JpaAppender);

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/de97a11d/log4j-mongodb2/src/test/java/org/apache/logging/log4j/mongodb2/MongoDbTestRule.java
----------------------------------------------------------------------
diff --git 
a/log4j-mongodb2/src/test/java/org/apache/logging/log4j/mongodb2/MongoDbTestRule.java
 
b/log4j-mongodb2/src/test/java/org/apache/logging/log4j/mongodb2/MongoDbTestRule.java
index 465fa3f..595c361 100644
--- 
a/log4j-mongodb2/src/test/java/org/apache/logging/log4j/mongodb2/MongoDbTestRule.java
+++ 
b/log4j-mongodb2/src/test/java/org/apache/logging/log4j/mongodb2/MongoDbTestRule.java
@@ -164,7 +164,7 @@ public class MongoDbTestRule implements TestRule {
 
     @Override
     public String toString() {
-        StringBuilder builder = new StringBuilder();
+        final StringBuilder builder = new StringBuilder();
         builder.append("MongoDbTestRule [starter=");
         builder.append(starter);
         builder.append(", portSystemPropertyName=");

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/de97a11d/log4j-mongodb3/src/test/java/org/apache/logging/log4j/mongodb3/MongoDbTestRule.java
----------------------------------------------------------------------
diff --git 
a/log4j-mongodb3/src/test/java/org/apache/logging/log4j/mongodb3/MongoDbTestRule.java
 
b/log4j-mongodb3/src/test/java/org/apache/logging/log4j/mongodb3/MongoDbTestRule.java
index 96a903b..2f3ea1a 100644
--- 
a/log4j-mongodb3/src/test/java/org/apache/logging/log4j/mongodb3/MongoDbTestRule.java
+++ 
b/log4j-mongodb3/src/test/java/org/apache/logging/log4j/mongodb3/MongoDbTestRule.java
@@ -172,7 +172,7 @@ public class MongoDbTestRule implements TestRule {
 
     @Override
     public String toString() {
-        StringBuilder builder = new StringBuilder();
+        final StringBuilder builder = new StringBuilder();
         builder.append("MongoDbTestRule [starter=");
         builder.append(starter);
         builder.append(", portSystemPropertyName=");

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/de97a11d/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/FileAppenderThrowableBenchmark.java
----------------------------------------------------------------------
diff --git 
a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/FileAppenderThrowableBenchmark.java
 
b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/FileAppenderThrowableBenchmark.java
index 7bf5ba9..b9b8a7f 100644
--- 
a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/FileAppenderThrowableBenchmark.java
+++ 
b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/FileAppenderThrowableBenchmark.java
@@ -116,21 +116,21 @@ public class FileAppenderThrowableBenchmark {
                         new 
Class<?>[]{Class.forName(FileAppenderThrowableBenchmark.class.getName() + 
"$TestIface" + (i % 31))},
                         new InvocationHandler() {
                             @Override
-                            public Object invoke(Object proxy, Method method, 
Object[] args) throws Throwable {
+                            public Object invoke(final Object proxy, final 
Method method, final Object[] args) throws Throwable {
                                 try {
                                     return method.invoke(delegate, args);
-                                } catch (InvocationTargetException e) {
+                                } catch (final InvocationTargetException e) {
                                     throw e.getCause();
                                 }
                             }
                         });
             }
-        } catch (ClassNotFoundException e) {
+        } catch (final ClassNotFoundException e) {
             throw new IllegalStateException("Failed to create stack", e);
         }
         try {
             helper.action();
-        } catch (IllegalStateException e) {
+        } catch (final IllegalStateException e) {
             return e;
         }
         throw new IllegalStateException("Failed to create throwable");

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/de97a11d/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/StringBuilderEscapeBenchmark.java
----------------------------------------------------------------------
diff --git 
a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/StringBuilderEscapeBenchmark.java
 
b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/StringBuilderEscapeBenchmark.java
index 865f925..774a5a5 100644
--- 
a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/StringBuilderEscapeBenchmark.java
+++ 
b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/StringBuilderEscapeBenchmark.java
@@ -68,8 +68,8 @@ public class StringBuilderEscapeBenchmark {
         return state.buffer.length();
     }
 
-    private static String repeat(String str, int times) {
-        StringBuilder sb = new StringBuilder(str.length() * times);
+    private static String repeat(final String str, final int times) {
+        final StringBuilder sb = new StringBuilder(str.length() * times);
         for (int i = 0; i < times; i++) {
             sb.append(str);
         }

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/de97a11d/log4j-slf4j18-impl/src/main/java/org/apache/logging/slf4j/Log4jLoggerFactory.java
----------------------------------------------------------------------
diff --git 
a/log4j-slf4j18-impl/src/main/java/org/apache/logging/slf4j/Log4jLoggerFactory.java
 
b/log4j-slf4j18-impl/src/main/java/org/apache/logging/slf4j/Log4jLoggerFactory.java
index fcf1d66..e7865a8 100644
--- 
a/log4j-slf4j18-impl/src/main/java/org/apache/logging/slf4j/Log4jLoggerFactory.java
+++ 
b/log4j-slf4j18-impl/src/main/java/org/apache/logging/slf4j/Log4jLoggerFactory.java
@@ -32,7 +32,7 @@ public class Log4jLoggerFactory extends 
AbstractLoggerAdapter<Logger> implements
     private static final String PACKAGE = "org.slf4j";
     private final Log4jMarkerFactory markerFactory;
 
-    public Log4jLoggerFactory(Log4jMarkerFactory markerFactory) {
+    public Log4jLoggerFactory(final Log4jMarkerFactory markerFactory) {
         this.markerFactory = markerFactory;
     }
 

Reply via email to