This is an automated email from the ASF dual-hosted git repository.

vy pushed a commit to branch release/10.1.0
in repository https://gitbox.apache.org/repos/asf/logging-parent.git


The following commit(s) were added to refs/heads/release/10.1.0 by this push:
     new 5484f2d  Improve `Bundle-SymbolicName` pattern
5484f2d is described below

commit 5484f2d41b593b71e4465807a658482647ef5519
Author: Volkan Yazıcı <[email protected]>
AuthorDate: Thu Sep 28 12:22:48 2023 +0200

    Improve `Bundle-SymbolicName` pattern
---
 pom.xml | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/pom.xml b/pom.xml
index fe22d19..3e6a841 100644
--- a/pom.xml
+++ b/pom.xml
@@ -649,9 +649,9 @@
                 # `Bundle-Developers` is removed, since it is nothing but 
noise and occupies quite some real estate.
                 -removeheaders: Bundle-DocURL,Bundle-SCM,Bundle-Developers
 
-                # Create OSGi and JPMS module names based on the 
`project.artifactId`
+                # Create OSGi and JPMS module names based on the `groupId` and 
`artifactId`.
                 # This agrees with `maven-bundle-plugin`.
-                Bundle-SymbolicName: 
org.apache.logging.log4j.$[subst;$[project.artifactId];log4j-]
+                Bundle-SymbolicName: 
$[project.groupId].$[subst;$[subst;$[project.artifactId];log4j-];[^A-Za-z0-9];_]
                 -jpms-module-info: $[bnd-module-name];access=0
 
                 # Prevents an execution error in multi-release jars:
@@ -661,11 +661,13 @@
                 -jpms-module-info-options: 
org.osgi.core;static=true;transitive=false,\
                   org.osgi.framework;static=true;transitive=false,\
                   $[bnd-extra-module-options]
+
                 # Import all packages by default:
                 Import-Package: $[bnd-extra-package-options],*
 
-                # Allow each project to override the Multi-Release header:
+                # Allow each project to override the `Multi-Release` header:
                 Multi-Release: $[bnd-multi-release]
+
                 # Add manifests and modules for each multi-release version:
                 -jpms-multi-release: $[bnd-multi-release]
               ]]></bnd>

Reply via email to