(logging-chainsaw) branch master updated: tiny cleanups, removed useless docs

[grobmeier]

This is an automated email from the ASF dual-hosted git repository.

grobmeier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/logging-chainsaw.git


The following commit(s) were added to refs/heads/master by this push:
     new 11d66aa  tiny cleanups, removed useless docs
11d66aa is described below

commit 11d66aa92a2300723d9245e14a09f58becd316de
Author: Christian Grobmeier <c...@grobmeier.de>
AuthorDate: Fri Dec 1 23:53:44 2023 +0100

    tiny cleanups, removed useless docs
---
 src/main/java/org/apache/log4j/chainsaw/LogUI.java |  2 +-
 .../apache/log4j/chainsaw/help/HelpManager.java    | 47 ++--------------------
 2 files changed, 5 insertions(+), 44 deletions(-)

diff --git a/src/main/java/org/apache/log4j/chainsaw/LogUI.java 
b/src/main/java/org/apache/log4j/chainsaw/LogUI.java
index ce263ae..7640192 100644
--- a/src/main/java/org/apache/log4j/chainsaw/LogUI.java
+++ b/src/main/java/org/apache/log4j/chainsaw/LogUI.java
@@ -128,7 +128,7 @@ public class LogUI extends JFrame {
     private List<ReceiverEventListener> m_receiverListeners = new 
ArrayList<>();
     private ZeroConfPlugin m_zeroConf = new ZeroConfPlugin(settingsManager);
 
-    private static Logger logger = LogManager.getLogger();
+    private static Logger logger = LogManager.getLogger(LogUI.class);
 
     private final Object initializationLock = new Object();
 
diff --git a/src/main/java/org/apache/log4j/chainsaw/help/HelpManager.java 
b/src/main/java/org/apache/log4j/chainsaw/help/HelpManager.java
index 69d6d68..161d30a 100644
--- a/src/main/java/org/apache/log4j/chainsaw/help/HelpManager.java
+++ b/src/main/java/org/apache/log4j/chainsaw/help/HelpManager.java
@@ -38,13 +38,12 @@ import java.net.URL;
  * @author Paul Smith &lt;psm...@apache.org&gt;
  */
 public final class HelpManager {
+    private final Logger logger = LogManager.getLogger(HelpManager.class);
 
     private static final HelpManager instance = new HelpManager();
     private HelpLocator helpLocator = new HelpLocator();
     private URL helpURL;
-    private final PropertyChangeSupport propertySupport =
-        new PropertyChangeSupport(this);
-    private final Logger logger = LogManager.getLogger(HelpManager.class);
+    private final PropertyChangeSupport propertySupport = new 
PropertyChangeSupport(this);
 
     private HelpManager() {
 
@@ -65,11 +64,10 @@ public final class HelpManager {
                 logger.warn("Could not find any local JavaDocs, you might want 
to consider running 'ant javadoc'. The release version will be able to access 
Javadocs from the Apache website.");
             }
         } catch (Exception e) {
-            // TODO: handle exception
+            logger.error(e);
         }
 
         
helpLocator.installClassloaderLocator(this.getClass().getClassLoader());
-//      helpLocator.installLocator(new URL());
     }
 
     /**
@@ -87,81 +85,45 @@ public final class HelpManager {
         firePropertyChange("helpURL", null, this.helpURL);
     }
 
-    /**
-     * @param listener
-     */
     public void addPropertyChangeListener(PropertyChangeListener listener) {
         propertySupport.addPropertyChangeListener(listener);
     }
 
-    /**
-     * @param propertyName
-     * @param listener
-     */
     public synchronized void addPropertyChangeListener(String propertyName,
                                                        PropertyChangeListener 
listener) {
         propertySupport.addPropertyChangeListener(propertyName, listener);
     }
 
-    /**
-     * @param evt
-     */
     public void firePropertyChange(PropertyChangeEvent evt) {
         propertySupport.firePropertyChange(evt);
     }
 
-    /**
-     * @param propertyName
-     * @param oldValue
-     * @param newValue
-     */
     public void firePropertyChange(String propertyName, boolean oldValue,
                                    boolean newValue) {
         propertySupport.firePropertyChange(propertyName, oldValue, newValue);
     }
 
-    /**
-     * @param propertyName
-     * @param oldValue
-     * @param newValue
-     */
     public void firePropertyChange(String propertyName, int oldValue,
                                    int newValue) {
         propertySupport.firePropertyChange(propertyName, oldValue, newValue);
     }
 
-    /**
-     * @param propertyName
-     * @param oldValue
-     * @param newValue
-     */
     public void firePropertyChange(String propertyName, Object oldValue,
                                    Object newValue) {
         propertySupport.firePropertyChange(propertyName, oldValue, newValue);
     }
 
-    /**
-     * @param listener
-     */
     public synchronized void removePropertyChangeListener(
         PropertyChangeListener listener) {
         propertySupport.removePropertyChangeListener(listener);
     }
 
-    /**
-     * @param propertyName
-     * @param listener
-     */
     public synchronized void removePropertyChangeListener(String propertyName,
                                                           
PropertyChangeListener listener) {
         propertySupport.removePropertyChangeListener(propertyName, listener);
     }
 
-    /**
-     *
-     */
     public static HelpManager getInstance() {
-
         return instance;
     }
 
@@ -169,10 +131,9 @@ public final class HelpManager {
      * Given a class, and that it belongs within the org.apache.log4j project,
      * sets the URL to the JavaDoc for that class.
      *
-     * @param c
+     * @param c the class to show help for
      */
     public void showHelpForClass(Class c) {
-
         URL url = getHelpForClass(c);
         setHelpURL(url);
     }