(logging-log4cxx) branch master updated: Prevent compiler warnings in the next ABI version (#728)

[swebb2066]

This is an automated email from the ASF dual-hosted git repository.

swebb2066 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/logging-log4cxx.git


The following commit(s) were added to refs/heads/master by this push:
     new fe20e451 Prevent compiler warnings in the next ABI version (#728)
fe20e451 is described below

commit fe20e451b3cdc3fb0a1359f7c3d05ec879bc7d8e
Author: Stephen Webb <stephen.w...@ieee.org>
AuthorDate: Tue Aug 4 09:37:14 2026 +1000

    Prevent compiler warnings in the next ABI version (#728)
---
 src/main/cpp/multiprocessrollingfileappender.cpp | 3 +--
 src/main/cpp/odbcappender.cpp                    | 4 ++--
 src/main/cpp/outputdebugstringappender.cpp       | 3 +--
 src/test/cpp/net/socketappendertestcase.cpp      | 2 +-
 src/test/cpp/rolling/manualrollingtest.cpp       | 5 +----
 5 files changed, 6 insertions(+), 11 deletions(-)

diff --git a/src/main/cpp/multiprocessrollingfileappender.cpp 
b/src/main/cpp/multiprocessrollingfileappender.cpp
index 2e54e169..d024178d 100644
--- a/src/main/cpp/multiprocessrollingfileappender.cpp
+++ b/src/main/cpp/multiprocessrollingfileappender.cpp
@@ -82,10 +82,9 @@ public: // Support classes
                                {
                                        if 
(basePolicy->getPatternConverterList().size())
                                        {
-                                               Pool p;
                                                ObjectPtr obj = 
std::make_shared<Date>(apr_time_now());
                                                LogString fileNamePattern;
-                                               
(*(basePolicy->getPatternConverterList().begin()))->format(obj, 
fileNamePattern, p);
+                                               
(*(basePolicy->getPatternConverterList().begin()))->format(obj, 
fileNamePattern);
                                                filePrefix.clear();
                                                
Transcoder::encode(fileNamePattern, filePrefix);
                                        }
diff --git a/src/main/cpp/odbcappender.cpp b/src/main/cpp/odbcappender.cpp
index 22fd07cc..cb080e90 100644
--- a/src/main/cpp/odbcappender.cpp
+++ b/src/main/cpp/odbcappender.cpp
@@ -555,7 +555,7 @@ void 
ODBCAppender::ODBCAppenderPriv::setParameterValues(const spi::LoggingEventP
                else if (SQL_C_WCHAR == item.paramType)
                {
                        LogString sbuf;
-                       item.converter->format(event, sbuf, p);
+                       item.converter->format(event, sbuf);
 #if LOG4CXX_LOGCHAR_IS_WCHAR
                        std::wstring& tmp = sbuf;
 #else
@@ -571,7 +571,7 @@ void 
ODBCAppender::ODBCAppenderPriv::setParameterValues(const spi::LoggingEventP
                else if (SQL_C_CHAR == item.paramType)
                {
                        LogString sbuf;
-                       item.converter->format(event, sbuf, p);
+                       item.converter->format(event, sbuf);
 #if LOG4CXX_LOGCHAR_IS_UTF8
                        std::string& tmp = sbuf;
 #else
diff --git a/src/main/cpp/outputdebugstringappender.cpp 
b/src/main/cpp/outputdebugstringappender.cpp
index b4e9aa99..bf862ae2 100644
--- a/src/main/cpp/outputdebugstringappender.cpp
+++ b/src/main/cpp/outputdebugstringappender.cpp
@@ -35,8 +35,7 @@ OutputDebugStringAppender::OutputDebugStringAppender()
 void OutputDebugStringAppender::append( LOG4CXX_APPEND_FORMAL_PARAMETERS )
 {
        LogString buf;
-       Pool tempPool;
-       this->m_priv->layout->format(buf, event, tempPool);
+       this->m_priv->layout->format(buf, event);
 #if LOG4CXX_WCHAR_T_API
        LOG4CXX_ENCODE_WCHAR(wstr, buf);
        ::OutputDebugStringW(wstr.c_str());
diff --git a/src/test/cpp/net/socketappendertestcase.cpp 
b/src/test/cpp/net/socketappendertestcase.cpp
index c52fe33a..10a00ef1 100644
--- a/src/test/cpp/net/socketappendertestcase.cpp
+++ b/src/test/cpp/net/socketappendertestcase.cpp
@@ -67,7 +67,7 @@ class SocketAppenderTestCase : public AppenderSkeletonTestCase
                        LogManager::shutdown();
                }
 
-               AppenderSkeleton* createAppenderSkeleton() const
+               AppenderSkeleton* createAppenderSkeleton() const override
                {
                        return new log4cxx::net::SocketAppender();
                }
diff --git a/src/test/cpp/rolling/manualrollingtest.cpp 
b/src/test/cpp/rolling/manualrollingtest.cpp
index 50bd6681..69239856 100644
--- a/src/test/cpp/rolling/manualrollingtest.cpp
+++ b/src/test/cpp/rolling/manualrollingtest.cpp
@@ -24,7 +24,6 @@
 #include <log4cxx/rolling/fixedwindowrollingpolicy.h>
 #include <log4cxx/rolling/sizebasedtriggeringpolicy.h>
 #include <log4cxx/filter/levelrangefilter.h>
-#include <log4cxx/helpers/pool.h>
 #include <log4cxx/logger.h>
 #include <log4cxx/propertyconfigurator.h>
 #include <log4cxx/rolling/rollingfileappender.h>
@@ -176,11 +175,9 @@ public:
                policy->setFileNamePattern(LOG4CXX_STR("%i"));
                policy->activateOptions();
 
-               Pool pool;
                RolloverDescriptionPtr desc = policy->rollover(
                                
LOG4CXX_STR("output/manual-short-pattern-active.log"),
-                               false,
-                               pool);
+                               false);
 
                LOGUNIT_ASSERT(desc != NULL);
        }