This is an automated email from the ASF dual-hosted git repository.

FreeAndNil pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/logging-log4net.git


The following commit(s) were added to refs/heads/master by this push:
     new cb808518 fix the release verification instructions for Linux
cb808518 is described below

commit cb808518af941f7adcb0302bdf855a2c8ab405bf
Author: Jan Friedrich <[email protected]>
AuthorDate: Tue Aug 18 23:37:26 2026 +0200

    fix the release verification instructions for Linux
    
    verify-release.sh runs in a child process, so the "cd src" appended to it 
in 71631474 never reached the reviewer's shell and left them one level above 
the Dockerfile, breaking the docker build step. Move the step back into 
release-review.adoc and align the manual extract block with it.
---
 scripts/verify-release.sh                              |  4 +++-
 src/site/antora/modules/ROOT/pages/release-review.adoc | 13 +++++++++----
 2 files changed, 12 insertions(+), 5 deletions(-)

diff --git a/scripts/verify-release.sh b/scripts/verify-release.sh
index 70bdd1ac..7afd7100 100644
--- a/scripts/verify-release.sh
+++ b/scripts/verify-release.sh
@@ -59,4 +59,6 @@ mkdir -p src
 cd src
 unzip -q -o ../*source*.zip
 
-cd src
+# Do not "cd" here to position the reviewer: this runs as "bash 
./verify-release.sh", so a child
+# process, and the change would be lost. The step stays in 
release-review.adoc, typed by the reviewer.
+echo "Sources extracted to $(pwd)"
diff --git a/src/site/antora/modules/ROOT/pages/release-review.adoc 
b/src/site/antora/modules/ROOT/pages/release-review.adoc
index a7f8efd1..a105df06 100644
--- a/src/site/antora/modules/ROOT/pages/release-review.adoc
+++ b/src/site/antora/modules/ROOT/pages/release-review.adoc
@@ -141,13 +141,18 @@ for sigFile in *.asc; do gpg --verify $sigFile 
${sigFile%.asc}; done
 +
 [source,bash]
 ----
-mkdir -p src
-cd src
-unzip -q -o ../*source*.zip
+unzip -q -o *source*.zip -d src
+----
+====
 
+// Keep this step here: verify-release.sh runs in a child process, so it 
cannot cd for the reader,
+// and the next step needs the extracted root (the Dockerfile), not the src 
below it.
+. Switch to the extracted sources, which is the directory holding the 
`Dockerfile`:
++
+[source,bash]
+----
 cd src
 ----
-====
 
 . Verify the build (install https://docs.docker.com/engine/install[docker], if 
you haven't already):
 +  

Reply via email to