This is an automated email from the ASF dual-hosted git repository.
okislal pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/madlib.git
The following commit(s) were added to refs/heads/master by this push:
new 0aefb14 Kmeans: Fix auto kmeans tests
0aefb14 is described below
commit 0aefb1481307db29e078a0ea0c4630ee03999f49
Author: Orhan Kislal <okis...@apache.org>
AuthorDate: Fri Feb 5 19:41:57 2021 +0300
Kmeans: Fix auto kmeans tests
The auto kmeans dev check tests were using the incorrect column
for expr_point which caused some flaky tests.
---
.../postgres/modules/kmeans/test/kmeans.sql_in | 24 +++++++++++-----------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/src/ports/postgres/modules/kmeans/test/kmeans.sql_in
b/src/ports/postgres/modules/kmeans/test/kmeans.sql_in
index 6e86c82..614b630 100644
--- a/src/ports/postgres/modules/kmeans/test/kmeans.sql_in
+++ b/src/ports/postgres/modules/kmeans/test/kmeans.sql_in
@@ -87,7 +87,7 @@ COPY km_sample (pid, points) FROM stdin DELIMITER '|';
-- Test kmeanspp_auto
DROP TABLE IF EXISTS autokm_out,autokm_out_summary;
-SELECT * FROM kmeanspp_auto('kmeans_2d', 'autokm_out', 'array[x,y]',
ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
+SELECT * FROM kmeanspp_auto('kmeans_2d', 'autokm_out', 'position',
ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
'MADLIB_SCHEMA.avg', 20, 0.001, 0.1, 'elbow');
SELECT assert(
@@ -96,7 +96,7 @@ SELECT assert(
FROM autokm_out_summary;
DROP TABLE IF EXISTS autokm_out,autokm_out_summary;
-SELECT * FROM kmeanspp_auto('kmeans_2d', 'autokm_out', 'array[x,y]',
ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
+SELECT * FROM kmeanspp_auto('kmeans_2d', 'autokm_out', 'position',
ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
'MADLIB_SCHEMA.avg', 20, 0.001, 0.1, 'silhouette');
SELECT assert(
@@ -105,7 +105,7 @@ SELECT assert(
FROM autokm_out_summary;
DROP TABLE IF EXISTS autokm_out,autokm_out_summary;
-SELECT * FROM kmeanspp_auto('kmeans_2d', 'autokm_out', 'array[x,y]',
ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
+SELECT * FROM kmeanspp_auto('kmeans_2d', 'autokm_out', 'position',
ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
'MADLIB_SCHEMA.avg', 20, 0.001, 0.1, 'both');
SELECT assert(
@@ -114,7 +114,7 @@ SELECT assert(
FROM autokm_out_summary;
DROP TABLE IF EXISTS autokm_out,autokm_out_summary;
-SELECT * FROM kmeanspp_auto('kmeans_2d', 'autokm_out', 'array[x,y]',
ARRAY[2,3,4,5,6,7,8]);
+SELECT * FROM kmeanspp_auto('kmeans_2d', 'autokm_out', 'position',
ARRAY[2,3,4,5,6,7,8]);
SELECT assert(
silhouette > 0 AND objective_fn > 0,
@@ -123,7 +123,7 @@ FROM autokm_out_summary;
-- Test kmeans_random_auto
DROP TABLE IF EXISTS autokm_out,autokm_out_summary;
-SELECT * FROM kmeans_random_auto('kmeans_2d', 'autokm_out', 'array[x,y]',
ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
+SELECT * FROM kmeans_random_auto('kmeans_2d', 'autokm_out', 'position',
ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
'MADLIB_SCHEMA.avg', 20, 0.001, 'elbow');
SELECT assert(
@@ -132,7 +132,7 @@ SELECT assert(
FROM autokm_out_summary;
DROP TABLE IF EXISTS autokm_out,autokm_out_summary;
-SELECT * FROM kmeans_random_auto('kmeans_2d', 'autokm_out', 'array[x,y]',
ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
+SELECT * FROM kmeans_random_auto('kmeans_2d', 'autokm_out', 'position',
ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
'MADLIB_SCHEMA.avg', 20, 0.001, 'El');
SELECT assert(
@@ -141,7 +141,7 @@ SELECT assert(
FROM autokm_out_summary;
DROP TABLE IF EXISTS autokm_out,autokm_out_summary;
-SELECT * FROM kmeans_random_auto('kmeans_2d', 'autokm_out', 'array[x,y]',
ARRAY[5,6,7,8]);
+SELECT * FROM kmeans_random_auto('kmeans_2d', 'autokm_out', 'position',
ARRAY[5,6,7,8]);
SELECT assert(
silhouette > 0 AND objective_fn > 0,
@@ -154,7 +154,7 @@ FROM (SELECT * FROM autokm_out WHERE k =
any(ARRAY[5,6,7,8]))q;
-- Unordered k list test
DROP TABLE IF EXISTS autokm_out,autokm_out_summary;
-SELECT * FROM kmeans_random_auto('kmeans_2d', 'autokm_out', 'array[x,y]',
ARRAY[12,3,5,6,8], 'MADLIB_SCHEMA.squared_dist_norm2',
+SELECT * FROM kmeans_random_auto('kmeans_2d', 'autokm_out', 'position',
ARRAY[12,3,5,6,8], 'MADLIB_SCHEMA.squared_dist_norm2',
'MADLIB_SCHEMA.avg', 20, 0.001, 'silhouette');
-- Silhouette Tests
@@ -200,7 +200,7 @@ SELECT assert(
FROM autokm_out_summary;
DROP TABLE IF EXISTS autokm_out,autokm_out_summary;
-SELECT * FROM kmeans_random_auto('kmeans_2d', 'autokm_out', 'array[x,y]',
ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
+SELECT * FROM kmeans_random_auto('kmeans_2d', 'autokm_out', 'position',
ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
'MADLIB_SCHEMA.avg', 20, 0.001, 'silhouetTe');
SELECT assert(
@@ -209,7 +209,7 @@ SELECT assert(
FROM autokm_out_summary;
DROP TABLE IF EXISTS autokm_out,autokm_out_summary;
-SELECT * FROM kmeans_random_auto('kmeans_2d', 'autokm_out', 'array[x,y]',
ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
+SELECT * FROM kmeans_random_auto('kmeans_2d', 'autokm_out', 'position',
ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
'MADLIB_SCHEMA.avg', 20, 0.001, 'siL');
SELECT assert(
@@ -218,7 +218,7 @@ SELECT assert(
FROM autokm_out_summary;
DROP TABLE IF EXISTS autokm_out,autokm_out_summary;
-SELECT * FROM kmeans_random_auto('kmeans_2d', 'autokm_out', 'array[x,y]',
ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
+SELECT * FROM kmeans_random_auto('kmeans_2d', 'autokm_out', 'position',
ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
'MADLIB_SCHEMA.avg', 20, 0.001, 'both');
SELECT assert(
@@ -228,7 +228,7 @@ SELECT assert(
FROM autokm_out_summary;
DROP TABLE IF EXISTS autokm_out,autokm_out_summary;
-SELECT * FROM kmeans_random_auto('kmeans_2d', 'autokm_out', 'array[x,y]',
ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
+SELECT * FROM kmeans_random_auto('kmeans_2d', 'autokm_out', 'position',
ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
'MADLIB_SCHEMA.avg', 20, 0.001, 'b');
SELECT assert(
