rich7420 commented on code in PR #1026:
URL: https://github.com/apache/mahout/pull/1026#discussion_r2781100151
##########
qdp/qdp-core/src/readers/arrow_ipc.rs:
##########
@@ -49,11 +49,14 @@ impl ArrowIPCReader {
)));
}
Err(e) => {
- return Err(MahoutError::Io(format!(
- "Failed to check if Arrow IPC file exists at {}: {}",
- path.display(),
- e
- )));
+ return Err(MahoutError::IoWithSource {
+ message: format!(
+ "Failed to check if Arrow IPC file exists at {}: {}",
+ path.display(),
+ e
+ ),
+ source: e,
+ });
Review Comment:
Good catch. With thiserror, only the message field is used for Display /
to_string(), so the underlying source is not automatically appended. That means
there’s no double message when we just print the error once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
