Howardisme commented on code in PR #1104: URL: https://github.com/apache/mahout/pull/1104#discussion_r2868436048
########## .devcontainer/setup.sh: ########## @@ -21,6 +21,6 @@ curl -LsSf https://astral.sh/uv/install.sh | sh source $HOME/.local/bin/env # setup pre-commit hooks -cd /workspaces/mahout +cd /workspace Review Comment: Hi @ryankert01 and @viiccwen , Thank you for the quick response. I completely understand why it feels like it should be in mahout directly. However, I found devcontainer.json cause this error happened. In devcontainer.json, the workspace is explicitly mounted to `/workspace`: <img width="605" height="66" alt="image" src="https://github.com/user-attachments/assets/b358765a-9f6f-46c3-85a6-2b1290f3fc4c"; /> Because devcontainer.json forces the target to /workspace, when setup.sh tries to run cd /workspaces/mahout on line 24, it throws the No such file or directory error and break the initialization of setup. We have two ways to fix it: 1. (My current PR): Update setup.sh to use cd /workspace to match the devcontainer.json. This is often safer because we don't know what the user names their local clone directory. 2. Update devcontainer.json to mount to /workspaces/mahout instead. Let me know which way you think is better to this issue or any follow up questions! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
