rich7420 commented on code in PR #1101:
URL: https://github.com/apache/mahout/pull/1101#discussion_r2868916951
##########
qdp/qdp-core/src/encoding/mod.rs:
##########
@@ -141,7 +141,8 @@ pub(crate) fn stream_encode<E: ChunkEncoder>(
encoder: E,
) -> Result<*mut DLManagedTensor> {
// Initialize reader
- let mut reader_core = crate::io::ParquetBlockReader::new(path, None)?;
+ let mut reader_core =
+ crate::io::ParquetBlockReader::new(path, None,
crate::reader::NullHandling::FillZero)?;
Review Comment:
It seems stream_encode() uses hardcoded NullHandling::FillZero for
ParquetBlockReader. Batch and streaming reader paths are unified; this call
site has no config. I think maybe we could have a follow-up here if
stream_encode is ever given a config or options, expose null_handling there.
otherwise document that streaming encode keeps FillZero for backward
compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
