SuyashParmar commented on code in PR #1100:
URL: https://github.com/apache/mahout/pull/1100#discussion_r2868937267
##########
qdp/qdp-python/src/pytorch.rs:
##########
@@ -56,6 +56,23 @@ pub fn is_cuda_tensor(tensor: &Bound<'_, PyAny>) ->
PyResult<bool> {
Ok(device_type == "cuda")
}
+const CUDA_ENCODING_METHODS: &[&str] = &["amplitude", "angle", "basis", "iqp",
"iqp-z"];
Review Comment:
@ryankert01 Makes sense — for this follow-up I kept the const local to keep
scope small, but I agree it should live in a shared constants/module location.
I can move it in a quick follow-up refactor if preferred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
