viiccwen commented on code in PR #1130: URL: https://github.com/apache/mahout/pull/1130#discussion_r2901286448
########## qdp/qdp-python/tests/test_quantum_data_loader.py: ########## Review Comment: Some testing suggestions: 1. handle query string should work properly. 2. `source_file(s3://...?query, streaming=True)` accepted when key ends with .parquet. 3. `source_file(s3://.../.npy, streaming=False)` is accepted at builder (no `ValueError`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
