rich7420 commented on PR #1325: URL: https://github.com/apache/mahout/pull/1325#issuecomment-4539813516
Test-strength note (non-blocking): the state buffers are created with `alloc_zeros`, so the "all other elements should be 0" assertions pass even if the kernel never writes those slots — they're zero to begin with. Since basis encoding's contract is to overwrite the *entire* state vector, pre-filling the buffer with a sentinel (e.g. `1.0`) before launch would actually verify the kernel zeroes them. Matters most for the batch kernels, where a grid-stride indexing bug could silently skip elements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
