rich7420 commented on code in PR #1343:
URL: https://github.com/apache/mahout/pull/1343#discussion_r3334773901
##########
qdp/qdp-core/src/reader.rs:
##########
@@ -49,6 +49,15 @@ use arrow::array::{Array, Float64Array};
use crate::error::Result;
+/// Scalar element type for [`DataReader`] output (`f32` or `f64` only).
+///
+/// Keeps f32 file data as `Vec<f32>` end-to-end once readers implement
Review Comment:
Nit: the PR description calls this "sealed-by-usage", but as written
`FloatElem` is implementable by any downstream type satisfying `Copy + Send +
Sync + 'static` (e.g. `u32`, or `half::f16` via a feature flag).
Either soften the wording (e.g. `/// Currently implemented for f32 and
f64.`) or actually seal it with a private supertrait:
```rust
mod sealed { pub trait Sealed {} impl Sealed for f32 {} impl Sealed for f64
{} }
pub trait FloatElem: sealed::Sealed + Copy + Send + Sync + 'static {}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
