rich7420 commented on code in PR #1393:
URL: https://github.com/apache/mahout/pull/1393#discussion_r3380622531
##########
qdp/qdp-core/src/readers/parquet.rs:
##########
@@ -644,13 +713,17 @@ mod tests {
let array = Arc::new(Int32Array::from(vec![1, 2, 3])) as ArrayRef;
let file = write_test_parquet(schema, vec![array]);
- let result = ParquetReader::new(file.path(), None,
NullHandling::FillZero);
+ let result = ParquetReader::<f64>::new(file.path(), None,
NullHandling::FillZero);
assert!(result.is_err());
let err_msg = match result {
Err(e) => e.to_string(),
Ok(_) => panic!(),
};
- assert!(err_msg.contains("Expected List<Float64> or
FixedSizeList<Float64> column"));
+ assert!(
+ err_msg.contains("Expected List")
Review Comment:
This assertion got pretty loose
cuz the `|| contains("Float32/Float64")` substring shows up in almost every
error message in this file, so the test would pass even if the wrong validation
branch fired. Maybe assert on the actual `Int32`/`List<` dtype in the message
instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
