This is an automated email from the ASF dual-hosted git repository.

cstamas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-integration-testing.git


The following commit(s) were added to refs/heads/master by this push:
     new f4a02132a [MNG-5181] Improve "missing dependency" message (#249)
f4a02132a is described below

commit f4a02132a8995a795a7e4533e882441c734b9f51
Author: Tamas Cservenak <ta...@cservenak.net>
AuthorDate: Thu Mar 2 14:28:56 2023 +0100

    [MNG-5181] Improve "missing dependency" message (#249)
    
    Related IT change, as the change for this issue made MNG-7128 IT
    to fail, as it was too eagerly match whole error message string
    that has now due MNG-5181 changed.
    
    To fix it, match only the key parts of the expected error message,
    that project failed, due transfer failure, as insecure mirror
    was blocked. This makes IT assert same thing, but is more
    flexible regarding error text change in MNG-5181.
    
    ---
    
    https://issues.apache.org/jira/browse/MNG-5185
---
 .../maven/it/MavenITmng7128BlockExternalHttpReactorTest.java     | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git 
a/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7128BlockExternalHttpReactorTest.java
 
b/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7128BlockExternalHttpReactorTest.java
index fe9ee07f4..10b47fd15 100644
--- 
a/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7128BlockExternalHttpReactorTest.java
+++ 
b/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7128BlockExternalHttpReactorTest.java
@@ -60,12 +60,9 @@ public class MavenITmng7128BlockExternalHttpReactorTest
         catch ( VerificationException ve )
         {
             // Inspect the reason why the build broke.
-            verifier.verifyTextInLog( "[ERROR] Failed to execute goal on 
project http-repository-in-pom: "
-                + "Could not resolve dependencies for project 
org.apache.maven.its.mng7128:http-repository-in-pom:jar:1.0: "
-                + "Failed to collect dependencies at junit:junit:jar:1.3: "
-                + "Failed to read artifact descriptor for junit:junit:jar:1.3: 
"
-                + "Could not transfer artifact junit:junit:pom:1.3 from/to 
maven-default-http-blocker (http://0.0.0.0/): " // mirror introduced in MNG-7118
-                + "Blocked mirror for repositories: [insecure-http-repo 
(http://repo.maven.apache.org/, default, releases+snapshots)]" );
+            verifier.verifyTextInLog( "[ERROR] Failed to execute goal on 
project http-repository-in-pom: " ); // project failed
+            verifier.verifyTextInLog( "Could not transfer artifact 
junit:junit:pom:1.3 from/to maven-default-http-blocker (http://0.0.0.0/): " ); 
// mirror introduced in MNG-7118
+            verifier.verifyTextInLog( "Blocked mirror for repositories: 
[insecure-http-repo (http://repo.maven.apache.org/, default, 
releases+snapshots)]" ); // blocked mirror text present
         }
     }
 }

Reply via email to