This is an automated email from the ASF dual-hosted git repository. gnodet pushed a commit to branch gnodet-patch-1 in repository https://gitbox.apache.org/repos/asf/maven.git
commit 718db2e0bc57ccf7e5aa2e7eda4b7e972c2d7f2c Author: Guillaume Nodet <[email protected]> AuthorDate: Sun Mar 12 07:35:08 2023 +0100 Update DefaultSettingsValidator.java --- .../apache/maven/settings/validation/DefaultSettingsValidator.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/maven-settings-builder/src/main/java/org/apache/maven/settings/validation/DefaultSettingsValidator.java b/maven-settings-builder/src/main/java/org/apache/maven/settings/validation/DefaultSettingsValidator.java index 494ae2c58..f712dbc11 100644 --- a/maven-settings-builder/src/main/java/org/apache/maven/settings/validation/DefaultSettingsValidator.java +++ b/maven-settings-builder/src/main/java/org/apache/maven/settings/validation/DefaultSettingsValidator.java @@ -59,10 +59,9 @@ public class DefaultSettingsValidator implements SettingsValidator { for (int i = 0; i < pluginGroups.size(); i++) { String pluginGroup = pluginGroups.get(i); - if (pluginGroup == null || pluginGroup.isEmpty()) { - addViolation( - problems, Severity.ERROR, "pluginGroups.pluginGroup[" + i + "]", null, "must not be empty"); - } else if (!ID_REGEX.matcher(pluginGroup).matches()) { + validateStringNotEmpty(problems, "pluginGroups.pluginGroup[" + i + "]", pluginGroup, null); + + if (!ID_REGEX.matcher(pluginGroup).matches()) { addViolation( problems, Severity.ERROR,
