[maven-dependency-analyzer] branch master updated: [MSHARED-1149] Replace System.out by logger

[sjaranowski]

This is an automated email from the ASF dual-hosted git repository.

sjaranowski pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-dependency-analyzer.git


The following commit(s) were added to refs/heads/master by this push:
     new 9c05199  [MSHARED-1149] Replace System.out by logger
9c05199 is described below

commit 9c05199709db540441a05578d4727d2a3b6326f8
Author: Koziolek <bjkuczyn...@gmail.com>
AuthorDate: Sat Oct 22 20:50:40 2022 +0200

    [MSHARED-1149] Replace System.out by logger
---
 pom.xml                                                     | 13 +++++++++++++
 .../dependency/analyzer/asm/DependencyClassFileVisitor.java |  6 +++++-
 2 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 4da995d..2db83c0 100644
--- a/pom.xml
+++ b/pom.xml
@@ -58,6 +58,7 @@
 
   <properties>
     <mavenVersion>3.2.5</mavenVersion>
+    <slf4jVersion>1.7.36</slf4jVersion>
     <javaVersion>8</javaVersion>
     
<project.build.outputTimestamp>2022-08-20T15:25:47Z</project.build.outputTimestamp>
     <!-- TODO check with next parent -->
@@ -89,6 +90,12 @@
       <version>9.5</version>
     </dependency>
 
+    <dependency>
+      <groupId>org.slf4j</groupId>
+      <artifactId>slf4j-api</artifactId>
+      <version>${slf4jVersion}</version>
+    </dependency>
+
     <dependency>
       <groupId>commons-io</groupId>
       <artifactId>commons-io</artifactId>
@@ -108,6 +115,12 @@
       <version>3.24.2</version>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>org.slf4j</groupId>
+      <artifactId>slf4j-simple</artifactId>
+      <version>${slf4jVersion}</version>
+      <scope>test</scope>
+    </dependency>
   </dependencies>
 
   <build>
diff --git 
a/src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DependencyClassFileVisitor.java
 
b/src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DependencyClassFileVisitor.java
index 79b2c99..8c1cd3d 100644
--- 
a/src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DependencyClassFileVisitor.java
+++ 
b/src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DependencyClassFileVisitor.java
@@ -30,6 +30,8 @@ import org.objectweb.asm.ClassVisitor;
 import org.objectweb.asm.FieldVisitor;
 import org.objectweb.asm.MethodVisitor;
 import org.objectweb.asm.signature.SignatureVisitor;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 /**
  * Computes the set of classes referenced by visited class files, using
@@ -41,6 +43,8 @@ import org.objectweb.asm.signature.SignatureVisitor;
 public class DependencyClassFileVisitor implements ClassFileVisitor {
     private final ResultCollector resultCollector = new ResultCollector();
 
+    private final Logger logger = LoggerFactory.getLogger(getClass());
+
     /**
      * <p>Constructor for DependencyClassFileVisitor.</p>
      */
@@ -70,7 +74,7 @@ public class DependencyClassFileVisitor implements 
ClassFileVisitor {
         } catch (IndexOutOfBoundsException e) {
             // some bug inside ASM causes an IOB exception. Log it and move on?
             // this happens when the class isn't valid.
-            System.out.println("Unable to process: " + className);
+            logger.warn("Unable to process: " + className);
         }
     }