This is an automated email from the ASF dual-hosted git repository. sjaranowski pushed a commit to branch MDEP-855 in repository https://gitbox.apache.org/repos/asf/maven-dependency-plugin.git
commit c2785a6b34338c13df450e0b59d2a4620f5d7e68 Author: Slawomir Jaranowski <s.jaranow...@gmail.com> AuthorDate: Thu Apr 13 00:13:41 2023 +0200 [MDEP-855] Remove unused and ignored parameter - useJvmChmod --- src/it/projects/copy-dependencies/pom.xml | 1 - .../plugins/dependency/AbstractDependencyMojo.java | 25 ---------------------- .../dependency/fromConfiguration/CopyMojo.java | 6 ------ .../fromDependencies/CopyDependenciesMojo.java | 6 ------ .../dependency/resolvers/AbstractResolveMojo.java | 6 ------ .../fromConfiguration/TestUnpackMojo.java | 2 -- .../TestUnpackDependenciesMojo.java | 1 - .../TestUnpackDependenciesMojo2.java | 1 - .../unpack-dependencies-test/plugin-config.xml | 1 - 9 files changed, 49 deletions(-) diff --git a/src/it/projects/copy-dependencies/pom.xml b/src/it/projects/copy-dependencies/pom.xml index cff5a89f..398aeeb2 100644 --- a/src/it/projects/copy-dependencies/pom.xml +++ b/src/it/projects/copy-dependencies/pom.xml @@ -101,7 +101,6 @@ <configuration> <copyPom>true</copyPom> <outputDirectory>${project.build.directory}/it/copy-dep-test-1</outputDirectory> - <useJvmChmod>false</useJvmChmod> </configuration> </execution> <execution> diff --git a/src/main/java/org/apache/maven/plugins/dependency/AbstractDependencyMojo.java b/src/main/java/org/apache/maven/plugins/dependency/AbstractDependencyMojo.java index 0c8b6ae5..d1140fca 100644 --- a/src/main/java/org/apache/maven/plugins/dependency/AbstractDependencyMojo.java +++ b/src/main/java/org/apache/maven/plugins/dependency/AbstractDependencyMojo.java @@ -72,17 +72,6 @@ public abstract class AbstractDependencyMojo extends AbstractMojo { @Parameter(defaultValue = "false") private boolean skipDuringIncrementalBuild; - /** - * <p> - * will use the jvm chmod, this is available for user and all level group level will be ignored - * </p> - * <b>since 2.6 is on by default</b> - * - * @since 2.5.1 - */ - @Parameter(property = "dependency.useJvmChmod", defaultValue = "true") - private boolean useJvmChmod = true; - /** * ignore to set file permissions when unpacking a dependency * @@ -377,20 +366,6 @@ public abstract class AbstractDependencyMojo extends AbstractMojo { this.archiverManager = archiverManager; } - /** - * @return {@link #useJvmChmod} - */ - public boolean isUseJvmChmod() { - return useJvmChmod; - } - - /** - * @param useJvmChmod {@link #useJvmChmod} - */ - public void setUseJvmChmod(boolean useJvmChmod) { - this.useJvmChmod = useJvmChmod; - } - /** * @return {@link #skip} */ diff --git a/src/main/java/org/apache/maven/plugins/dependency/fromConfiguration/CopyMojo.java b/src/main/java/org/apache/maven/plugins/dependency/fromConfiguration/CopyMojo.java index 244c3e24..9cf85e21 100644 --- a/src/main/java/org/apache/maven/plugins/dependency/fromConfiguration/CopyMojo.java +++ b/src/main/java/org/apache/maven/plugins/dependency/fromConfiguration/CopyMojo.java @@ -74,12 +74,6 @@ public class CopyMojo extends AbstractFromConfigurationMojo { @Parameter(property = "artifact") private String artifact; - /** - * <i>not used in this goal</i> - */ - @Parameter - protected boolean useJvmChmod = true; - /** * <i>not used in this goal</i> */ diff --git a/src/main/java/org/apache/maven/plugins/dependency/fromDependencies/CopyDependenciesMojo.java b/src/main/java/org/apache/maven/plugins/dependency/fromDependencies/CopyDependenciesMojo.java index 2de21ef3..ebf766e5 100644 --- a/src/main/java/org/apache/maven/plugins/dependency/fromDependencies/CopyDependenciesMojo.java +++ b/src/main/java/org/apache/maven/plugins/dependency/fromDependencies/CopyDependenciesMojo.java @@ -92,12 +92,6 @@ public class CopyDependenciesMojo extends AbstractFromDependenciesMojo { @Parameter(property = "mdep.addParentPoms", defaultValue = "false") protected boolean addParentPoms; - /** - * <i>not used in this goal</i> - */ - @Parameter - protected boolean useJvmChmod = true; - /** * <i>not used in this goal</i> */ diff --git a/src/main/java/org/apache/maven/plugins/dependency/resolvers/AbstractResolveMojo.java b/src/main/java/org/apache/maven/plugins/dependency/resolvers/AbstractResolveMojo.java index aee1208a..9ed8d961 100644 --- a/src/main/java/org/apache/maven/plugins/dependency/resolvers/AbstractResolveMojo.java +++ b/src/main/java/org/apache/maven/plugins/dependency/resolvers/AbstractResolveMojo.java @@ -66,12 +66,6 @@ public abstract class AbstractResolveMojo extends AbstractDependencyFilterMojo { @Parameter(property = "excludeReactor", defaultValue = "true") protected boolean excludeReactor; - /** - * <i>not used in this goal</i> - */ - @Parameter - protected boolean useJvmChmod = true; - /** * <i>not used in this goal</i> */ diff --git a/src/test/java/org/apache/maven/plugins/dependency/fromConfiguration/TestUnpackMojo.java b/src/test/java/org/apache/maven/plugins/dependency/fromConfiguration/TestUnpackMojo.java index 6ddd37bb..8ca9ad8c 100644 --- a/src/test/java/org/apache/maven/plugins/dependency/fromConfiguration/TestUnpackMojo.java +++ b/src/test/java/org/apache/maven/plugins/dependency/fromConfiguration/TestUnpackMojo.java @@ -61,8 +61,6 @@ public class TestUnpackMojo extends AbstractDependencyMojoTestCase { stubFactory.setSrcFile(new File( getBasedir() + File.separatorChar + "target/test-classes/unit/unpack-dependencies-test/test.txt")); - mojo.setUseJvmChmod(true); - MavenSession session = newMavenSession(mojo.getProject()); setVariableValueToObject(mojo, "session", session); diff --git a/src/test/java/org/apache/maven/plugins/dependency/fromDependencies/TestUnpackDependenciesMojo.java b/src/test/java/org/apache/maven/plugins/dependency/fromDependencies/TestUnpackDependenciesMojo.java index d24ed3c0..5780feeb 100644 --- a/src/test/java/org/apache/maven/plugins/dependency/fromDependencies/TestUnpackDependenciesMojo.java +++ b/src/test/java/org/apache/maven/plugins/dependency/fromDependencies/TestUnpackDependenciesMojo.java @@ -54,7 +54,6 @@ public class TestUnpackDependenciesMojo extends AbstractDependencyMojoTestCase { File testPom = new File(getBasedir(), "target/test-classes/unit/unpack-dependencies-test/plugin-config.xml"); mojo = (UnpackDependenciesMojo) lookupMojo("unpack-dependencies", testPom); mojo.outputDirectory = new File(this.testDir, "outputDirectory"); - mojo.setUseJvmChmod(true); // mojo.silent = true; // it needs to get the archivermanager diff --git a/src/test/java/org/apache/maven/plugins/dependency/fromDependencies/TestUnpackDependenciesMojo2.java b/src/test/java/org/apache/maven/plugins/dependency/fromDependencies/TestUnpackDependenciesMojo2.java index 20f64b56..0811e792 100644 --- a/src/test/java/org/apache/maven/plugins/dependency/fromDependencies/TestUnpackDependenciesMojo2.java +++ b/src/test/java/org/apache/maven/plugins/dependency/fromDependencies/TestUnpackDependenciesMojo2.java @@ -46,7 +46,6 @@ public class TestUnpackDependenciesMojo2 extends AbstractDependencyMojoTestCase File testPom = new File(getBasedir(), "target/test-classes/unit/unpack-dependencies-test/plugin-config.xml"); mojo = (UnpackDependenciesMojo) lookupMojo("unpack-dependencies", testPom); mojo.outputDirectory = new File(this.testDir, "outputDirectory"); - mojo.setUseJvmChmod(true); // mojo.silent = true; // it needs to get the archivermanager diff --git a/src/test/resources/unit/unpack-dependencies-test/plugin-config.xml b/src/test/resources/unit/unpack-dependencies-test/plugin-config.xml index 01a1f190..d44f38a3 100644 --- a/src/test/resources/unit/unpack-dependencies-test/plugin-config.xml +++ b/src/test/resources/unit/unpack-dependencies-test/plugin-config.xml @@ -25,7 +25,6 @@ <configuration> <project implementation="org.apache.maven.plugins.dependency.testUtils.stubs.DependencyProjectStub"/> <silent>true</silent> - <useJvmChmod>true</useJvmChmod> </configuration> </plugin> </plugins>