This is an automated email from the ASF dual-hosted git repository.

michaelo pushed a commit to branch simplify
in repository https://gitbox.apache.org/repos/asf/maven-surefire.git

commit db692e4b5d4d1c443562bad39b9c67de23b04bbc
Author: Michael Osipov <[email protected]>
AuthorDate: Mon May 29 22:39:42 2023 +0200

    Simplify 
o.a.m.plugins.surefire.report.AbstractSurefireReportMojo.canGenerateReport()
    
    The call to super method is redundant because it is always true.
    
    This closes #651
---
 .../maven/plugins/surefire/report/AbstractSurefireReportMojo.java     | 4 ----
 1 file changed, 4 deletions(-)

diff --git 
a/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/AbstractSurefireReportMojo.java
 
b/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/AbstractSurefireReportMojo.java
index 27812808f..813a29a81 100644
--- 
a/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/AbstractSurefireReportMojo.java
+++ 
b/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/AbstractSurefireReportMojo.java
@@ -167,10 +167,6 @@ public abstract class AbstractSurefireReportMojo extends 
AbstractMavenReport {
 
     @Override
     public boolean canGenerateReport() {
-        return hasReportDirectories() && super.canGenerateReport();
-    }
-
-    private boolean hasReportDirectories() {
         if (isSkipped()) {
             return false;
         }

Reply via email to