(maven-resolver) branch master updated: [MRESOLVER-547] Just use setVersion (#481)

[cstamas]

This is an automated email from the ASF dual-hosted git repository.

cstamas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-resolver.git


The following commit(s) were added to refs/heads/master by this push:
     new dd67a5ac [MRESOLVER-547] Just use setVersion (#481)
dd67a5ac is described below

commit dd67a5ac798936c1535c716cc4bdb17fd5b0d99d
Author: Tamas Cservenak <ta...@cservenak.net>
AuthorDate: Thu Apr 25 16:37:50 2024 +0200

    [MRESOLVER-547] Just use setVersion (#481)
    
    No need for full copy, Artifact is already immutable.
    Moreover, the instance may be not DefaultArtifact but
    something else. And finally, setVersion already
    have "optimization" to return this if version is
    same as the one we want to copy with.
    
    ---
    
    https://issues.apache.org/jira/browse/MRESOLVER-547
---
 .../internal/impl/collect/bf/BfDependencyCollector.java       | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/bf/BfDependencyCollector.java
 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/bf/BfDependencyCollector.java
index 18946470..4db4f1f4 100644
--- 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/bf/BfDependencyCollector.java
+++ 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/bf/BfDependencyCollector.java
@@ -46,8 +46,6 @@ import java.util.stream.Stream;
 import org.eclipse.aether.RepositorySystemSession;
 import org.eclipse.aether.RequestTrace;
 import org.eclipse.aether.artifact.Artifact;
-import org.eclipse.aether.artifact.ArtifactType;
-import org.eclipse.aether.artifact.DefaultArtifact;
 import org.eclipse.aether.collection.CollectRequest;
 import org.eclipse.aether.collection.DependencyCollectionException;
 import org.eclipse.aether.collection.DependencyManager;
@@ -451,14 +449,7 @@ public class BfDependencyCollector extends 
DependencyCollectorDelegate {
     private ArtifactDescriptorResult resolveDescriptorForVersion(
             Args args, DependencyProcessingContext context, Results results, 
Dependency dependency, Version version) {
         Artifact original = dependency.getArtifact();
-        Artifact newArtifact = new DefaultArtifact(
-                original.getGroupId(),
-                original.getArtifactId(),
-                original.getClassifier(),
-                original.getExtension(),
-                version.toString(),
-                original.getProperties(),
-                (ArtifactType) null);
+        Artifact newArtifact = original.setVersion(version.toString());
         Dependency newDependency =
                 new Dependency(newArtifact, dependency.getScope(), 
dependency.isOptional(), dependency.getExclusions());
         DependencyProcessingContext newContext = context.copy();