This is an automated email from the ASF dual-hosted git repository.
sjaranowski pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-shared-resources.git
The following commit(s) were added to refs/heads/master by this push:
new 1b6c117 [MSHARED-1401] Checkstyle drop MagicNumber
1b6c117 is described below
commit 1b6c117c6ff239aafc358c349a10002cb3f068d7
Author: Slawomir Jaranowski <s.jaranow...@gmail.com>
AuthorDate: Sun Jun 2 11:14:47 2024 +0200
[MSHARED-1401] Checkstyle drop MagicNumber
more of items are excluded now
---
src/main/resources/config/maven_checks.xml | 4 ----
src/main/resources/config/maven_checks_nocodestyle.xml | 4 ----
2 files changed, 8 deletions(-)
diff --git a/src/main/resources/config/maven_checks.xml
b/src/main/resources/config/maven_checks.xml
index d8f25f9..2e746a4 100644
--- a/src/main/resources/config/maven_checks.xml
+++ b/src/main/resources/config/maven_checks.xml
@@ -174,10 +174,6 @@ under the License.
</module>
<module name="IllegalInstantiation"/>
<module name="InnerAssignment"/>
- <module name="MagicNumber">
- <!-- some numbers are really not that magic -->
- <property name="ignoreNumbers" value="-4, -3, -2, -1, 0, 1, 2, 3, 4,
5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 31, 32, 37, 64, 100, 128, 256,
512, 1000, 1024"/>
- </module>
<module name="MissingSwitchDefault"/>
<module name="SimplifyBooleanExpression"/>
<module name="SimplifyBooleanReturn"/>
diff --git a/src/main/resources/config/maven_checks_nocodestyle.xml
b/src/main/resources/config/maven_checks_nocodestyle.xml
index 7e7ee86..47d2cf2 100644
--- a/src/main/resources/config/maven_checks_nocodestyle.xml
+++ b/src/main/resources/config/maven_checks_nocodestyle.xml
@@ -121,10 +121,6 @@ under the License.
</module>
<module name="IllegalInstantiation"/>
<module name="InnerAssignment"/>
- <module name="MagicNumber">
- <!-- some numbers are really not that magic -->
- <property name="ignoreNumbers" value="-4, -3, -2, -1, 0, 1, 2, 3,
4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 31, 32, 37, 64, 100, 128,
256, 512, 1000, 1024"/>
- </module>
<module name="MissingSwitchDefault"/>
<module name="SimplifyBooleanExpression"/>
<module name="SimplifyBooleanReturn"/>
