This is an automated email from the ASF dual-hosted git repository.

sjaranowski pushed a commit to branch maven-3.9.x
in repository https://gitbox.apache.org/repos/asf/maven.git


The following commit(s) were added to refs/heads/maven-3.9.x by this push:
     new df00ea5c10 [MNG-7902] Sort plugins in the validation report (#1510)
df00ea5c10 is described below

commit df00ea5c103846367d47a20649e72bd36bff22b7
Author: Yueh Chun Wu <152671651+yue...@users.noreply.github.com>
AuthorDate: Thu May 23 14:25:04 2024 +0200

    [MNG-7902] Sort plugins in the validation report (#1510)
    
    Co-authored-by: Yueh Chun Wu <kevi...@yuehdembp.attlocal.net>
    
    (cherry picked from commit dd9679450e00d08caf4f042d92c22acd38585bd5)
---
 .../maven/plugin/internal/DefaultPluginValidationManager.java     | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git 
a/maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginValidationManager.java
 
b/maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginValidationManager.java
index 31227a4e40..a212287035 100644
--- 
a/maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginValidationManager.java
+++ 
b/maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginValidationManager.java
@@ -23,6 +23,7 @@ import javax.inject.Singleton;
 
 import java.io.File;
 import java.nio.file.Path;
+import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
@@ -222,7 +223,12 @@ public final class DefaultPluginValidationManager extends 
AbstractEventSpy imple
             logger.warn("");
             logger.warn("Plugin {} validation issues were detected in 
following plugin(s)", issueLocalitiesToReport);
             logger.warn("");
-            for (Map.Entry<String, PluginValidationIssues> entry : 
issuesMap.entrySet()) {
+
+            // Sorting the plugins
+            List<Map.Entry<String, PluginValidationIssues>> sortedEntries = 
new ArrayList<>(issuesMap.entrySet());
+            
sortedEntries.sort(Map.Entry.comparingByKey(String.CASE_INSENSITIVE_ORDER));
+
+            for (Map.Entry<String, PluginValidationIssues> entry : 
sortedEntries) {
                 PluginValidationIssues issues = entry.getValue();
                 if (!hasAnythingToReport(issues, issueLocalitiesToReport)) {
                     continue;

Reply via email to