(maven-resolver) branch maven-resolver-1.9.x updated: [MRESOLVER-659] NPE in trusted checksum post processor if artifact resolution failed (#665)

[cstamas]

This is an automated email from the ASF dual-hosted git repository.

cstamas pushed a commit to branch maven-resolver-1.9.x
in repository https://gitbox.apache.org/repos/asf/maven-resolver.git


The following commit(s) were added to refs/heads/maven-resolver-1.9.x by this 
push:
     new ba361da1 [MRESOLVER-659] NPE in trusted checksum post processor if 
artifact resolution failed (#665)
ba361da1 is described below

commit ba361da1d3f288a1635aa59117e071e906c3c621
Author: Tamas Cservenak <ta...@cservenak.net>
AuthorDate: Tue Feb 25 12:37:34 2025 +0100

    [MRESOLVER-659] NPE in trusted checksum post processor if artifact 
resolution failed (#665)
    
    Backport of MRESOLVER-653
    
    ---
    
    https://issues.apache.org/jira/browse/MRESOLVER-659
---
 .../TrustedChecksumsArtifactResolverPostProcessor.java           | 2 +-
 .../TrustedChecksumsArtifactResolverPostProcessorTest.java       | 9 +++++++++
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/resolution/TrustedChecksumsArtifactResolverPostProcessor.java
 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/resolution/TrustedChecksumsArtifactResolverPostProcessor.java
index cb42a79e..fc400a39 100644
--- 
a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/resolution/TrustedChecksumsArtifactResolverPostProcessor.java
+++ 
b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/resolution/TrustedChecksumsArtifactResolverPostProcessor.java
@@ -120,7 +120,7 @@ public final class 
TrustedChecksumsArtifactResolverPostProcessor extends Artifac
         final boolean snapshots = ConfigUtils.getBoolean(session, false, 
configPropKey(CONF_NAME_SNAPSHOTS));
 
         for (ArtifactResult artifactResult : artifactResults) {
-            if (artifactResult.getArtifact().isSnapshot() && !snapshots) {
+            if (artifactResult.getRequest().getArtifact().isSnapshot() && 
!snapshots) {
                 continue;
             }
             if (artifactResult.isResolved()) {
diff --git 
a/maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/resolution/TrustedChecksumsArtifactResolverPostProcessorTest.java
 
b/maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/resolution/TrustedChecksumsArtifactResolverPostProcessorTest.java
index df64637c..e361353e 100644
--- 
a/maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/resolution/TrustedChecksumsArtifactResolverPostProcessorTest.java
+++ 
b/maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/resolution/TrustedChecksumsArtifactResolverPostProcessorTest.java
@@ -142,6 +142,15 @@ public class 
TrustedChecksumsArtifactResolverPostProcessorTest implements Truste
 
     // UTs below
 
+    @Test
+    public void unresolvedArtifact() {
+        ArtifactResult artifactResult =
+                
createArtifactResult(artifactWithTrustedChecksum).setArtifact(null);
+        assertThat(artifactResult.isResolved(), equalTo(false));
+
+        subject.postProcess(session, 
Collections.singletonList(artifactResult)); // no NPE
+    }
+
     @Test
     public void haveMatchingChecksumPass() {
         ArtifactResult artifactResult = 
createArtifactResult(artifactWithTrustedChecksum);