This is an automated email from the ASF dual-hosted git repository. elharo pushed a commit to branch bug in repository https://gitbox.apache.org/repos/asf/maven-changes-plugin.git
commit 52a77bf4b7dc03e446922b93242a43cba3cdbd22 Author: Elliotte Rusty Harold <[email protected]> AuthorDate: Thu Feb 27 08:19:32 2025 -0500 Remove commented code --- src/main/java/org/apache/maven/plugins/changes/FeedGenerator.java | 4 +--- src/test/java/org/apache/maven/plugins/changes/FeedGeneratorTest.java | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/main/java/org/apache/maven/plugins/changes/FeedGenerator.java b/src/main/java/org/apache/maven/plugins/changes/FeedGenerator.java index fcb9816..e22e79e 100644 --- a/src/main/java/org/apache/maven/plugins/changes/FeedGenerator.java +++ b/src/main/java/org/apache/maven/plugins/changes/FeedGenerator.java @@ -144,7 +144,7 @@ public class FeedGenerator { * "rss_0.92", "rss_0.93", "rss_0.94", "rss_1.0", "rss_2.0", "atom_0.3", "atom_1.0"</code>. * * @param type the feed type to check. May be null. - * @return true if if the given type is supported by the rome library, false otherwise. + * @return true if the given type is supported by the rome library, false otherwise */ public boolean isSupportedFeedType(final String type) { return getSupportedFeedTypes().contains(type); @@ -177,8 +177,6 @@ public class FeedGenerator { feed.setLink(link); feed.setDescription(rbundle.getString("report.changes.text.rssfeed.description")); feed.setLanguage(rbundle.getLocale().getLanguage()); - // feed.setCopyright( ); - // feed.setEncoding(); feed.setEntries(getEntries(releases)); try { diff --git a/src/test/java/org/apache/maven/plugins/changes/FeedGeneratorTest.java b/src/test/java/org/apache/maven/plugins/changes/FeedGeneratorTest.java index 8dc3bee..006ed6e 100644 --- a/src/test/java/org/apache/maven/plugins/changes/FeedGeneratorTest.java +++ b/src/test/java/org/apache/maven/plugins/changes/FeedGeneratorTest.java @@ -83,9 +83,9 @@ public class FeedGeneratorTest extends TestCase { for (String type : generator.getSupportedFeedTypes()) { try (Writer writer = new StringWriter(512)) { generator.export(releases, type, writer); - String result = writer.toString(); // TODO: save for inspection? + String result = writer.toString(); assertNotNull(result); - assertTrue(result.length() > 0); + assertFalse(result.isEmpty()); } } }
