(maven-wagon) branch master updated: Use more precise asserts (#175)

[elharo]

This is an automated email from the ASF dual-hosted git repository.

elharo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-wagon.git


The following commit(s) were added to refs/heads/master by this push:
     new dab75682 Use more precise asserts (#175)
dab75682 is described below

commit dab75682786309842dcd55ef390d04c21d3cd153
Author: Elliotte Rusty Harold <elh...@users.noreply.github.com>
AuthorDate: Sat Jun 21 20:04:57 2025 +0000

    Use more precise asserts (#175)
---
 .../src/test/java/org/apache/maven/wagon/events/SessionEventTest.java  | 2 +-
 .../src/test/java/org/apache/maven/wagon/events/TransferEventTest.java | 2 +-
 .../src/main/java/org/apache/maven/wagon/WagonTestCase.java            | 2 +-
 .../src/main/java/org/apache/maven/wagon/tck/http/GetWagonTests.java   | 3 ++-
 4 files changed, 5 insertions(+), 4 deletions(-)

diff --git 
a/wagon-provider-api/src/test/java/org/apache/maven/wagon/events/SessionEventTest.java
 
b/wagon-provider-api/src/test/java/org/apache/maven/wagon/events/SessionEventTest.java
index 16c95bcf..f6738f54 100644
--- 
a/wagon-provider-api/src/test/java/org/apache/maven/wagon/events/SessionEventTest.java
+++ 
b/wagon-provider-api/src/test/java/org/apache/maven/wagon/events/SessionEventTest.java
@@ -57,7 +57,7 @@ public void testSessionEventProperties() throws 
ConnectionException, Authenticat
         assertEquals(exception, event.getException());
 
         event.setException(null);
-        assertEquals(null, event.getException());
+        assertNull(event.getException());
 
         event.setException(exception);
         assertEquals(exception, event.getException());
diff --git 
a/wagon-provider-api/src/test/java/org/apache/maven/wagon/events/TransferEventTest.java
 
b/wagon-provider-api/src/test/java/org/apache/maven/wagon/events/TransferEventTest.java
index e53cfc53..23a10389 100644
--- 
a/wagon-provider-api/src/test/java/org/apache/maven/wagon/events/TransferEventTest.java
+++ 
b/wagon-provider-api/src/test/java/org/apache/maven/wagon/events/TransferEventTest.java
@@ -79,7 +79,7 @@ public void testTransferEventProperties() throws 
ConnectionException, Authentica
 
         event.setResource(null);
 
-        assertEquals(null, event.getResource());
+        assertNull(event.getResource());
 
         res.setName("/foo/baa");
 
diff --git 
a/wagon-provider-test/src/main/java/org/apache/maven/wagon/WagonTestCase.java 
b/wagon-provider-test/src/main/java/org/apache/maven/wagon/WagonTestCase.java
index 15914220..fc99281d 100644
--- 
a/wagon-provider-test/src/main/java/org/apache/maven/wagon/WagonTestCase.java
+++ 
b/wagon-provider-test/src/main/java/org/apache/maven/wagon/WagonTestCase.java
@@ -683,7 +683,7 @@ public void testWagonGetFileList() throws Exception {
             // WAGON-250
             list = wagon.getFileList("");
             assertNotNull("file list should not be null.", list);
-            assertTrue("file list should contain items (actually contains '" + 
list + "').", !list.isEmpty());
+            assertFalse("file list should contain items (actually contains '" 
+ list + "').", list.isEmpty());
             assertTrue(list.contains("file-list/"));
             assertFalse(list.contains("file-list"));
             assertFalse(list.contains("."));
diff --git 
a/wagon-tcks/wagon-tck-http/src/main/java/org/apache/maven/wagon/tck/http/GetWagonTests.java
 
b/wagon-tcks/wagon-tck-http/src/main/java/org/apache/maven/wagon/tck/http/GetWagonTests.java
index 688c16a7..05666f05 100644
--- 
a/wagon-tcks/wagon-tck-http/src/main/java/org/apache/maven/wagon/tck/http/GetWagonTests.java
+++ 
b/wagon-tcks/wagon-tck-http/src/main/java/org/apache/maven/wagon/tck/http/GetWagonTests.java
@@ -48,6 +48,7 @@
 import static 
org.apache.maven.wagon.tck.http.Assertions.NO_RESPONSE_STATUS_CODE;
 import static 
org.apache.maven.wagon.tck.http.Assertions.assertFileContentsFromResource;
 import static 
org.apache.maven.wagon.tck.http.Assertions.assertWagonExceptionMessage;
+import static org.junit.Assert.assertNotNull;
 
 /**
  *
@@ -155,7 +156,7 @@ public void run() {
         logger.info("Interrupting thread.");
         t.interrupt();
 
-        assertTrue("TransferFailedException should have been thrown.", 
holder.getValue() != null);
+        assertNotNull("TransferFailedException should have been thrown.", 
holder.getValue());
         assertWagonExceptionMessage(holder.getValue(), 
NO_RESPONSE_STATUS_CODE, getBaseUrl() + "infinite/", "", null);
     }