This is an automated email from the ASF dual-hosted git repository.

slachiewicz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-site-plugin.git


The following commit(s) were added to refs/heads/master by this push:
     new 3c244877 Check where the edit link points, not the skin's icon markup
3c244877 is described below

commit 3c244877e9be6123026bb39fa5ebfe672d37ce5e
Author: Sylwester Lachiewicz <[email protected]>
AuthorDate: Sun Nov 1 10:41:05 2026 +0000

    Check where the edit link points, not the skin's icon markup
---
 src/it/projects/editable-pages-alt-source/verify.groovy | 5 +++--
 src/it/projects/editable-pages/verify.groovy            | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/it/projects/editable-pages-alt-source/verify.groovy 
b/src/it/projects/editable-pages-alt-source/verify.groovy
index 62a8a757..ff41fb15 100644
--- a/src/it/projects/editable-pages-alt-source/verify.groovy
+++ b/src/it/projects/editable-pages-alt-source/verify.groovy
@@ -22,7 +22,8 @@ def page = new File( basedir, 'target/site/markdown.html' )
 assert page.exists() : "$page must have been generated"
 def content = page.text
 
-assert content.contains( '<a 
href="https://github.com/apache/maven-site-plugin/tree/master/src/site/markdown/markdown.md";><img
 src="./images/accessories-text-editor.png" alt="Edit" /></a>' ) : 'Found 
invalid edit link'
+// the skin decides how the edit link looks (an icon, a text link); check 
where it points
+assert content.contains( '<a 
href="https://github.com/apache/maven-site-plugin/tree/master/src/site/markdown/markdown.md";'
 ) : 'Found invalid edit link'
 assert content.contains( '<h1>Markdown myValue</h1>' ) : 'Found invalid 
headline'
 
 
@@ -30,4 +31,4 @@ page = new File( basedir, 'target/site/index.html' )
 assert page.exists() : "$page must have been generated"
 content = page.text
 
-assert !content.contains( '<img src="./images/accessories-text-editor.png" 
alt="Edit" />' ) : 'Found edit link for report that should not have it'
+assert !content.contains( 
'https://github.com/apache/maven-site-plugin/tree/master/src/site/' ) : 'Found 
edit link for report that should not have it'
diff --git a/src/it/projects/editable-pages/verify.groovy 
b/src/it/projects/editable-pages/verify.groovy
index 9c360124..bc6bb995 100644
--- a/src/it/projects/editable-pages/verify.groovy
+++ b/src/it/projects/editable-pages/verify.groovy
@@ -22,7 +22,8 @@ def page = new File( basedir, 'target/site/markdown.html' )
 assert page.exists() : "$page must have been generated"
 def content = page.text
 
-assert content.contains( '<a 
href="https://github.com/apache/maven-site-plugin/tree/master/src/site/markdown/markdown.md";><img
 src="./images/accessories-text-editor.png" alt="Edit" /></a>' ) : 'Found 
invalid edit link'
+// the skin decides how the edit link looks (an icon, a text link); check 
where it points
+assert content.contains( '<a 
href="https://github.com/apache/maven-site-plugin/tree/master/src/site/markdown/markdown.md";'
 ) : 'Found invalid edit link'
 assert content.contains( '<h1>Markdown Test</h1>' ) : 'Found invalid headline'
 
 
@@ -30,4 +31,4 @@ page = new File( basedir, 'target/site/index.html' )
 assert page.exists() : "$page must have been generated"
 content = page.text
 
-assert !content.contains( '<img src="./images/accessories-text-editor.png" 
alt="Edit" />' ) : 'Found edit link for report that should not have it'
+assert !content.contains( 
'https://github.com/apache/maven-site-plugin/tree/master/src/site/' ) : 'Found 
edit link for report that should not have it'

Reply via email to