This is an automated email from the ASF dual-hosted git repository.

gnodet pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven.git


The following commit(s) were added to refs/heads/master by this push:
     new 443612d0a0 test: close URLClassLoader instances in 
DefaultExtensibleEnumRegistryTest (#13859)
443612d0a0 is described below

commit 443612d0a07f4a74d3d5beecac39ac251f3f69fc
Author: Guillaume Nodet <[email protected]>
AuthorDate: Fri Nov 6 00:48:40 2026 +0100

    test: close URLClassLoader instances in DefaultExtensibleEnumRegistryTest 
(#13859)
    
    Four isVisibleFrom tests created URLClassLoader instances without
    closing them. The backport PR #13853 (maven-4.0.x) correctly used
    try-with-resources; apply the same fix to master.
    
    Spotted during review of #13853.
---
 .../impl/DefaultExtensibleEnumRegistryTest.java    | 30 ++++++++++++----------
 1 file changed, 17 insertions(+), 13 deletions(-)

diff --git 
a/impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultExtensibleEnumRegistryTest.java
 
b/impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultExtensibleEnumRegistryTest.java
index b161b7c958..4e2bd23bfc 100644
--- 
a/impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultExtensibleEnumRegistryTest.java
+++ 
b/impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultExtensibleEnumRegistryTest.java
@@ -120,34 +120,38 @@ void visibleFromSameClassLoaderReturnsTrue() {
     }
 
     @Test
-    void visibleFromChildOfParentClassLoaderReturnsTrue() {
+    void visibleFromChildOfParentClassLoaderReturnsTrue() throws Exception {
         TestProvider provider = () -> List.of(CUSTOM);
         ClassLoader parent = provider.getClass().getClassLoader();
-        ClassLoader child = new URLClassLoader(new URL[0], parent);
-        assertTrue(ExtensibleEnumRegistries.isVisibleFrom(provider, child));
+        try (URLClassLoader child = new URLClassLoader(new URL[0], parent)) {
+            assertTrue(ExtensibleEnumRegistries.isVisibleFrom(provider, 
child));
+        }
     }
 
     @Test
-    void notVisibleFromUnrelatedClassLoader() {
+    void notVisibleFromUnrelatedClassLoader() throws Exception {
         TestProvider provider = () -> List.of(CUSTOM);
-        ClassLoader unrelated = new URLClassLoader(new URL[0], null);
-        assertFalse(ExtensibleEnumRegistries.isVisibleFrom(provider, 
unrelated));
+        try (URLClassLoader unrelated = new URLClassLoader(new URL[0], null)) {
+            assertFalse(ExtensibleEnumRegistries.isVisibleFrom(provider, 
unrelated));
+        }
     }
 
     @Test
-    void visibleFromClassRealmThatImportsProviderRealm() {
+    void visibleFromClassRealmThatImportsProviderRealm() throws Exception {
         TestProvider provider = () -> List.of(CUSTOM);
         ClassLoader providerCl = provider.getClass().getClassLoader();
-        FakeClassRealm realm = new FakeClassRealm(Set.of(providerCl));
-        assertTrue(ExtensibleEnumRegistries.isVisibleFrom(provider, realm));
+        try (FakeClassRealm realm = new FakeClassRealm(Set.of(providerCl))) {
+            assertTrue(ExtensibleEnumRegistries.isVisibleFrom(provider, 
realm));
+        }
     }
 
     @Test
-    void notVisibleFromClassRealmWithoutMatchingImport() {
+    void notVisibleFromClassRealmWithoutMatchingImport() throws Exception {
         TestProvider provider = () -> List.of(CUSTOM);
-        ClassLoader otherCl = new URLClassLoader(new URL[0], null);
-        FakeClassRealm realm = new FakeClassRealm(Set.of(otherCl));
-        assertFalse(ExtensibleEnumRegistries.isVisibleFrom(provider, realm));
+        try (URLClassLoader otherCl = new URLClassLoader(new URL[0], null);
+                FakeClassRealm realm = new FakeClassRealm(Set.of(otherCl))) {
+            assertFalse(ExtensibleEnumRegistries.isVisibleFrom(provider, 
realm));
+        }
     }
 
     record TestValue(String id) implements ExtensibleEnum {}

Reply via email to