This is an automated email from the ASF dual-hosted git repository.

gnodet pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven.git


The following commit(s) were added to refs/heads/master by this push:
     new 3310954467 Add noun-style snapshot accessor to Artifact (#13954)
3310954467 is described below

commit 331095446712f8c2ae1ffa699a0740be15763e38
Author: codewithsinchana <[email protected]>
AuthorDate: Fri Nov 13 05:43:00 2026 +0530

    Add noun-style snapshot accessor to Artifact (#13954)
    
    * Add noun-style snapshot accessor to Artifact
    
    * Fix missing closing brace in Artifact interface
    
    * Address review: restore toCoordinates(), fix snapshot() Javadoc, fix 
indentation
    
    * fix: remove trailing blank line from Artifact.java (Spotless)
    
    * Address review: rename isSnapshot() to snapshot() in concrete Artifact 
implementations
    
    The interface declares snapshot() as an abstract method, so all concrete
    implementations must override it. The deprecated isSnapshot() default
    in the interface delegates to snapshot() automatically.
    
    - DefaultArtifact: rename isSnapshot() override to snapshot()
    - SpiWorkspaceReaderAdapter.LightweightApiArtifact: rename and delegate to 
artifact.snapshot()
    - ArtifactStub: rename isSnapshot() override to snapshot()
    
    * fix: resolve remaining compilation blockers in snapshot() accessor 
migration
    
    - DefaultDependency: rename isSnapshot() to snapshot() to implement the
      new abstract Artifact.snapshot() method (Dependency extends Artifact)
    - SpiWorkspaceReaderAdapter.LightweightApiArtifact: delegate snapshot()
      to artifact.isSnapshot() — the wrapped type is 
org.eclipse.aether.artifact.Artifact
      (resolver API) which only declares isSnapshot(), not snapshot()
    
    ---------
    
    Co-authored-by: codewithsinchana <[email protected]>
    Co-authored-by: Guillaume Nodet <[email protected]>
---
 .../src/main/java/org/apache/maven/api/Artifact.java      | 15 ++++++++++++++-
 .../apache/maven/resolver/SpiWorkspaceReaderAdapter.java  |  2 +-
 .../main/java/org/apache/maven/impl/DefaultArtifact.java  |  2 +-
 .../java/org/apache/maven/impl/DefaultDependency.java     |  2 +-
 .../apache/maven/testing/plugin/stubs/ArtifactStub.java   |  2 +-
 5 files changed, 18 insertions(+), 5 deletions(-)

diff --git 
a/api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java 
b/api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java
index 3c311a2c74..603761f326 100644
--- a/api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java
+++ b/api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java
@@ -187,13 +187,26 @@ default String getExtension() {
         return extension();
     }
 
+    /**
+     * Returns whether this artifact is a snapshot.
+     *
+     * @return {@code true} if the artifact is a snapshot, {@code false} 
otherwise
+     * @see org.apache.maven.api.Session#isVersionSnapshot(String)
+     * @since 4.2.0
+     */
+    boolean snapshot();
+
     /**
      * Determines whether this artifact uses a snapshot version.
      *
      * @return {@code true} if the artifact is a snapshot, {@code false} 
otherwise
      * @see org.apache.maven.api.Session#isVersionSnapshot(String)
+     * @deprecated Use {@link #snapshot()} instead.
      */
-    boolean isSnapshot();
+    @Deprecated(since = "4.2.0", forRemoval = true)
+    default boolean isSnapshot() {
+        return snapshot();
+    }
 
     /**
      * {@return coordinates with the same identifiers as this artifact}.
diff --git 
a/impl/maven-core/src/main/java/org/apache/maven/resolver/SpiWorkspaceReaderAdapter.java
 
b/impl/maven-core/src/main/java/org/apache/maven/resolver/SpiWorkspaceReaderAdapter.java
index 7a12a7dee3..1229c5b2b3 100644
--- 
a/impl/maven-core/src/main/java/org/apache/maven/resolver/SpiWorkspaceReaderAdapter.java
+++ 
b/impl/maven-core/src/main/java/org/apache/maven/resolver/SpiWorkspaceReaderAdapter.java
@@ -153,7 +153,7 @@ public String classifier() {
         }
 
         @Override
-        public boolean isSnapshot() {
+        public boolean snapshot() {
             return artifact.isSnapshot();
         }
 
diff --git 
a/impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultArtifact.java 
b/impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultArtifact.java
index f3cffe7a50..e94d43b874 100644
--- a/impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultArtifact.java
+++ b/impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultArtifact.java
@@ -93,7 +93,7 @@ public String classifier() {
     }
 
     @Override
-    public boolean isSnapshot() {
+    public boolean snapshot() {
         return DefaultModelVersionParser.checkSnapshot(artifact.getVersion());
     }
 
diff --git 
a/impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependency.java 
b/impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependency.java
index 82fcacfe93..eebddaeaa8 100644
--- a/impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependency.java
+++ b/impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependency.java
@@ -59,7 +59,7 @@ public Version baseVersion() {
     }
 
     @Override
-    public boolean isSnapshot() {
+    public boolean snapshot() {
         return 
DefaultModelVersionParser.checkSnapshot(dependency.getArtifact().getVersion());
     }
 
diff --git 
a/impl/maven-testing/src/main/java/org/apache/maven/testing/plugin/stubs/ArtifactStub.java
 
b/impl/maven-testing/src/main/java/org/apache/maven/testing/plugin/stubs/ArtifactStub.java
index 20be8feeea..9eb85c92b3 100644
--- 
a/impl/maven-testing/src/main/java/org/apache/maven/testing/plugin/stubs/ArtifactStub.java
+++ 
b/impl/maven-testing/src/main/java/org/apache/maven/testing/plugin/stubs/ArtifactStub.java
@@ -119,7 +119,7 @@ public void setExtension(String extension) {
     }
 
     @Override
-    public boolean isSnapshot() {
+    public boolean snapshot() {
         return false;
     }
 

Reply via email to