This is an automated email from the ASF dual-hosted git repository.

slachiewicz pushed a commit to branch master
in repository 
https://gitbox.apache.org/repos/asf/maven-common-artifact-filters.git


The following commit(s) were added to refs/heads/master by this push:
     new 5b7d2f7  Apply OpenRewrite static analysis cleanups
5b7d2f7 is described below

commit 5b7d2f7789470ddf7fa78d75dfc2ac647eddea15
Author: Sylwester Lachiewicz <[email protected]>
AuthorDate: Mon Nov 16 14:49:22 2026 +0000

    Apply OpenRewrite static analysis cleanups
---
 .../artifact/filter/PatternIncludesArtifactFilter.java       | 12 ++++++------
 .../filter/collection/AbstractArtifactFeatureFilter.java     |  2 +-
 .../maven/shared/artifact/filter/resolve/ScopeFilter.java    |  4 ++--
 .../artifact/filter/GNPatternIncludesArtifactFilter.java     |  4 ++--
 4 files changed, 11 insertions(+), 11 deletions(-)

diff --git 
a/src/main/java/org/apache/maven/shared/artifact/filter/PatternIncludesArtifactFilter.java
 
b/src/main/java/org/apache/maven/shared/artifact/filter/PatternIncludesArtifactFilter.java
index e51f462..68415a0 100644
--- 
a/src/main/java/org/apache/maven/shared/artifact/filter/PatternIncludesArtifactFilter.java
+++ 
b/src/main/java/org/apache/maven/shared/artifact/filter/PatternIncludesArtifactFilter.java
@@ -429,7 +429,7 @@ public class PatternIncludesArtifactFilter implements 
ArtifactFilter, Statistics
         }
     }
 
-    private static class AndPattern extends Pattern {
+    private static final class AndPattern extends Pattern {
         private final Pattern[] patterns;
 
         private AndPattern(String pattern, Pattern[] patterns) {
@@ -448,7 +448,7 @@ public class PatternIncludesArtifactFilter implements 
ArtifactFilter, Statistics
         }
     }
 
-    private static class CoordinateMatchingPattern extends Pattern {
+    private static final class CoordinateMatchingPattern extends Pattern {
         private final String token;
 
         private final EnumSet<Coordinate> coordinates;
@@ -503,7 +503,7 @@ public class PatternIncludesArtifactFilter implements 
ArtifactFilter, Statistics
     /**
      * Matches all input
      */
-    private static class MatchAllPattern extends Pattern {
+    private static final class MatchAllPattern extends Pattern {
         private MatchAllPattern(String pattern) {
             super(pattern);
         }
@@ -517,7 +517,7 @@ public class PatternIncludesArtifactFilter implements 
ArtifactFilter, Statistics
     /**
      * Negative pattern
      */
-    private static class NegativePattern extends Pattern {
+    private static final class NegativePattern extends Pattern {
         private final Pattern inner;
 
         private NegativePattern(String pattern, Pattern inner) {
@@ -616,8 +616,8 @@ public class PatternIncludesArtifactFilter implements 
ArtifactFilter, Statistics
             }
             // Find the pattern between padIdxStart & padIdxTmp in str between
             // strIdxStart & strIdxEnd
-            int patLength = (patIdxTmp - patIdxStart - 1);
-            int strLength = (strIdxEnd - strIdxStart + 1);
+            int patLength = patIdxTmp - patIdxStart - 1;
+            int strLength = strIdxEnd - strIdxStart + 1;
             int foundIdx = -1;
             strLoop:
             for (int i = 0; i <= strLength - patLength; i++) {
diff --git 
a/src/main/java/org/apache/maven/shared/artifact/filter/collection/AbstractArtifactFeatureFilter.java
 
b/src/main/java/org/apache/maven/shared/artifact/filter/collection/AbstractArtifactFeatureFilter.java
index 8709876..d5abfad 100644
--- 
a/src/main/java/org/apache/maven/shared/artifact/filter/collection/AbstractArtifactFeatureFilter.java
+++ 
b/src/main/java/org/apache/maven/shared/artifact/filter/collection/AbstractArtifactFeatureFilter.java
@@ -184,6 +184,6 @@ public abstract class AbstractArtifactFeatureFilter extends 
AbstractArtifactsFil
      * @return boolean true if features match
      */
     protected boolean compareFeatures(String lhs, String rhs) {
-        return (Objects.equals(lhs, rhs));
+        return Objects.equals(lhs, rhs);
     }
 }
diff --git 
a/src/main/java/org/apache/maven/shared/artifact/filter/resolve/ScopeFilter.java
 
b/src/main/java/org/apache/maven/shared/artifact/filter/resolve/ScopeFilter.java
index e408190..102f10b 100644
--- 
a/src/main/java/org/apache/maven/shared/artifact/filter/resolve/ScopeFilter.java
+++ 
b/src/main/java/org/apache/maven/shared/artifact/filter/resolve/ScopeFilter.java
@@ -41,8 +41,8 @@ public class ScopeFilter implements TransformableFilter {
      * @param excluded specific scopes to exclude or {@code null} to exclude 
none
      */
     public ScopeFilter(Collection<String> included, Collection<String> 
excluded) {
-        this.included = (included == null ? null : 
Collections.unmodifiableCollection(included));
-        this.excluded = (excluded == null ? null : 
Collections.unmodifiableCollection(excluded));
+        this.included = included == null ? null : 
Collections.unmodifiableCollection(included);
+        this.excluded = excluded == null ? null : 
Collections.unmodifiableCollection(excluded);
     }
 
     /**
diff --git 
a/src/test/java/org/apache/maven/shared/artifact/filter/GNPatternIncludesArtifactFilter.java
 
b/src/test/java/org/apache/maven/shared/artifact/filter/GNPatternIncludesArtifactFilter.java
index 9e28968..c3014ce 100644
--- 
a/src/test/java/org/apache/maven/shared/artifact/filter/GNPatternIncludesArtifactFilter.java
+++ 
b/src/test/java/org/apache/maven/shared/artifact/filter/GNPatternIncludesArtifactFilter.java
@@ -347,8 +347,8 @@ public class GNPatternIncludesArtifactFilter implements 
ArtifactFilter, Statisti
             }
             // Find the pattern between padIdxStart & padIdxTmp in str between
             // strIdxStart & strIdxEnd
-            int patLength = (patIdxTmp - patIdxStart - 1);
-            int strLength = (strIdxEnd - strIdxStart + 1);
+            int patLength = patIdxTmp - patIdxStart - 1;
+            int strLength = strIdxEnd - strIdxStart + 1;
             int foundIdx = -1;
             strLoop:
             for (int i = 0; i <= strLength - patLength; i++) {

Reply via email to