This is an automated email from the ASF dual-hosted git repository. slachiewicz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/maven-scripting-plugin.git
commit e7b65666450d349b1bf718e5a66a9b6e2cb4b09c Author: Sylwester Lachiewicz <[email protected]> AuthorDate: Tue Nov 17 07:59:46 2026 +0000 Use System.lineSeparator(), @Override and try-with-resources --- .../java/org/apache/maven/plugins/scripting/FileScriptEvaluator.java | 2 ++ .../org/apache/maven/plugins/scripting/ResourceScriptEvaluator.java | 2 ++ .../java/org/apache/maven/plugins/scripting/StringScriptEvaluator.java | 2 ++ 3 files changed, 6 insertions(+) diff --git a/src/main/java/org/apache/maven/plugins/scripting/FileScriptEvaluator.java b/src/main/java/org/apache/maven/plugins/scripting/FileScriptEvaluator.java index f48c2a8..489560d 100644 --- a/src/main/java/org/apache/maven/plugins/scripting/FileScriptEvaluator.java +++ b/src/main/java/org/apache/maven/plugins/scripting/FileScriptEvaluator.java @@ -63,6 +63,7 @@ public class FileScriptEvaluator extends AbstractScriptEvaluator { * @throws ScriptException if an error occurs in script * @see org.apache.maven.plugins.scripting.AbstractScriptEvaluator#eval(javax.script.ScriptEngine, javax.script.ScriptContext) */ + @Override protected Object eval(ScriptEngine engine, ScriptContext context) throws ScriptException { try (FileReader reader = new FileReader(scriptFile)) { return engine.eval(reader, context); @@ -78,6 +79,7 @@ public class FileScriptEvaluator extends AbstractScriptEvaluator { * @throws UnsupportedScriptEngineException if specified engine is not available * @see org.apache.maven.plugins.scripting.AbstractScriptEvaluator#getEngine(javax.script.ScriptEngineManager) */ + @Override protected ScriptEngine getEngine(ScriptEngineManager manager) throws UnsupportedScriptEngineException { ScriptEngine result; diff --git a/src/main/java/org/apache/maven/plugins/scripting/ResourceScriptEvaluator.java b/src/main/java/org/apache/maven/plugins/scripting/ResourceScriptEvaluator.java index 8db4eb6..3f2e76b 100644 --- a/src/main/java/org/apache/maven/plugins/scripting/ResourceScriptEvaluator.java +++ b/src/main/java/org/apache/maven/plugins/scripting/ResourceScriptEvaluator.java @@ -64,6 +64,7 @@ public class ResourceScriptEvaluator extends AbstractScriptEvaluator { * @throws ScriptException if an error occurs in script * @see org.apache.maven.plugins.scripting.AbstractScriptEvaluator#eval(javax.script.ScriptEngine, javax.script.ScriptContext) */ + @Override protected Object eval(ScriptEngine engine, ScriptContext context) throws ScriptException { try (InputStream is = this.getClass().getClassLoader().getResourceAsStream(resourceName); @@ -81,6 +82,7 @@ public class ResourceScriptEvaluator extends AbstractScriptEvaluator { * @throws UnsupportedScriptEngineException if specified engine is not available * @see org.apache.maven.plugins.scripting.AbstractScriptEvaluator#getEngine(javax.script.ScriptEngineManager) */ + @Override protected ScriptEngine getEngine(ScriptEngineManager manager) throws UnsupportedScriptEngineException { ScriptEngine result; diff --git a/src/main/java/org/apache/maven/plugins/scripting/StringScriptEvaluator.java b/src/main/java/org/apache/maven/plugins/scripting/StringScriptEvaluator.java index 2f26c87..6e48564 100644 --- a/src/main/java/org/apache/maven/plugins/scripting/StringScriptEvaluator.java +++ b/src/main/java/org/apache/maven/plugins/scripting/StringScriptEvaluator.java @@ -62,6 +62,7 @@ public class StringScriptEvaluator extends AbstractScriptEvaluator { * @throws UnsupportedScriptEngineException if the engineName is not supported * @see org.apache.maven.plugins.scripting.AbstractScriptEvaluator#getEngine(javax.script.ScriptEngineManager) */ + @Override protected ScriptEngine getEngine(ScriptEngineManager manager) throws UnsupportedScriptEngineException { ScriptEngine result = manager.getEngineByName(engineName); @@ -77,6 +78,7 @@ public class StringScriptEvaluator extends AbstractScriptEvaluator { * @throws ScriptException if an error occurs in script * @see org.apache.maven.plugins.scripting.AbstractScriptEvaluator#eval(javax.script.ScriptEngine, javax.script.ScriptContext) */ + @Override protected Object eval(ScriptEngine engine, ScriptContext context) throws ScriptException { return engine.eval(script, context); }
