This is an automated email from the ASF dual-hosted git repository. slachiewicz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/maven-changes-plugin.git
commit 04b90f1fdc319ecd84563ae7dbcec81562c14b6a Author: Sylwester Lachiewicz <[email protected]> AuthorDate: Tue Nov 17 05:39:54 2026 +0000 Use System.lineSeparator(), @Override and try-with-resources --- src/main/java/org/apache/maven/plugins/changes/ChangesCheckMojo.java | 1 + .../java/org/apache/maven/plugins/changes/ChangesValidatorMojo.java | 1 + .../maven/plugins/changes/announcement/AnnouncementMailMojo.java | 1 + .../apache/maven/plugins/changes/announcement/AnnouncementMojo.java | 1 + .../org/apache/maven/plugins/changes/announcement/MailSender.java | 1 + .../maven/plugins/changes/issues/AbstractIssueManagementSystem.java | 3 +++ src/main/java/org/apache/maven/plugins/changes/issues/Issue.java | 1 + .../maven/plugins/changes/schema/DefaultChangesSchemaValidator.java | 1 + .../org/apache/maven/plugins/changes/schema/XmlValidationHandler.java | 4 ++++ 9 files changed, 14 insertions(+) diff --git a/src/main/java/org/apache/maven/plugins/changes/ChangesCheckMojo.java b/src/main/java/org/apache/maven/plugins/changes/ChangesCheckMojo.java index c66aaee..5ce157a 100644 --- a/src/main/java/org/apache/maven/plugins/changes/ChangesCheckMojo.java +++ b/src/main/java/org/apache/maven/plugins/changes/ChangesCheckMojo.java @@ -77,6 +77,7 @@ public class ChangesCheckMojo extends AbstractChangesMojo { * * @throws MojoExecutionException in case of errors. */ + @Override public void execute() throws MojoExecutionException { // Run only at the execution root if (runOnlyAtExecutionRoot && !isThisTheExecutionRoot()) { diff --git a/src/main/java/org/apache/maven/plugins/changes/ChangesValidatorMojo.java b/src/main/java/org/apache/maven/plugins/changes/ChangesValidatorMojo.java index df448f0..abb1747 100644 --- a/src/main/java/org/apache/maven/plugins/changes/ChangesValidatorMojo.java +++ b/src/main/java/org/apache/maven/plugins/changes/ChangesValidatorMojo.java @@ -69,6 +69,7 @@ public class ChangesValidatorMojo extends AbstractChangesMojo { /** * @see org.apache.maven.plugin.Mojo#execute() */ + @Override public void execute() throws MojoExecutionException { // Run only at the execution root if (runOnlyAtExecutionRoot && !isThisTheExecutionRoot()) { diff --git a/src/main/java/org/apache/maven/plugins/changes/announcement/AnnouncementMailMojo.java b/src/main/java/org/apache/maven/plugins/changes/announcement/AnnouncementMailMojo.java index 7a46a64..23db420 100644 --- a/src/main/java/org/apache/maven/plugins/changes/announcement/AnnouncementMailMojo.java +++ b/src/main/java/org/apache/maven/plugins/changes/announcement/AnnouncementMailMojo.java @@ -218,6 +218,7 @@ public class AnnouncementMailMojo extends AbstractAnnouncementMojo { private ProjectJavamailMailSender mailer = new ProjectJavamailMailSender(); + @Override public void execute() throws MojoExecutionException { // Run only at the execution root diff --git a/src/main/java/org/apache/maven/plugins/changes/announcement/AnnouncementMojo.java b/src/main/java/org/apache/maven/plugins/changes/announcement/AnnouncementMojo.java index 6360d47..4a058f6 100644 --- a/src/main/java/org/apache/maven/plugins/changes/announcement/AnnouncementMojo.java +++ b/src/main/java/org/apache/maven/plugins/changes/announcement/AnnouncementMojo.java @@ -438,6 +438,7 @@ public class AnnouncementMojo extends AbstractAnnouncementMojo { * * @throws MojoExecutionException in case of errors */ + @Override public void execute() throws MojoExecutionException { // Run only at the execution root if (runOnlyAtExecutionRoot && !isThisTheExecutionRoot()) { diff --git a/src/main/java/org/apache/maven/plugins/changes/announcement/MailSender.java b/src/main/java/org/apache/maven/plugins/changes/announcement/MailSender.java index 470ada7..c3119fa 100644 --- a/src/main/java/org/apache/maven/plugins/changes/announcement/MailSender.java +++ b/src/main/java/org/apache/maven/plugins/changes/announcement/MailSender.java @@ -55,6 +55,7 @@ public class MailSender { this.email = email; } + @Override public String toString() { return getName() + " (" + getEmail() + ")"; } diff --git a/src/main/java/org/apache/maven/plugins/changes/issues/AbstractIssueManagementSystem.java b/src/main/java/org/apache/maven/plugins/changes/issues/AbstractIssueManagementSystem.java index 1d79610..6b735fa 100644 --- a/src/main/java/org/apache/maven/plugins/changes/issues/AbstractIssueManagementSystem.java +++ b/src/main/java/org/apache/maven/plugins/changes/issues/AbstractIssueManagementSystem.java @@ -46,6 +46,7 @@ public abstract class AbstractIssueManagementSystem implements IssueManagementSy * (non-Javadoc) * @see org.apache.maven.plugins.issues.IssueManagementSystem#getIssueTypeMap() */ + @Override public Map<String, IssueType> getIssueTypeMap() { return issueTypeMap; } @@ -54,12 +55,14 @@ public abstract class AbstractIssueManagementSystem implements IssueManagementSy * (non-Javadoc) * @see org.apache.maven.plugins.issues.IssueManagementSystem#getName() */ + @Override public abstract String getName(); /* * (non-Javadoc) * @see org.apache.maven.plugins.issues.IssueManagementSystem#applyConfiguration(java.util.Map) */ + @Override public void applyConfiguration(Map<String, String> issueTypes) throws MojoExecutionException { for (Map.Entry<String, String> me : issueTypes.entrySet()) { IssueType type = IssueType.lookupByKey(me.getKey()); diff --git a/src/main/java/org/apache/maven/plugins/changes/issues/Issue.java b/src/main/java/org/apache/maven/plugins/changes/issues/Issue.java index 5f2e6d1..ab1918a 100644 --- a/src/main/java/org/apache/maven/plugins/changes/issues/Issue.java +++ b/src/main/java/org/apache/maven/plugins/changes/issues/Issue.java @@ -216,6 +216,7 @@ public class Issue { this.version = version; } + @Override public String toString() { return this.getClass().getSimpleName() + "[id='" + this.getId() + "'" + ", summary='" + this.getSummary() + "'" + ", fixVersions='" + this.getFixVersions() + "'" + "]"; diff --git a/src/main/java/org/apache/maven/plugins/changes/schema/DefaultChangesSchemaValidator.java b/src/main/java/org/apache/maven/plugins/changes/schema/DefaultChangesSchemaValidator.java index 4e821ce..51846b0 100644 --- a/src/main/java/org/apache/maven/plugins/changes/schema/DefaultChangesSchemaValidator.java +++ b/src/main/java/org/apache/maven/plugins/changes/schema/DefaultChangesSchemaValidator.java @@ -51,6 +51,7 @@ public class DefaultChangesSchemaValidator implements ChangesSchemaValidator { private Map<String, Schema> compiledSchemas = new HashMap<>(); + @Override public XmlValidationHandler validateXmlWithSchema(File file, String schemaVersion, boolean failOnValidationError) throws SchemaValidatorException { try { diff --git a/src/main/java/org/apache/maven/plugins/changes/schema/XmlValidationHandler.java b/src/main/java/org/apache/maven/plugins/changes/schema/XmlValidationHandler.java index 40bb18d..81dc076 100644 --- a/src/main/java/org/apache/maven/plugins/changes/schema/XmlValidationHandler.java +++ b/src/main/java/org/apache/maven/plugins/changes/schema/XmlValidationHandler.java @@ -53,6 +53,7 @@ public class XmlValidationHandler extends DefaultHandler { /** * @see org.xml.sax.ErrorHandler#error(org.xml.sax.SAXParseException) */ + @Override public void error(SAXParseException excp) throws SAXException { this.setErrorParsing(true); this.errors.add(excp); @@ -64,6 +65,7 @@ public class XmlValidationHandler extends DefaultHandler { /** * @see org.xml.sax.ErrorHandler#fatalError(org.xml.sax.SAXParseException) */ + @Override public void fatalError(SAXParseException excp) throws SAXException { this.fatalErrors.add(excp); if (this.failOnValidationError) { @@ -74,6 +76,7 @@ public class XmlValidationHandler extends DefaultHandler { /** * @see org.xml.sax.ErrorHandler#warning(org.xml.sax.SAXParseException) */ + @Override public void warning(SAXParseException excp) { this.warnings.add(excp); } @@ -81,6 +84,7 @@ public class XmlValidationHandler extends DefaultHandler { /** * @see org.xml.sax.ContentHandler#startElement(String, String, String, Attributes) */ + @Override public void startElement(String uri, String localName, String qName, Attributes attributes) { // nothing }
