This is an automated email from the ASF dual-hosted git repository. slachiewicz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/maven-jmod-plugin.git
commit ae7db2c6944703bd6e74a26a3660585ec7d04981 Author: Sylwester Lachiewicz <[email protected]> AuthorDate: Tue Nov 17 06:58:08 2026 +0000 Simplify redundant code --- src/main/java/org/apache/maven/plugins/jmod/AbstractJModMojo.java | 6 +++--- src/main/java/org/apache/maven/plugins/jmod/JModCreateMojo.java | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/main/java/org/apache/maven/plugins/jmod/AbstractJModMojo.java b/src/main/java/org/apache/maven/plugins/jmod/AbstractJModMojo.java index b23c3e6..6b44699 100644 --- a/src/main/java/org/apache/maven/plugins/jmod/AbstractJModMojo.java +++ b/src/main/java/org/apache/maven/plugins/jmod/AbstractJModMojo.java @@ -150,9 +150,9 @@ public abstract class AbstractJModMojo extends AbstractMojo { try { int exitCode = CommandLineUtils.executeCommandLine(cmd, out, err); - String output = (StringUtils.isBlank(out.getOutput()) + String output = StringUtils.isBlank(out.getOutput()) ? null - : '\n' + out.getOutput().trim()); + : '\n' + out.getOutput().trim(); if (exitCode != 0) { if (StringUtils.isNotEmpty(output)) { @@ -205,7 +205,7 @@ public abstract class AbstractJModMojo extends AbstractMojo { if (jdkToolchain != null) { List<Toolchain> tcs = toolchainManager.getToolchains(session, "jdk", jdkToolchain); - if (tcs != null && tcs.size() > 0) { + if (tcs != null && !tcs.isEmpty()) { tc = tcs.get(0); } } diff --git a/src/main/java/org/apache/maven/plugins/jmod/JModCreateMojo.java b/src/main/java/org/apache/maven/plugins/jmod/JModCreateMojo.java index 73cd605..d772ce1 100644 --- a/src/main/java/org/apache/maven/plugins/jmod/JModCreateMojo.java +++ b/src/main/java/org/apache/maven/plugins/jmod/JModCreateMojo.java @@ -385,7 +385,7 @@ public class JModCreateMojo extends AbstractJModMojo { } private List<File> getCompileClasspathElements(MavenProject project) { - List<File> list = new ArrayList<File>(project.getArtifacts().size() + 1); + List<File> list = new ArrayList<>(project.getArtifacts().size() + 1); if (targetClassesDirectory.exists()) { list.add(new File(project.getBuild().getOutputDirectory())); @@ -426,7 +426,7 @@ public class JModCreateMojo extends AbstractJModMojo { ResolvePathsRequest.ofFiles(dependencyArtifacts).setMainModuleDescriptor(moduleInfo); Toolchain toolchain = getToolchain(); - if (toolchain != null && toolchain instanceof JavaToolchainImpl) { + if (toolchain instanceof JavaToolchainImpl) { request.setJdkHome(new File(((JavaToolchainImpl) toolchain).getJavaHome())); } @@ -477,7 +477,7 @@ public class JModCreateMojo extends AbstractJModMojo { } else { modulepathElements = Collections.emptyList(); - classpathElements = new ArrayList<String>(); + classpathElements = new ArrayList<>(); for (File file : dependencyArtifacts) { classpathElements.add(file.getPath()); } @@ -589,7 +589,7 @@ public class JModCreateMojo extends AbstractJModMojo { } private List<String> handleConfigurationListWithDefault(List<String> configuration, String defaultLocation) { - List<String> commands = new ArrayList<String>(); + List<String> commands = new ArrayList<>(); if (isConfigurationDefinedInPOM(configuration)) { commands.addAll(configuration); } else {
