This is an automated email from the ASF dual-hosted git repository.
slachiewicz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-scm.git
The following commit(s) were added to refs/heads/master by this push:
new bb66423e0 Simplify ChangeSet assertions
bb66423e0 is described below
commit bb66423e0ebb2583965146ddd0cef2f478b13887
Author: Sylwester Lachiewicz <[email protected]>
AuthorDate: Thu Nov 19 01:17:14 2026 +0100
Simplify ChangeSet assertions
---
.../java/org/apache/maven/scm/ChangeSetTest.java | 21 ++++++++++++---------
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git
a/maven-scm-api/src/test/java/org/apache/maven/scm/ChangeSetTest.java
b/maven-scm-api/src/test/java/org/apache/maven/scm/ChangeSetTest.java
index f2676bf03..da2bfe28a 100644
--- a/maven-scm-api/src/test/java/org/apache/maven/scm/ChangeSetTest.java
+++ b/maven-scm-api/src/test/java/org/apache/maven/scm/ChangeSetTest.java
@@ -25,6 +25,7 @@
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
+import static org.junit.jupiter.api.Assertions.assertAll;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertNotEquals;
@@ -67,13 +68,14 @@ private static ChangeSet createInstance() {
void testAddFileWithFile() {
ChangeFile file = new ChangeFile("maven:dummy");
instance.addFile(file);
- assertTrue(instance.toString().indexOf("maven:dummy") != -1, "File
name not found in list");
+ assertTrue(instance.toString().contains("maven:dummy"), "File name not
found in list");
- assertTrue(instance.containsFilename("maven:"));
- assertTrue(instance.containsFilename(":dummy"));
- assertTrue(instance.containsFilename(":"));
- assertTrue(instance.containsFilename("maven:dummy"));
- assertFalse(instance.containsFilename("dammy"));
+ assertAll(
+ () -> assertTrue(instance.containsFilename("maven:")),
+ () -> assertTrue(instance.containsFilename(":dummy")),
+ () -> assertTrue(instance.containsFilename(":")),
+ () -> assertTrue(instance.containsFilename("maven:dummy")),
+ () -> assertFalse(instance.containsFilename("dammy")));
}
/**
@@ -83,9 +85,10 @@ void testAddFileWithFile() {
void testToString() {
// dion, Mon Apr 01 00:00:00 EST 2002, comment
String value = instance.toString();
- assertTrue(value.indexOf("dion") != -1, "author not found in string");
- assertTrue(value.indexOf("comment") != -1, "comment not found in
string");
- assertTrue(value.indexOf("Mon Apr 01") != -1, "date not found in
string");
+ assertAll(
+ () -> assertTrue(value.contains("dion"), "author not found in
string"),
+ () -> assertTrue(value.contains("comment"), "comment not found
in string"),
+ () -> assertTrue(value.contains("Mon Apr 01"), "date not found
in string"));
}
/**