This is an automated email from the ASF dual-hosted git repository.
slachiewicz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-release.git
The following commit(s) were added to refs/heads/master by this push:
new 6bd5b7a9 Parameterize version policy tests
6bd5b7a9 is described below
commit 6bd5b7a9b25a4b1d02bb49f79558f6bfd033c1fd
Author: Sylwester Lachiewicz <[email protected]>
AuthorDate: Thu Nov 19 01:10:40 2026 +0100
Parameterize version policy tests
Replace copy-pasted cases with CsvSource parameterized tests; all original
assertions are preserved.
---
.../release/policies/DefaultVersionPolicyTest.java | 45 ++++++----------------
.../shared/release/scm/HgScmTranslatorTest.java | 31 ++++++++-------
2 files changed, 30 insertions(+), 46 deletions(-)
diff --git
a/maven-release-manager/src/test/java/org/apache/maven/shared/release/policies/DefaultVersionPolicyTest.java
b/maven-release-manager/src/test/java/org/apache/maven/shared/release/policies/DefaultVersionPolicyTest.java
index 622ce80a..e5b880b3 100644
---
a/maven-release-manager/src/test/java/org/apache/maven/shared/release/policies/DefaultVersionPolicyTest.java
+++
b/maven-release-manager/src/test/java/org/apache/maven/shared/release/policies/DefaultVersionPolicyTest.java
@@ -20,46 +20,25 @@ package org.apache.maven.shared.release.policies;
import org.apache.maven.shared.release.policy.version.VersionPolicy;
import org.apache.maven.shared.release.policy.version.VersionPolicyRequest;
-import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.CsvSource;
import static org.junit.jupiter.api.Assertions.assertEquals;
class DefaultVersionPolicyTest {
private final VersionPolicy policy = new DefaultVersionPolicy();
- @Test
- void testOneDigitReleaseVersion() throws Exception {
- VersionPolicyRequest request = new
VersionPolicyRequest().setVersion("1-SNAPSHOT");
- assertEquals("1", policy.getReleaseVersion(request).getVersion());
+ @ParameterizedTest
+ @CsvSource({"1-SNAPSHOT, 1", "1.0-SNAPSHOT, 1.0", "1.0.0-SNAPSHOT, 1.0.0"})
+ void testReleaseVersion(String version, String expected) throws Exception {
+ VersionPolicyRequest request = new
VersionPolicyRequest().setVersion(version);
+ assertEquals(expected, policy.getReleaseVersion(request).getVersion());
}
- @Test
- void testOneDigitDevelopmentVersion() throws Exception {
- VersionPolicyRequest request = new
VersionPolicyRequest().setVersion("1");
- assertEquals("2-SNAPSHOT",
policy.getDevelopmentVersion(request).getVersion());
- }
-
- @Test
- void testTwoDigitsReleaseVersion() throws Exception {
- VersionPolicyRequest request = new
VersionPolicyRequest().setVersion("1.0-SNAPSHOT");
- assertEquals("1.0", policy.getReleaseVersion(request).getVersion());
- }
-
- @Test
- void testTwoDigitsDevelopmentVersion() throws Exception {
- VersionPolicyRequest request = new
VersionPolicyRequest().setVersion("1.0");
- assertEquals("1.1-SNAPSHOT",
policy.getDevelopmentVersion(request).getVersion());
- }
-
- @Test
- void testThreeDigitsReleaseVersion() throws Exception {
- VersionPolicyRequest request = new
VersionPolicyRequest().setVersion("1.0.0-SNAPSHOT");
- assertEquals("1.0.0", policy.getReleaseVersion(request).getVersion());
- }
-
- @Test
- void testThreeDigitsDevelopmentVersion() throws Exception {
- VersionPolicyRequest request = new
VersionPolicyRequest().setVersion("1.0.0");
- assertEquals("1.0.1-SNAPSHOT",
policy.getDevelopmentVersion(request).getVersion());
+ @ParameterizedTest
+ @CsvSource({"1, 2-SNAPSHOT", "1.0, 1.1-SNAPSHOT", "1.0.0, 1.0.1-SNAPSHOT"})
+ void testDevelopmentVersion(String version, String expected) throws
Exception {
+ VersionPolicyRequest request = new
VersionPolicyRequest().setVersion(version);
+ assertEquals(expected,
policy.getDevelopmentVersion(request).getVersion());
}
}
diff --git
a/maven-release-manager/src/test/java/org/apache/maven/shared/release/scm/HgScmTranslatorTest.java
b/maven-release-manager/src/test/java/org/apache/maven/shared/release/scm/HgScmTranslatorTest.java
index 1b05581b..c2dff904 100644
---
a/maven-release-manager/src/test/java/org/apache/maven/shared/release/scm/HgScmTranslatorTest.java
+++
b/maven-release-manager/src/test/java/org/apache/maven/shared/release/scm/HgScmTranslatorTest.java
@@ -18,7 +18,8 @@
*/
package org.apache.maven.shared.release.scm;
-import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.CsvSource;
import static org.junit.jupiter.api.Assertions.assertEquals;
@@ -28,21 +29,25 @@ class HgScmTranslatorTest {
/**
* @see org.apache.maven.model.Scm#getTag()
*/
- @Test
- void testResolveTag() {
- assertEquals("HEAD", scmTranslator.resolveTag("HEAD"));
- assertEquals("project-1.0", scmTranslator.resolveTag("project-1.0"));
+ @ParameterizedTest
+ @CsvSource({"HEAD, HEAD", "project-1.0, project-1.0"})
+ void testResolveTag(String tag, String expected) {
+ assertEquals(expected, scmTranslator.resolveTag(tag));
}
- @Test
- void testTranslateTagUrl() {
- assertEquals("url", scmTranslator.translateTagUrl("url", "tag", null));
- assertEquals("url", scmTranslator.translateTagUrl("url", "tag",
"tagBase"));
+ @ParameterizedTest
+ @CsvSource(
+ value = {"url, url, NULL", "url, url, tagBase"},
+ nullValues = "NULL")
+ void testTranslateTagUrl(String url, String expected, String tagBase) {
+ assertEquals(expected, scmTranslator.translateTagUrl(url, "tag",
tagBase));
}
- @Test
- void testTranslateBranchUrl() {
- assertEquals("url", scmTranslator.translateBranchUrl("url",
"branchName", null));
- assertEquals("url", scmTranslator.translateBranchUrl("url",
"branchName", "tagBase"));
+ @ParameterizedTest
+ @CsvSource(
+ value = {"url, url, NULL", "url, url, tagBase"},
+ nullValues = "NULL")
+ void testTranslateBranchUrl(String url, String expected, String tagBase) {
+ assertEquals(expected, scmTranslator.translateBranchUrl(url,
"branchName", tagBase));
}
}