This is an automated email from the ASF dual-hosted git repository.

slachiewicz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-archiver.git


The following commit(s) were added to refs/heads/master by this push:
     new d369a15  Remove commented-out dead code in MavenArchiver
d369a15 is described below

commit d369a151cfa59f708a05466f8352f65370b27436
Author: Sylwester Lachiewicz <[email protected]>
AuthorDate: Thu Nov 19 00:52:48 2026 +0100

    Remove commented-out dead code in MavenArchiver
---
 src/main/java/org/apache/maven/archiver/MavenArchiver.java | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/src/main/java/org/apache/maven/archiver/MavenArchiver.java 
b/src/main/java/org/apache/maven/archiver/MavenArchiver.java
index 5ea3929..0474d4e 100644
--- a/src/main/java/org/apache/maven/archiver/MavenArchiver.java
+++ b/src/main/java/org/apache/maven/archiver/MavenArchiver.java
@@ -500,11 +500,6 @@ public class MavenArchiver {
 
     private void addCustomEntries(Manifest m, Map<String, String> entries, 
ManifestConfiguration config)
             throws ManifestException {
-        /*
-         * TODO: rethink this, it wasn't working Artifact projectArtifact = 
project.getArtifact(); if (
-         * projectArtifact.isSnapshot() ) { Manifest.Attribute buildNumberAttr 
= new Manifest.Attribute( "Build-Number",
-         * "" + project.getSnapshotDeploymentBuildNumber() ); 
m.addConfiguredAttribute( buildNumberAttr ); }
-         */
         if (config.getPackageName() != null) {
             addManifestAttribute(m, entries, "Package", 
config.getPackageName());
         }
@@ -611,11 +606,6 @@ public class MavenArchiver {
         archiver.setDestFile(archiveFile);
 
         archiver.setForced(forced);
-        if (!archiveConfiguration.isForced() && archiver.isSupportingForced()) 
{
-            // TODO Should issue a warning here, but how do we get a logger?
-            // TODO getLog().warn(
-            // "Forced build is disabled, but disabling the forced mode isn't 
supported by the archiver." );
-        }
 
         String automaticModuleName = 
manifest.getMainSection().getAttributeValue("Automatic-Module-Name");
         if (automaticModuleName != null) {

Reply via email to