This is an automated email from the ASF dual-hosted git repository. hboutemy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/maven-downloader.git
commit b11563040acac45bb97d9f718a8f4257ed2ae632 Author: Robert Scholte <[email protected]> AuthorDate: Sun Jan 8 22:02:52 2012 +0000 Fix MSHARED-3: Infinite-loop in DefaultDownloader.download Resolved by throwing a RuntimeException with the alternative, that's be best we can do. At least it's better than an infinitive loop without a clue git-svn-id: https://svn.apache.org/repos/asf/maven/shared/trunk@1228968 13f79535-47bb-0310-9956-ffa450edef68 --- .../org/apache/maven/shared/downloader/DefaultDownloader.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/main/java/org/apache/maven/shared/downloader/DefaultDownloader.java b/src/main/java/org/apache/maven/shared/downloader/DefaultDownloader.java index f949b0f..44fef76 100644 --- a/src/main/java/org/apache/maven/shared/downloader/DefaultDownloader.java +++ b/src/main/java/org/apache/maven/shared/downloader/DefaultDownloader.java @@ -1,5 +1,8 @@ package org.apache.maven.shared.downloader; +import java.io.File; +import java.util.List; + import org.apache.maven.artifact.Artifact; import org.apache.maven.artifact.factory.ArtifactFactory; import org.apache.maven.artifact.repository.ArtifactRepository; @@ -8,9 +11,6 @@ import org.apache.maven.artifact.resolver.ArtifactResolutionException; import org.apache.maven.artifact.resolver.ArtifactResolver; import org.apache.maven.artifact.versioning.VersionRange; -import java.io.File; -import java.util.List; - /** * @author Jason van Zyl * @plexus.component @@ -28,7 +28,6 @@ public class DefaultDownloader */ private ArtifactFactory artifactFactory; - // FIXME! This calls itself, and couldn't work even if it called the other download method! public File download( String groupId, String artifactId, String version, @@ -37,7 +36,8 @@ public class DefaultDownloader throws DownloadException, DownloadNotFoundException { - return download( groupId, artifactId, version, localRepository, remoteRepositories ); + throw new RuntimeException( "Unsupported method, instead use" + + "org.apache.maven.shared.downloader.DefaultDownloader.download( String, String, String, ArtifactRepository, List )" ); } public File download( String groupId, -- To stop receiving notification emails like this one, please contact "[email protected]" <[email protected]>.
