http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-embedder/src/main/java/org/apache/maven/cli/configuration/ConfigurationProcessor.java ---------------------------------------------------------------------- diff --git a/maven-embedder/src/main/java/org/apache/maven/cli/configuration/ConfigurationProcessor.java b/maven-embedder/src/main/java/org/apache/maven/cli/configuration/ConfigurationProcessor.java index 75fb9b9..50a5854 100644 --- a/maven-embedder/src/main/java/org/apache/maven/cli/configuration/ConfigurationProcessor.java +++ b/maven-embedder/src/main/java/org/apache/maven/cli/configuration/ConfigurationProcessor.java @@ -21,6 +21,9 @@ package org.apache.maven.cli.configuration; import org.apache.maven.cli.CliRequest; +/** + * ConfigurationProcessor + */ public interface ConfigurationProcessor { void process( CliRequest request )
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-embedder/src/main/java/org/apache/maven/cli/configuration/SettingsXmlConfigurationProcessor.java ---------------------------------------------------------------------- diff --git a/maven-embedder/src/main/java/org/apache/maven/cli/configuration/SettingsXmlConfigurationProcessor.java b/maven-embedder/src/main/java/org/apache/maven/cli/configuration/SettingsXmlConfigurationProcessor.java index d9a6954..2536a22 100644 --- a/maven-embedder/src/main/java/org/apache/maven/cli/configuration/SettingsXmlConfigurationProcessor.java +++ b/maven-embedder/src/main/java/org/apache/maven/cli/configuration/SettingsXmlConfigurationProcessor.java @@ -47,6 +47,9 @@ import org.codehaus.plexus.component.annotations.Component; import org.codehaus.plexus.component.annotations.Requirement; import org.slf4j.Logger; +/** + * SettingsXmlConfigurationProcessor + */ @Component( role = ConfigurationProcessor.class, hint = SettingsXmlConfigurationProcessor.HINT ) public class SettingsXmlConfigurationProcessor implements ConfigurationProcessor http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-embedder/src/main/java/org/apache/maven/cli/event/DefaultEventSpyContext.java ---------------------------------------------------------------------- diff --git a/maven-embedder/src/main/java/org/apache/maven/cli/event/DefaultEventSpyContext.java b/maven-embedder/src/main/java/org/apache/maven/cli/event/DefaultEventSpyContext.java index f62b57e..55b1155 100644 --- a/maven-embedder/src/main/java/org/apache/maven/cli/event/DefaultEventSpyContext.java +++ b/maven-embedder/src/main/java/org/apache/maven/cli/event/DefaultEventSpyContext.java @@ -24,6 +24,9 @@ import java.util.Map; import org.apache.maven.eventspy.EventSpy; +/** + * DefaultEventSpyContext + */ public class DefaultEventSpyContext implements EventSpy.Context { http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java ---------------------------------------------------------------------- diff --git a/maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java b/maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java index 2a7d3e3..9fada05 100644 --- a/maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java +++ b/maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java @@ -49,6 +49,9 @@ import org.eclipse.aether.repository.RemoteRepository; import org.eclipse.aether.util.filter.ExclusionsDependencyFilter; import org.eclipse.aether.util.graph.visitor.PreorderNodeListGenerator; +/** + * BootstrapCoreExtensionManager + */ @Named public class BootstrapCoreExtensionManager { http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-embedder/src/main/java/org/apache/maven/cli/logging/Slf4jConfiguration.java ---------------------------------------------------------------------- diff --git a/maven-embedder/src/main/java/org/apache/maven/cli/logging/Slf4jConfiguration.java b/maven-embedder/src/main/java/org/apache/maven/cli/logging/Slf4jConfiguration.java index f64f330..8dc81c7 100644 --- a/maven-embedder/src/main/java/org/apache/maven/cli/logging/Slf4jConfiguration.java +++ b/maven-embedder/src/main/java/org/apache/maven/cli/logging/Slf4jConfiguration.java @@ -28,6 +28,9 @@ package org.apache.maven.cli.logging; */ public interface Slf4jConfiguration { + /** + * Level + */ enum Level { DEBUG, INFO, ERROR http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java ---------------------------------------------------------------------- diff --git a/maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java b/maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java index c33e8a2..984902e 100644 --- a/maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java +++ b/maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java @@ -30,6 +30,9 @@ import org.eclipse.aether.transfer.TransferCancelledException; import org.eclipse.aether.transfer.TransferEvent; import org.eclipse.aether.transfer.TransferResource; +/** + * AbstractMavenTransferListener + */ public abstract class AbstractMavenTransferListener extends AbstractTransferListener { @@ -153,6 +156,7 @@ public abstract class AbstractMavenTransferListener return format( size, unit, false ); } + @SuppressWarnings( "checkstyle:magicnumber" ) public String format( long size, ScaleUnit unit, boolean omitSymbol ) { Validate.isTrue( size >= 0L, "file size cannot be negative: %s", size ); http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-embedder/src/main/java/org/apache/maven/cli/transfer/BatchModeMavenTransferListener.java ---------------------------------------------------------------------- diff --git a/maven-embedder/src/main/java/org/apache/maven/cli/transfer/BatchModeMavenTransferListener.java b/maven-embedder/src/main/java/org/apache/maven/cli/transfer/BatchModeMavenTransferListener.java index 0e20f17..2eee8f6 100644 --- a/maven-embedder/src/main/java/org/apache/maven/cli/transfer/BatchModeMavenTransferListener.java +++ b/maven-embedder/src/main/java/org/apache/maven/cli/transfer/BatchModeMavenTransferListener.java @@ -21,6 +21,9 @@ package org.apache.maven.cli.transfer; import java.io.PrintStream; +/** + * BatchModeMavenTransferListener + */ public class BatchModeMavenTransferListener extends AbstractMavenTransferListener { http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-embedder/src/main/java/org/apache/maven/cli/transfer/Slf4jMavenTransferListener.java ---------------------------------------------------------------------- diff --git a/maven-embedder/src/main/java/org/apache/maven/cli/transfer/Slf4jMavenTransferListener.java b/maven-embedder/src/main/java/org/apache/maven/cli/transfer/Slf4jMavenTransferListener.java index 5c97acb..086e406 100644 --- a/maven-embedder/src/main/java/org/apache/maven/cli/transfer/Slf4jMavenTransferListener.java +++ b/maven-embedder/src/main/java/org/apache/maven/cli/transfer/Slf4jMavenTransferListener.java @@ -29,6 +29,9 @@ import org.eclipse.aether.transfer.TransferResource; import org.slf4j.Logger; import org.slf4j.LoggerFactory; +/** + * Slf4jMavenTransferListener + */ public class Slf4jMavenTransferListener extends AbstractTransferListener { http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java ---------------------------------------------------------------------- diff --git a/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java b/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java index c3dd043..44ee334 100644 --- a/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java +++ b/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java @@ -239,6 +239,7 @@ public class DefaultModelBuilder return this; } + @SuppressWarnings( "checkstyle:methodlength" ) @Override public ModelBuildingResult build( ModelBuildingRequest request ) throws ModelBuildingException @@ -1131,6 +1132,7 @@ public class DefaultModelBuilder return superPomProvider.getSuperModel( "4.0.0" ).clone(); } + @SuppressWarnings( "checkstyle:methodlength" ) private void importDependencyManagement( Model model, ModelBuildingRequest request, DefaultModelProblemCollector problems, Collection<String> importIds ) { http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelProblem.java ---------------------------------------------------------------------- diff --git a/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelProblem.java b/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelProblem.java index 78e81e3..e1b05aa 100644 --- a/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelProblem.java +++ b/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelProblem.java @@ -82,6 +82,7 @@ public class DefaultModelProblem * @param exception The exception that caused this problem, may be {@code null}. */ //mkleint: does this need to be public? + @SuppressWarnings( "checkstyle:parameternumber" ) public DefaultModelProblem( String message, Severity severity, Version version, String source, int lineNumber, int columnNumber, String modelId, Exception exception ) { http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelProcessor.java ---------------------------------------------------------------------- diff --git a/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelProcessor.java b/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelProcessor.java index a4d5fa9..6f4f084 100644 --- a/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelProcessor.java +++ b/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelProcessor.java @@ -31,6 +31,9 @@ import org.apache.maven.model.locator.ModelLocator; import org.codehaus.plexus.component.annotations.Component; import org.codehaus.plexus.component.annotations.Requirement; +/** + * DefaultModelProcessor + */ @Component( role = ModelProcessor.class ) public class DefaultModelProcessor implements ModelProcessor http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelData.java ---------------------------------------------------------------------- diff --git a/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelData.java b/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelData.java index b21dd0d..1f39ad4 100644 --- a/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelData.java +++ b/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelData.java @@ -206,7 +206,7 @@ class ModelData */ public String getId() { - StringBuilder buffer = new StringBuilder( 96 ); + StringBuilder buffer = new StringBuilder( 128 ); buffer.append( getGroupId() ).append( ':' ).append( getArtifactId() ).append( ':' ).append( getVersion() ); http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelProblem.java ---------------------------------------------------------------------- diff --git a/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelProblem.java b/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelProblem.java index 43272ba..2c7a72e 100644 --- a/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelProblem.java +++ b/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelProblem.java @@ -41,6 +41,9 @@ public interface ModelProblem } + /** + * Version + */ enum Version { //based on ModeBuildingResult.validationLevel http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelProblemUtils.java ---------------------------------------------------------------------- diff --git a/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelProblemUtils.java b/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelProblemUtils.java index 76c23e1..1b694c4 100644 --- a/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelProblemUtils.java +++ b/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelProblemUtils.java @@ -44,7 +44,7 @@ public class ModelProblemUtils return ""; } - StringBuilder buffer = new StringBuilder( 192 ); + StringBuilder buffer = new StringBuilder( 128 ); buffer.append( toId( model ) ); @@ -108,7 +108,7 @@ public class ModelProblemUtils */ static String toId( String groupId, String artifactId, String version ) { - StringBuilder buffer = new StringBuilder( 96 ); + StringBuilder buffer = new StringBuilder( 128 ); buffer.append( ( groupId != null && groupId.length() > 0 ) ? groupId : "[unknown-group-id]" ); buffer.append( ':' ); http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelProcessor.java ---------------------------------------------------------------------- diff --git a/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelProcessor.java b/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelProcessor.java index ca34845..c2c2ec0 100644 --- a/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelProcessor.java +++ b/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelProcessor.java @@ -22,6 +22,9 @@ package org.apache.maven.model.building; import org.apache.maven.model.io.ModelReader; import org.apache.maven.model.locator.ModelLocator; +/** + * ModelProcessor + */ @SuppressWarnings( "checkstyle:interfaceistype" ) public interface ModelProcessor extends ModelLocator, ModelReader http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-model-builder/src/main/java/org/apache/maven/model/inheritance/DefaultInheritanceAssembler.java ---------------------------------------------------------------------- diff --git a/maven-model-builder/src/main/java/org/apache/maven/model/inheritance/DefaultInheritanceAssembler.java b/maven-model-builder/src/main/java/org/apache/maven/model/inheritance/DefaultInheritanceAssembler.java index 51150db..890c845 100644 --- a/maven-model-builder/src/main/java/org/apache/maven/model/inheritance/DefaultInheritanceAssembler.java +++ b/maven-model-builder/src/main/java/org/apache/maven/model/inheritance/DefaultInheritanceAssembler.java @@ -44,6 +44,7 @@ import org.codehaus.plexus.util.StringUtils; * * @author Benjamin Bentmann */ +@SuppressWarnings( { "checkstyle:methodname" } ) @Component( role = InheritanceAssembler.class ) public class DefaultInheritanceAssembler implements InheritanceAssembler @@ -135,6 +136,9 @@ public class DefaultInheritanceAssembler return adjustment; } + /** + * InheritanceModelMerger + */ protected static class InheritanceModelMerger extends MavenModelMerger { http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-model-builder/src/main/java/org/apache/maven/model/interpolation/MavenBuildTimestamp.java ---------------------------------------------------------------------- diff --git a/maven-model-builder/src/main/java/org/apache/maven/model/interpolation/MavenBuildTimestamp.java b/maven-model-builder/src/main/java/org/apache/maven/model/interpolation/MavenBuildTimestamp.java index 9b0500d..fcec526 100644 --- a/maven-model-builder/src/main/java/org/apache/maven/model/interpolation/MavenBuildTimestamp.java +++ b/maven-model-builder/src/main/java/org/apache/maven/model/interpolation/MavenBuildTimestamp.java @@ -25,6 +25,9 @@ import java.util.GregorianCalendar; import java.util.Properties; import java.util.TimeZone; +/** + * MavenBuildTimestamp + */ public class MavenBuildTimestamp { // ISO 8601-compliant timestamp for machine readability http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-model-builder/src/main/java/org/apache/maven/model/interpolation/StringSearchModelInterpolator.java ---------------------------------------------------------------------- diff --git a/maven-model-builder/src/main/java/org/apache/maven/model/interpolation/StringSearchModelInterpolator.java b/maven-model-builder/src/main/java/org/apache/maven/model/interpolation/StringSearchModelInterpolator.java index 1d8ad04..c95cacb 100644 --- a/maven-model-builder/src/main/java/org/apache/maven/model/interpolation/StringSearchModelInterpolator.java +++ b/maven-model-builder/src/main/java/org/apache/maven/model/interpolation/StringSearchModelInterpolator.java @@ -44,6 +44,9 @@ import java.util.List; import java.util.Map; import java.util.concurrent.ConcurrentHashMap; +/** + * StringSearchModelInterpolator + */ @Component( role = ModelInterpolator.class ) public class StringSearchModelInterpolator extends AbstractStringBasedModelInterpolator http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-model-builder/src/main/java/org/apache/maven/model/management/DefaultDependencyManagementInjector.java ---------------------------------------------------------------------- diff --git a/maven-model-builder/src/main/java/org/apache/maven/model/management/DefaultDependencyManagementInjector.java b/maven-model-builder/src/main/java/org/apache/maven/model/management/DefaultDependencyManagementInjector.java index e611973..4547407 100644 --- a/maven-model-builder/src/main/java/org/apache/maven/model/management/DefaultDependencyManagementInjector.java +++ b/maven-model-builder/src/main/java/org/apache/maven/model/management/DefaultDependencyManagementInjector.java @@ -38,6 +38,7 @@ import org.codehaus.plexus.component.annotations.Component; * * @author Benjamin Bentmann */ +@SuppressWarnings( { "checkstyle:methodname" } ) @Component( role = DependencyManagementInjector.class ) public class DefaultDependencyManagementInjector implements DependencyManagementInjector @@ -51,6 +52,9 @@ public class DefaultDependencyManagementInjector merger.mergeManagedDependencies( model ); } + /** + * ManagementModelMerger + */ protected static class ManagementModelMerger extends MavenModelMerger { http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-model-builder/src/main/java/org/apache/maven/model/management/DefaultPluginManagementInjector.java ---------------------------------------------------------------------- diff --git a/maven-model-builder/src/main/java/org/apache/maven/model/management/DefaultPluginManagementInjector.java b/maven-model-builder/src/main/java/org/apache/maven/model/management/DefaultPluginManagementInjector.java index 4a50cfe..9d4dc19 100644 --- a/maven-model-builder/src/main/java/org/apache/maven/model/management/DefaultPluginManagementInjector.java +++ b/maven-model-builder/src/main/java/org/apache/maven/model/management/DefaultPluginManagementInjector.java @@ -41,6 +41,7 @@ import org.codehaus.plexus.component.annotations.Component; * * @author Benjamin Bentmann */ +@SuppressWarnings( { "checkstyle:methodname" } ) @Component( role = PluginManagementInjector.class ) public class DefaultPluginManagementInjector implements PluginManagementInjector @@ -54,6 +55,9 @@ public class DefaultPluginManagementInjector merger.mergeManagedBuildPlugins( model ); } + /** + * ManagementModelMerger + */ protected static class ManagementModelMerger extends MavenModelMerger { @@ -66,12 +70,12 @@ public class DefaultPluginManagementInjector PluginManagement pluginManagement = build.getPluginManagement(); if ( pluginManagement != null ) { - mergePluginContainer_Plugins( build, pluginManagement ); + mergePluginContainerPlugins( build, pluginManagement ); } } } - private void mergePluginContainer_Plugins( PluginContainer target, PluginContainer source ) + private void mergePluginContainerPlugins( PluginContainer target, PluginContainer source ) { List<Plugin> src = source.getPlugins(); if ( !src.isEmpty() ) http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-model-builder/src/main/java/org/apache/maven/model/merge/MavenModelMerger.java ---------------------------------------------------------------------- diff --git a/maven-model-builder/src/main/java/org/apache/maven/model/merge/MavenModelMerger.java b/maven-model-builder/src/main/java/org/apache/maven/model/merge/MavenModelMerger.java index e96425d..8e90454 100644 --- a/maven-model-builder/src/main/java/org/apache/maven/model/merge/MavenModelMerger.java +++ b/maven-model-builder/src/main/java/org/apache/maven/model/merge/MavenModelMerger.java @@ -53,6 +53,7 @@ import org.apache.maven.model.Site; * * @author Benjamin Bentmann */ +@SuppressWarnings( { "checkstyle:methodname" } ) public class MavenModelMerger extends ModelMerger { http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-model-builder/src/main/java/org/apache/maven/model/normalization/DefaultModelNormalizer.java ---------------------------------------------------------------------- diff --git a/maven-model-builder/src/main/java/org/apache/maven/model/normalization/DefaultModelNormalizer.java b/maven-model-builder/src/main/java/org/apache/maven/model/normalization/DefaultModelNormalizer.java index 2803b0a..d625bb5 100644 --- a/maven-model-builder/src/main/java/org/apache/maven/model/normalization/DefaultModelNormalizer.java +++ b/maven-model-builder/src/main/java/org/apache/maven/model/normalization/DefaultModelNormalizer.java @@ -94,6 +94,9 @@ public class DefaultModelNormalizer } } + /** + * DuplicateMerger + */ protected static class DuplicateMerger extends MavenModelMerger { http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-model-builder/src/main/java/org/apache/maven/model/profile/DefaultProfileInjector.java ---------------------------------------------------------------------- diff --git a/maven-model-builder/src/main/java/org/apache/maven/model/profile/DefaultProfileInjector.java b/maven-model-builder/src/main/java/org/apache/maven/model/profile/DefaultProfileInjector.java index aed837b..32a2fc0 100644 --- a/maven-model-builder/src/main/java/org/apache/maven/model/profile/DefaultProfileInjector.java +++ b/maven-model-builder/src/main/java/org/apache/maven/model/profile/DefaultProfileInjector.java @@ -47,6 +47,7 @@ import org.codehaus.plexus.component.annotations.Component; * @author Benjamin Bentmann */ @Component( role = ProfileInjector.class ) +@SuppressWarnings( { "checkstyle:methodname" } ) public class DefaultProfileInjector implements ProfileInjector { @@ -72,6 +73,9 @@ public class DefaultProfileInjector } } + /** + * ProfileModelMerger + */ protected static class ProfileModelMerger extends MavenModelMerger { http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-model-builder/src/main/java/org/apache/maven/model/resolution/WorkspaceModelResolver.java ---------------------------------------------------------------------- diff --git a/maven-model-builder/src/main/java/org/apache/maven/model/resolution/WorkspaceModelResolver.java b/maven-model-builder/src/main/java/org/apache/maven/model/resolution/WorkspaceModelResolver.java index d12edea..8264ed7 100644 --- a/maven-model-builder/src/main/java/org/apache/maven/model/resolution/WorkspaceModelResolver.java +++ b/maven-model-builder/src/main/java/org/apache/maven/model/resolution/WorkspaceModelResolver.java @@ -21,6 +21,9 @@ package org.apache.maven.model.resolution; import org.apache.maven.model.Model; +/** + * WorkspaceModelResolver + */ public interface WorkspaceModelResolver { http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java ---------------------------------------------------------------------- diff --git a/maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java b/maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java index f0acb1f..4018618 100644 --- a/maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java +++ b/maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java @@ -979,6 +979,7 @@ public class DefaultModelValidator return false; } + @SuppressWarnings( "checkstyle:parameternumber" ) private boolean validateEnum( String fieldName, ModelProblemCollector problems, Severity severity, Version version, String string, String sourceHint, InputLocationTracker tracker, String... validValues ) @@ -1001,6 +1002,7 @@ public class DefaultModelValidator return false; } + @SuppressWarnings( "checkstyle:parameternumber" ) private boolean validateBannedCharacters( String fieldName, ModelProblemCollector problems, Severity severity, Version version, String string, String sourceHint, InputLocationTracker tracker, String banned ) http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-plugin-api/src/main/java/org/apache/maven/plugin/MojoNotFoundException.java ---------------------------------------------------------------------- diff --git a/maven-plugin-api/src/main/java/org/apache/maven/plugin/MojoNotFoundException.java b/maven-plugin-api/src/main/java/org/apache/maven/plugin/MojoNotFoundException.java index cdb9a23..cd97fb7 100644 --- a/maven-plugin-api/src/main/java/org/apache/maven/plugin/MojoNotFoundException.java +++ b/maven-plugin-api/src/main/java/org/apache/maven/plugin/MojoNotFoundException.java @@ -25,6 +25,9 @@ import java.util.List; import org.apache.maven.plugin.descriptor.MojoDescriptor; import org.apache.maven.plugin.descriptor.PluginDescriptor; +/** + * MojoNotFoundException + */ public class MojoNotFoundException extends Exception { http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/DuplicateMojoDescriptorException.java ---------------------------------------------------------------------- diff --git a/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/DuplicateMojoDescriptorException.java b/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/DuplicateMojoDescriptorException.java index b236c8c..59e0d5d 100644 --- a/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/DuplicateMojoDescriptorException.java +++ b/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/DuplicateMojoDescriptorException.java @@ -19,6 +19,9 @@ package org.apache.maven.plugin.descriptor; * under the License. */ +/** + * DuplicateMojoDescriptorException + */ public class DuplicateMojoDescriptorException extends InvalidPluginDescriptorException { http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/DuplicateParameterException.java ---------------------------------------------------------------------- diff --git a/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/DuplicateParameterException.java b/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/DuplicateParameterException.java index 4cad9b7..69fea1c 100644 --- a/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/DuplicateParameterException.java +++ b/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/DuplicateParameterException.java @@ -19,6 +19,9 @@ package org.apache.maven.plugin.descriptor; * under the License. */ +/** + * DuplicateParameterException + */ public class DuplicateParameterException extends InvalidPluginDescriptorException { http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/InvalidPluginDescriptorException.java ---------------------------------------------------------------------- diff --git a/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/InvalidPluginDescriptorException.java b/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/InvalidPluginDescriptorException.java index 4b8e739..f63fd26 100644 --- a/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/InvalidPluginDescriptorException.java +++ b/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/InvalidPluginDescriptorException.java @@ -21,6 +21,9 @@ package org.apache.maven.plugin.descriptor; import org.codehaus.plexus.configuration.PlexusConfigurationException; +/** + * InvalidPluginDescriptorException + */ public class InvalidPluginDescriptorException extends PlexusConfigurationException { http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilder.java ---------------------------------------------------------------------- diff --git a/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilder.java b/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilder.java index 865e66b..3df7ab4 100644 --- a/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilder.java +++ b/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilder.java @@ -114,6 +114,7 @@ public class PluginDescriptorBuilder return pluginDescriptor; } + @SuppressWarnings( "checkstyle:methodlength" ) public MojoDescriptor buildComponentDescriptor( PlexusConfiguration c, PluginDescriptor pluginDescriptor ) throws PlexusConfigurationException { http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionResolver.java ---------------------------------------------------------------------- diff --git a/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionResolver.java b/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionResolver.java index c087bdf..ef7f0cf 100644 --- a/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionResolver.java +++ b/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionResolver.java @@ -150,6 +150,7 @@ public class DefaultVersionResolver return this; } + @SuppressWarnings( "checkstyle:methodlength" ) public VersionResult resolveVersion( RepositorySystemSession session, VersionRequest request ) throws VersionResolutionException { @@ -482,7 +483,7 @@ public class DefaultVersionResolver this.repository = repository; } - public boolean isOutdated( String timestamp ) + boolean isOutdated( String timestamp ) { return timestamp != null && timestamp.compareTo( this.timestamp ) > 0; } http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenResolverModule.java ---------------------------------------------------------------------- diff --git a/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenResolverModule.java b/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenResolverModule.java index 070b91c..1e49bfc 100644 --- a/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenResolverModule.java +++ b/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenResolverModule.java @@ -35,6 +35,9 @@ import org.eclipse.aether.impl.VersionRangeResolver; import org.eclipse.aether.impl.VersionResolver; import org.eclipse.aether.impl.guice.AetherModule; +/** + * MavenResolverModule + */ public final class MavenResolverModule extends AbstractModule { http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenWorkspaceReader.java ---------------------------------------------------------------------- diff --git a/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenWorkspaceReader.java b/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenWorkspaceReader.java index 270cf58..c87f723 100644 --- a/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenWorkspaceReader.java +++ b/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenWorkspaceReader.java @@ -23,6 +23,9 @@ import org.apache.maven.model.Model; import org.eclipse.aether.artifact.Artifact; import org.eclipse.aether.repository.WorkspaceReader; +/** + * MavenWorkspaceReader + */ public interface MavenWorkspaceReader extends WorkspaceReader { http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenSimpleLoggerFactory.java ---------------------------------------------------------------------- diff --git a/maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenSimpleLoggerFactory.java b/maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenSimpleLoggerFactory.java index d56e346..4adfdbe 100644 --- a/maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenSimpleLoggerFactory.java +++ b/maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenSimpleLoggerFactory.java @@ -21,6 +21,9 @@ package org.slf4j.impl; import org.slf4j.Logger; +/** + * MavenSimpleLoggerFactory + */ public class MavenSimpleLoggerFactory extends SimpleLoggerFactory { http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/pom.xml ---------------------------------------------------------------------- diff --git a/pom.xml b/pom.xml index 66b9d27..b912b67 100644 --- a/pom.xml +++ b/pom.xml @@ -73,7 +73,7 @@ under the License. <distributionShortName>Maven</distributionShortName> <distributionName>Apache Maven</distributionName> <maven.site.path>ref/3-LATEST</maven.site.path> - <checkstyle.violation.ignore>RedundantThrows,NewlineAtEndOfFile,ParameterNumber,MethodLength,FileLength,JavadocType,MagicNumber,InnerAssignment,MethodName</checkstyle.violation.ignore> + <checkstyle.violation.ignore>None</checkstyle.violation.ignore> <checkstyle.excludes>**/package-info.java</checkstyle.excludes> </properties>
