[maven] 04/05: [MNG-6631] documented the performance intent

[hboutemy]

This is an automated email from the ASF dual-hosted git repository.

hboutemy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven.git

commit d34e8fbdc0c12295232a48ef4f277a166d8e8f08
Author: Hervé Boutemy <hbout...@apache.org>
AuthorDate: Sat Apr 27 18:22:32 2019 +0200

    [MNG-6631] documented the performance intent
---
 .../maven/artifact/versioning/DefaultArtifactVersion.java     | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git 
a/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java
 
b/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java
index 0739098..75b19fa 100644
--- 
a/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java
+++ 
b/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java
@@ -221,12 +221,14 @@ public class DefaultArtifactVersion
 
     private static Integer tryParseInt( String s )
     {
+        // for performance, check digits instead of relying later on catching 
NumberFormatException
+        if ( !isDigits( s ) )
+        {
+            return null;
+        }
+
         try
         {
-            if ( !isDigits( s ) )
-            {
-                return null;
-            }
             long longValue = Long.parseLong( s );
             if ( longValue > Integer.MAX_VALUE )
             {
@@ -236,6 +238,7 @@ public class DefaultArtifactVersion
         }
         catch ( NumberFormatException e )
         {
+            // should never happen since checked isDigits(s) before 
             return null;
         }
     }