This is an automated email from the ASF dual-hosted git repository.

michaelo pushed a commit to branch WAGON-576
in repository https://gitbox.apache.org/repos/asf/maven-wagon.git

commit eaf621eef45ce7b245c54253be4d316d4fe62d9e
Author: Michael Osipov <micha...@apache.org>
AuthorDate: Sun Feb 23 20:37:51 2020 +0100

    [WAGON-576] Retry handler docs are possibly wrong
---
 wagon-providers/wagon-http/src/site/apt/index.apt | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/wagon-providers/wagon-http/src/site/apt/index.apt 
b/wagon-providers/wagon-http/src/site/apt/index.apt
index 12ccf46..159fe03 100644
--- a/wagon-providers/wagon-http/src/site/apt/index.apt
+++ b/wagon-providers/wagon-http/src/site/apt/index.apt
@@ -66,13 +66,20 @@ Features
 
     * <<<default>>> will use an instance of 
{{{http://hc.apache.org/httpcomponents-client-ga/httpclient/apidocs/org/apache/http/impl/client/DefaultHttpRequestRetryHandler.html}<<<DefaultHttpRequestRetryHandler>>>}}
 respecting <<<requestSentEnabled>>>, <<<count>>> and <<<nonRetryableClasses>>>.
 
-    *<< <standard>>> will use an instance of 
{{{http://hc.apache.org/httpcomponents-client-ga/httpclient/apidocs/org/apache/http/impl/client/StandardHttpRequestRetryHandler.html}<<<StandardHttpRequestRetryHandler>>>}}
 respecting <<<requestSentEnabled>>> and <<<count>>>.
+    *<<<standard>>> will use an instance of 
{{{http://hc.apache.org/httpcomponents-client-ga/httpclient/apidocs/org/apache/http/impl/client/StandardHttpRequestRetryHandler.html}<<<StandardHttpRequestRetryHandler>>>}}
 respecting <<<requestSentEnabled>>> and <<<count>>>.
 
     * Any fully qualified name of a 
{{{https://hc.apache.org/httpcomponents-client-ga/httpclient/apidocs/org/apache/http/client/HttpRequestRetryHandler.html}<<<HttpRequestRetryHandler>>>}}
 implementation will be instantiated with its default constructor.
 
+        [Attention] This will not work with the shaded version bundled with 
Maven.
+
  * <<<maven.wagon.http.retryHandler.requestSentEnabled>>> = 
<<<requestSentEnabled>>> for <<<default>>> or <<<standard>>> implementations.
 
  * <<<maven.wagon.http.retryHandler.count>>> = number of retries for 
<<<default>>> or <<<standard>>> implementations.
 
  * <<<maven.wagon.http.retryHandler.nonRetryableClasses>>> = a comma-separated 
list of fully qualified class names bypassing the retries (only the 
<<<default>>> implementation).
  If not set, the default value from 
{{{http://hc.apache.org/httpcomponents-client-ga/httpclient/apidocs/org/apache/http/impl/client/DefaultHttpRequestRetryHandler.html}<<<DefaultHttpRequestRetryHandler>>>}}
 will be used.
+
+ []
+
+        [Attention] Any retry handler will only react on initial exceptions, 
it will <not> salvage in-flight failures of ongoing streams.
+

Reply via email to