[maven-shared-utils] 01/03: [MSHARED-431] Escape arguments including hash-signs

[slachiewicz]

This is an automated email from the ASF dual-hosted git repository.

slachiewicz pushed a commit to branch MSHARED-297
in repository https://gitbox.apache.org/repos/asf/maven-shared-utils.git

commit 76605ac236ee5fb64062581209e8ee941efcea77
Author: Rob Oxspring <roxspr...@imapmail.org>
AuthorDate: Wed May 27 21:49:20 2020 +0100

    [MSHARED-431] Escape arguments including hash-signs
---
 src/main/java/org/apache/maven/shared/utils/cli/shell/BourneShell.java | 2 +-
 .../java/org/apache/maven/shared/utils/cli/shell/BourneShellTest.java  | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git 
a/src/main/java/org/apache/maven/shared/utils/cli/shell/BourneShell.java 
b/src/main/java/org/apache/maven/shared/utils/cli/shell/BourneShell.java
index 1793cbb..02586af 100644
--- a/src/main/java/org/apache/maven/shared/utils/cli/shell/BourneShell.java
+++ b/src/main/java/org/apache/maven/shared/utils/cli/shell/BourneShell.java
@@ -34,7 +34,7 @@ public class BourneShell
     private static final char DOUBLE_QUOTATION = '"';
 
     private static final char[] BASH_QUOTING_TRIGGER_CHARS =
-        { ' ', '$', ';', '&', '|', '<', '>', '*', '?', '(', ')', '[', ']', 
'{', '}', '`' };
+        { ' ', '$', ';', '&', '|', '<', '>', '*', '?', '(', ')', '[', ']', 
'{', '}', '`', '#' };
 
     /**
      * Create instance of BourneShell.
diff --git 
a/src/test/java/org/apache/maven/shared/utils/cli/shell/BourneShellTest.java 
b/src/test/java/org/apache/maven/shared/utils/cli/shell/BourneShellTest.java
index c83287c..7d5c456 100644
--- a/src/test/java/org/apache/maven/shared/utils/cli/shell/BourneShellTest.java
+++ b/src/test/java/org/apache/maven/shared/utils/cli/shell/BourneShellTest.java
@@ -186,13 +186,14 @@ public class BourneShellTest
         commandline.createArg().setValue( "{" );
         commandline.createArg().setValue( "}" );
         commandline.createArg().setValue( "`" );
+        commandline.createArg().setValue( "#" );
 
         List<String> lines = commandline.getShell().getShellCommandLine( 
commandline.getArguments() );
         System.out.println( lines  );
 
         assertEquals( "/bin/sh", lines.get( 0 ) );
         assertEquals( "-c", lines.get( 1 ) );
-        assertEquals( "chmod \" \" \"|\" \"&&\" \"||\" \";\" \";;\" \"&\" 
\"()\" \"<\" \"<<\" \">\" \">>\" \"*\" \"?\" \"[\" \"]\" \"{\" \"}\" \"`\"",
+        assertEquals( "chmod \" \" \"|\" \"&&\" \"||\" \";\" \";;\" \"&\" 
\"()\" \"<\" \"<<\" \">\" \">>\" \"*\" \"?\" \"[\" \"]\" \"{\" \"}\" \"`\" 
\"#\"",
                       lines.get( 2 ) );
     }