[maven] 08/18: Avoid code duplication

[rfscholte]

This is an automated email from the ASF dual-hosted git repository.

rfscholte pushed a commit to branch MNG-7063
in repository https://gitbox.apache.org/repos/asf/maven.git

commit 9674e74375172a77e51ddacd71c8fca8328fe8c9
Author: Guillaume Nodet <gno...@gmail.com>
AuthorDate: Mon Nov 30 10:39:14 2020 +0100

    Avoid code duplication
---
 .../apache/maven/model/building/DefaultModelBuilder.java | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)

diff --git 
a/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
 
b/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
index 896f324..83e69b0 100644
--- 
a/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
+++ 
b/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
@@ -660,18 +660,10 @@ public class DefaultModelBuilder
                     throw e;
                 }
 
-                if ( modelSource instanceof FileModelSource )
-                {
-                    problems.add( new ModelProblemCollectorRequest( 
Severity.ERROR, Version.V20 )
-                        .setMessage( "Malformed POM " + 
modelSource.getLocation() + ": " + e.getMessage() )
-                        .setException( e ) );
-                }
-                else
-                {
-                    problems.add( new ModelProblemCollectorRequest( 
Severity.WARNING, Version.V20 )
-                        .setMessage( "Malformed POM " + 
modelSource.getLocation() + ": " + e.getMessage() )
-                        .setException( e ) );
-                }
+                Severity severity = ( modelSource instanceof FileModelSource ) 
? Severity.ERROR : Severity.WARNING;
+                problems.add( new ModelProblemCollectorRequest( severity, 
Version.V20 )
+                    .setMessage( "Malformed POM " + modelSource.getLocation() 
+ ": " + e.getMessage() )
+                    .setException( e ) );
             }
 
             if ( source != null )