Replaced '$beforeRouteChange' with '$routeChangeStart' in the WebUI. The '$beforeRouteChange' event was renamed to '$routeChangeStart' in v1.0.0rc11[1] of Angular. The change was purely a name change for consistency; it still fires at the same time.
There's a typo in the Changelog about the new name, but the commit[2] shows the real new name: '$routeChangeStart'. [1] https://github.com/angular/angular.js/blob/ 9bef436b22f0cd57c294f1db1958f46e64fcfed1/ CHANGELOG.md#breaking-changes [2] https://github.com/angular/angular.js/commit/ 7c2428218893f59c6a4499667488009ca67f3385 Original review: https://reviews.apache.org/r/12701/ From: Ross Allen <ross...@mesosphe.re> Review: https://reviews.apache.org/r/12739 Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/10dfbfec Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/10dfbfec Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/10dfbfec Branch: refs/heads/master Commit: 10dfbfec6a51fb1e0ba744e5570bfb31115210ea Parents: 804a8b0 Author: Benjamin Mahler <bmah...@twitter.com> Authored: Thu Jul 18 16:39:55 2013 -0700 Committer: Benjamin Mahler <bmah...@twitter.com> Committed: Thu Jul 18 16:39:55 2013 -0700 ---------------------------------------------------------------------- src/webui/master/static/js/controllers.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/10dfbfec/src/webui/master/static/js/controllers.js ---------------------------------------------------------------------- diff --git a/src/webui/master/static/js/controllers.js b/src/webui/master/static/js/controllers.js index 4caa64e..f8db42b 100644 --- a/src/webui/master/static/js/controllers.js +++ b/src/webui/master/static/js/controllers.js @@ -389,7 +389,7 @@ horizons.create(context, "mem", random(context, "mem"), [0, 10], "mb"); // Do any cleanup before we change the route. - $scope.$on('$beforeRouteChange', function() { context.stop(); }); + $scope.$on('$routeChangeStart', function() { context.stop(); }); }); @@ -434,7 +434,7 @@ } $(document).on('state_updated', update); - $scope.$on('$beforeRouteChange', function() { + $scope.$on('$routeChangeStart', function() { $(document).off('state_updated', update); }); }); @@ -542,7 +542,7 @@ } $(document).on('state_updated', update); - $scope.$on('$beforeRouteChange', function() { + $scope.$on('$routeChangeStart', function() { $(document).off('state_updated', update); }); }); @@ -649,7 +649,7 @@ } $(document).on('state_updated', update); - $scope.$on('$beforeRouteChange', function() { + $scope.$on('$routeChangeStart', function() { $(document).off('state_updated', update); }); }); @@ -741,7 +741,7 @@ } $(document).on('state_updated', update); - $scope.$on('$beforeRouteChange', function() { + $scope.$on('$routeChangeStart', function() { $(document).off('state_updated', update); }); }); @@ -793,7 +793,7 @@ } $(document).on('state_updated', update); - $scope.$on('$beforeRouteChange', function() { + $scope.$on('$routeChangeStart', function() { $(document).off('state_updated', update); }); });
