Changed GetTask.limit type to int32 with default value 100. This protobuf message should be int32 instead of string. Default value is set to TASK_LIMIT (100).
Review: https://reviews.apache.org/r/48401/ Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/51ef622e Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/51ef622e Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/51ef622e Branch: refs/heads/master Commit: 51ef622e15174310463ae52385d699ab6281eec4 Parents: 608e382 Author: Jay Guo <guojian...@cn.ibm.com> Authored: Fri Jun 17 19:50:49 2016 -0700 Committer: Vinod Kone <vinodk...@gmail.com> Committed: Fri Jun 17 19:50:49 2016 -0700 ---------------------------------------------------------------------- include/mesos/master/master.proto | 6 +++++- include/mesos/v1/master/master.proto | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/51ef622e/include/mesos/master/master.proto ---------------------------------------------------------------------- diff --git a/include/mesos/master/master.proto b/include/mesos/master/master.proto index 3b85b81..fa92240 100644 --- a/include/mesos/master/master.proto +++ b/include/mesos/master/master.proto @@ -115,8 +115,12 @@ message Call { optional string length = 3; } + // Call::GetTasks requests 'limit' number of tasks starting + // from 'offset'. Tasks are sorted in 'order', either ascending + // or descending based on timestamp. If 'limit' is not set, + // default value 100 will be used. message GetTasks { - optional string limit = 1; + optional uint32 limit = 1 [default = 100]; optional uint32 offset = 2; optional string order = 3; } http://git-wip-us.apache.org/repos/asf/mesos/blob/51ef622e/include/mesos/v1/master/master.proto ---------------------------------------------------------------------- diff --git a/include/mesos/v1/master/master.proto b/include/mesos/v1/master/master.proto index 5a6bbeb..b45d6d9 100644 --- a/include/mesos/v1/master/master.proto +++ b/include/mesos/v1/master/master.proto @@ -115,8 +115,12 @@ message Call { optional string length = 3; } + // Call::GetTasks requests 'limit' number of tasks starting + // from 'offset'. Tasks are sorted in 'order', either ascending + // or descending based on timestamp. If 'limit' is not set, + // default value 100 will be used. message GetTasks { - optional string limit = 1; + optional uint32 limit = 1 [default = 100]; optional uint32 offset = 2; optional string order = 3; }
